Re: [review-request] michaelw/toaster/new-build-button-v2

[Michael Wood <michael.g.wood@intel.com>]

Thanks. I've pushed that fix for that to the same branch.

On 18/11/14 12:29, Barros Pena, Belen wrote:
> Hi Michael,
>
> This is working really nicely. I just found a couple of tiny issues with
> the layout. There is a patch here
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/n
> ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6
>
> I've also found a small problem with the project input field: the save
> button should be disabled whenever the field is empty, which is not the
> case right now. This is how I tested it: in the new build dialog, click on
> the 'change' icon, select a different project and then, without clicking
> 'save', delete the project name from the input field. The 'save' button is
> still enabled (it should be disabled) and, if you click it, it will set
> the project to the project name you just deleted from the input field,
> which is a bit weird. We can avoid this kind of thing (and also having to
> show error messages) by disabling the buttons when their input fields are
> empty.
>
> Thanks!!
>
> Belén
>
>
>
> On 17/11/2014 15:07, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> poky-contrib michaelw/toaster/new-build-button-v2
>>
>> bitbake: toaster: project page remove additional tooltip for Change pencil
>> bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon
>> bitbake: toaster: Add New Build Button feature
>> bitbake: toaster: libtoaster: Add getProjectInfo utility function
>> bitbake: toaster: Create libtoaster.js with some utility functions
>>
>> Thanks,
>>
>> Michael
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster