From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
tomasz.figa@gmail.com, linux@arm.linux.org.uk,
thomas.ab@samsung.com, linux@roeck-us.net
Subject: Re: [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver
Date: Wed, 19 Nov 2014 15:26:23 +0100 [thread overview]
Message-ID: <546CA88F.5010406@samsung.com> (raw)
In-Reply-To: <000801d003a7$404882a0$c0d987e0$@samsung.com>
On 19/11/14 04:16, Pankaj Dubey wrote:
>>> > > +static int pmu_restart_notify(struct notifier_block *this,
>>> > > + unsigned long code, void *unused)
>>> > > +{
>>> > > + pmu_raw_writel(0x1, EXYNOS_SWRESET);
>> >
>> > Is it also valid on exynos5440 ? Doesn't it cause any harm there ?
>> > Perhaps we could add a comment saying it has not effect on that SoC ?
>> >
> Seeing original code from exynos.c (restart hook) I can say it's not valid
> for exynos5440.
> But it should not cause any harm as of now, because for exynos54440 PMU will
> not be probed.
> If in future support for exynos5440 PMU gets added, that time one may need
> to consider this
> point. This will be applicable for any SoC which does not have same register
> for restart.
OK, I wasn't aware PMU driver won't be probed for exynos5440 at all.
Anyway, I hope we can get someone testing the patch set on exynos5440.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver
Date: Wed, 19 Nov 2014 15:26:23 +0100 [thread overview]
Message-ID: <546CA88F.5010406@samsung.com> (raw)
In-Reply-To: <000801d003a7$404882a0$c0d987e0$@samsung.com>
On 19/11/14 04:16, Pankaj Dubey wrote:
>>> > > +static int pmu_restart_notify(struct notifier_block *this,
>>> > > + unsigned long code, void *unused)
>>> > > +{
>>> > > + pmu_raw_writel(0x1, EXYNOS_SWRESET);
>> >
>> > Is it also valid on exynos5440 ? Doesn't it cause any harm there ?
>> > Perhaps we could add a comment saying it has not effect on that SoC ?
>> >
> Seeing original code from exynos.c (restart hook) I can say it's not valid
> for exynos5440.
> But it should not cause any harm as of now, because for exynos54440 PMU will
> not be probed.
> If in future support for exynos5440 PMU gets added, that time one may need
> to consider this
> point. This will be applicable for any SoC which does not have same register
> for restart.
OK, I wasn't aware PMU driver won't be probed for exynos5440 at all.
Anyway, I hope we can get someone testing the patch set on exynos5440.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-11-19 14:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 10:47 [PATCH v5 0/2] Handle reboot for Exynos SoC via restart_handler Pankaj Dubey
2014-11-18 10:47 ` Pankaj Dubey
2014-11-18 10:47 ` [PATCH v5 1/2] clk: samsung: exynos5440: move restart code into clock driver Pankaj Dubey
2014-11-18 10:47 ` Pankaj Dubey
2014-11-18 15:17 ` Sylwester Nawrocki
2014-11-18 15:17 ` Sylwester Nawrocki
2014-11-19 3:37 ` Pankaj Dubey
2014-11-19 3:37 ` Pankaj Dubey
2014-11-20 17:48 ` Sylwester Nawrocki
2014-11-20 17:48 ` Sylwester Nawrocki
2014-11-21 10:30 ` Pankaj Dubey
2014-11-21 10:30 ` Pankaj Dubey
2014-11-22 2:08 ` Kukjin Kim
2014-11-22 2:08 ` Kukjin Kim
2014-11-24 2:16 ` amit daniel kachhap
2014-11-24 2:16 ` amit daniel kachhap
2014-11-18 10:47 ` [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver Pankaj Dubey
2014-11-18 10:47 ` Pankaj Dubey
2014-11-18 15:19 ` Sylwester Nawrocki
2014-11-18 15:19 ` Sylwester Nawrocki
2014-11-19 3:16 ` Pankaj Dubey
2014-11-19 3:16 ` Pankaj Dubey
2014-11-19 14:26 ` Sylwester Nawrocki [this message]
2014-11-19 14:26 ` Sylwester Nawrocki
2014-11-21 4:28 ` Vivek Gautam
2014-11-21 4:28 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CA88F.5010406@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.