From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>, Doug Anderson <dianders@chromium.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Simon Glass <sjg@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards
Date: Wed, 19 Nov 2014 18:59:31 +0100 [thread overview]
Message-ID: <546CDA83.5060002@collabora.co.uk> (raw)
In-Reply-To: <20141119174709.GF22111@sirena.org.uk>
Hello Mark,
On 11/19/2014 06:47 PM, Mark Brown wrote:
> These are bugs. The device tree should describe the hardware, spidev is
> a Linux implementation detail. Provide a compatible string for the
> device that is there just as you would for any other device.
>
Thanks a lot for your explanation.
>> OK. Please don't take my comments as a NAK on this patch. I should
>> have done the same grep myself before sending--sorry. I just
>> remembered the old conversation and looked for that instead.
>
> Please take this as one.
>
Ok
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards
Date: Wed, 19 Nov 2014 18:59:31 +0100 [thread overview]
Message-ID: <546CDA83.5060002@collabora.co.uk> (raw)
In-Reply-To: <20141119174709.GF22111@sirena.org.uk>
Hello Mark,
On 11/19/2014 06:47 PM, Mark Brown wrote:
> These are bugs. The device tree should describe the hardware, spidev is
> a Linux implementation detail. Provide a compatible string for the
> device that is there just as you would for any other device.
>
Thanks a lot for your explanation.
>> OK. Please don't take my comments as a NAK on this patch. I should
>> have done the same grep myself before sending--sorry. I just
>> remembered the old conversation and looked for that instead.
>
> Please take this as one.
>
Ok
Best regards,
Javier
next prev parent reply other threads:[~2014-11-19 17:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:43 [PATCH 0/3] ARM: dts: Add spidev nodes for Exynos Chromebooks Javier Martinez Canillas
2014-11-17 17:43 ` Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards Javier Martinez Canillas
2014-11-17 17:43 ` Javier Martinez Canillas
2014-11-18 17:50 ` Doug Anderson
2014-11-18 17:50 ` Doug Anderson
2014-11-19 10:07 ` Javier Martinez Canillas
2014-11-19 10:07 ` Javier Martinez Canillas
2014-11-19 17:19 ` Doug Anderson
2014-11-19 17:19 ` Doug Anderson
2014-11-19 17:29 ` Javier Martinez Canillas
2014-11-19 17:29 ` Javier Martinez Canillas
2014-11-19 17:47 ` Mark Brown
2014-11-19 17:47 ` Mark Brown
2014-11-19 17:59 ` Javier Martinez Canillas [this message]
2014-11-19 17:59 ` Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 2/3] ARM: dts: Add spidev registration to exynos5250-snow Javier Martinez Canillas
2014-11-17 17:43 ` Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 3/3] ARM: exynos_defconfig: Enable user mode SPI device support Javier Martinez Canillas
2014-11-17 17:43 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CDA83.5060002@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@chromium.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.