From: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Wu, Feng" <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"gleb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<gleb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org"
<joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
"tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org"
<tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org"
<hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
"x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 02/13] KVM: Initialize VT-d Posted-Interrtups Descriptor
Date: Thu, 20 Nov 2014 13:00:52 +0800 [thread overview]
Message-ID: <546D7584.6070505@linux.intel.com> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F0022A04CD-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 2014/11/20 12:53, Wu, Feng wrote:
>
>
>> -----Original Message-----
<snit>
>>> + /*
>>> + * Initialize Posted-Interrupt Descriptor
>>> + */
>>> +
>>> + pi_clear_sn(&vmx->pi_desc);
>>> + vmx->pi_desc.nv = POSTED_INTR_VECTOR;
>>> +
>>> + /* Physical mode for Notificaiton Event */
>>> + vmx->pi_desc.ndm = 0;
>>> + dest = cpu_physical_id(vmx->vcpu.cpu);
>>> +
>>> + if (x2apic_mode)
>> Hi Feng,
>> Could you try to use x2apic_enabled() here so you don't
>> need to export x2apic_mode?
>> Regards!
>> Gerry
>
> In that case, we should also export x2apic_enabled(), right?
Hi Feng,
x2apic_enabled() is a static inline function:)
Regards!
Gerry
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <jiang.liu@linux.intel.com>
To: "Wu, Feng" <feng.wu@intel.com>,
"gleb@kernel.org" <gleb@kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/13] KVM: Initialize VT-d Posted-Interrtups Descriptor
Date: Thu, 20 Nov 2014 13:00:52 +0800 [thread overview]
Message-ID: <546D7584.6070505@linux.intel.com> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F0022A04CD@SHSMSX104.ccr.corp.intel.com>
On 2014/11/20 12:53, Wu, Feng wrote:
>
>
>> -----Original Message-----
<snit>
>>> + /*
>>> + * Initialize Posted-Interrupt Descriptor
>>> + */
>>> +
>>> + pi_clear_sn(&vmx->pi_desc);
>>> + vmx->pi_desc.nv = POSTED_INTR_VECTOR;
>>> +
>>> + /* Physical mode for Notificaiton Event */
>>> + vmx->pi_desc.ndm = 0;
>>> + dest = cpu_physical_id(vmx->vcpu.cpu);
>>> +
>>> + if (x2apic_mode)
>> Hi Feng,
>> Could you try to use x2apic_enabled() here so you don't
>> need to export x2apic_mode?
>> Regards!
>> Gerry
>
> In that case, we should also export x2apic_enabled(), right?
Hi Feng,
x2apic_enabled() is a static inline function:)
Regards!
Gerry
next prev parent reply other threads:[~2014-11-20 5:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 6:26 [PATCH 00/13] Add VT-d Posted-Interrupts support for KVM Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-1-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-10 6:26 ` [PATCH 01/13] iommu/vt-d: VT-d Posted-Interrupts feature detection Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-2-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-11 13:38 ` Jiang Liu
2014-11-11 13:38 ` Jiang Liu
2014-11-10 6:26 ` [PATCH 02/13] KVM: Initialize VT-d Posted-Interrtups Descriptor Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-3-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-10 21:57 ` Alex Williamson
2014-11-10 21:57 ` Alex Williamson
2014-11-11 13:35 ` Jiang Liu
2014-11-11 13:35 ` Jiang Liu
[not found] ` <546210B1.7060007-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-11-20 4:53 ` Wu, Feng
2014-11-20 4:53 ` Wu, Feng
[not found] ` <E959C4978C3B6342920538CF579893F0022A04CD-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-20 5:00 ` Jiang Liu [this message]
2014-11-20 5:00 ` Jiang Liu
2014-11-10 6:26 ` [PATCH 03/13] KVM: Add KVM_CAP_PI to detect VT-d Posted-Interrtups Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 04/13] iommu/vt-d: Adjust 'struct irte' to better suit for VT-d Posted-Interrupts Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-5-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-11 13:43 ` Jiang Liu
2014-11-11 13:43 ` Jiang Liu
2014-11-10 6:26 ` [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-6-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-10 21:57 ` Alex Williamson
2014-11-10 21:57 ` Alex Williamson
2014-11-10 6:26 ` [PATCH 06/13] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 07/13] x86, irq: Define a global vector for VT-d Posted-Interrupts Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 08/13] KVM: Update Posted-Interrupts descriptor during VCPU scheduling Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 09/13] KVM: Change NDST field after " Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 10/13] KVM: Add the handler for Wake-up Vector Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 11/13] KVM: Suppress posted-interrupt when 'SN' is set Feng Wu
2014-11-10 6:26 ` Feng Wu
2014-11-10 6:26 ` [PATCH 12/13] iommu/vt-d: No need to migrating irq for VT-d Posted-Interrtups Feng Wu
2014-11-10 6:26 ` Feng Wu
[not found] ` <1415600812-27773-13-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-11 13:48 ` Jiang Liu
2014-11-11 13:48 ` Jiang Liu
2014-11-10 6:26 ` [PATCH 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
[not found] ` <1415600812-27773-14-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-10 18:15 ` several messages Thomas Gleixner
2014-11-10 18:15 ` Thomas Gleixner
2014-11-11 2:28 ` Jiang Liu
2014-11-11 2:28 ` Jiang Liu
[not found] ` <5461745F.2080703-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-11-11 6:37 ` Wu, Feng
2014-11-11 6:37 ` Wu, Feng
2014-11-10 21:57 ` [PATCH 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Alex Williamson
2014-11-10 21:57 ` Alex Williamson
-- strict thread matches above, loose matches on Subject: below --
2014-11-11 9:20 [PATCH 02/13] KVM: Initialize VT-d Posted-Interrtups Descriptor Wu, Feng
2014-11-11 9:20 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546D7584.6070505@linux.intel.com \
--to=jiang.liu-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=gleb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.