All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
	Michael Marineau <mike@marineau.org>,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: 3.18-rc regression: drm/nouveau: use shared fences for readable objects
Date: Thu, 20 Nov 2014 09:41:15 +0100	[thread overview]
Message-ID: <546DA92B.9080501@canonical.com> (raw)
In-Reply-To: <546D2309.90201@mni.thm.de>

Op 20-11-14 om 00:08 schreef Tobias Klausmann:
> On 19.11.2014 09:10, Maarten Lankhorst wrote:
>> ...
>> On the EDITED patch from fixed-fences-for-bisect, can you do the following:
>>
>> In nouveau/nv84_fence.c function nv84_fence_context_new, remove
>>
>> fctx->base.sequence = nv84_fence_read(chan);
>>
>> and add back
>>
>> nouveau_bo_wr32(priv->bo, chan->chid * 16/4, 0x00000000);
>>
>> ...
>
> Added the above on top of your "fixed-fences-for-bisect" branch and guessed it would work, but did not :/
> Anyway, as this "initializes" the fence to a known state, maybe you should consider pushing that.
Hey,

There is a reason I don't set it to a known state on nv84+.

Channel 2 is created, fence seqno ends up being 100, other channel waits on seqno reaching 100.
Channel 2 is destroyed, and immediately recreated. Seqno is reset to 0.
Other channel waits for channel 2's seqno being 100.

The other channel can keep waiting indefinitely.

I guess it might be useful to reset the contents of the bo to zero on allocation, but it should not be done in fence_context_new.

~Maarten

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
	Michael Marineau <mike@marineau.org>,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>,
	David Airlie <airlied@linux.ie>
Subject: Re: 3.18-rc regression: drm/nouveau: use shared fences for readable objects
Date: Thu, 20 Nov 2014 09:41:15 +0100	[thread overview]
Message-ID: <546DA92B.9080501@canonical.com> (raw)
In-Reply-To: <546D2309.90201@mni.thm.de>

Op 20-11-14 om 00:08 schreef Tobias Klausmann:
> On 19.11.2014 09:10, Maarten Lankhorst wrote:
>> ...
>> On the EDITED patch from fixed-fences-for-bisect, can you do the following:
>>
>> In nouveau/nv84_fence.c function nv84_fence_context_new, remove
>>
>> fctx->base.sequence = nv84_fence_read(chan);
>>
>> and add back
>>
>> nouveau_bo_wr32(priv->bo, chan->chid * 16/4, 0x00000000);
>>
>> ...
>
> Added the above on top of your "fixed-fences-for-bisect" branch and guessed it would work, but did not :/
> Anyway, as this "initializes" the fence to a known state, maybe you should consider pushing that.
Hey,

There is a reason I don't set it to a known state on nv84+.

Channel 2 is created, fence seqno ends up being 100, other channel waits on seqno reaching 100.
Channel 2 is destroyed, and immediately recreated. Seqno is reset to 0.
Other channel waits for channel 2's seqno being 100.

The other channel can keep waiting indefinitely.

I guess it might be useful to reset the contents of the bo to zero on allocation, but it should not be done in fence_context_new.

~Maarten


  reply	other threads:[~2014-11-20  8:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  6:43 3.18-rc regression: drm/nouveau: use shared fences for readable objects Michael Marineau
2014-11-19  8:10 ` Maarten Lankhorst
2014-11-19  8:10   ` Maarten Lankhorst
2014-11-19 15:18   ` Tobias Klausmann
2014-11-19 23:08   ` Tobias Klausmann
2014-11-20  8:41     ` Maarten Lankhorst [this message]
2014-11-20  8:41       ` Maarten Lankhorst
2014-11-20  4:06   ` Michael Marineau
2014-11-20  8:53     ` Maarten Lankhorst
2014-11-20  8:53       ` Maarten Lankhorst
2014-11-21 19:13       ` Michael Marineau
2014-11-22  0:19       ` Michael Marineau
2014-11-22 16:56         ` Maarten Lankhorst
2014-11-22 16:56           ` Maarten Lankhorst
2014-11-22 19:45           ` Michael Marineau
2014-11-22 20:16             ` Michael Marineau
2014-11-25  7:43               ` Maarten Lankhorst
2014-11-25  7:43                 ` Maarten Lankhorst
2014-11-26 20:29                 ` Michael Marineau
2014-11-27  1:18                   ` Tobias Klausmann
2014-11-27  8:33                     ` Maarten Lankhorst
2014-11-27  8:33                       ` Maarten Lankhorst
2014-11-30 21:10                       ` Michael Marineau
  -- strict thread matches above, loose matches on Subject: below --
2014-11-29  0:51 Ian Kumlien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546DA92B.9080501@canonical.com \
    --to=maarten.lankhorst@canonical.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike@marineau.org \
    --cc=tobias.johannes.klausmann@mni.thm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.