From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Padmavathi Venna <padma.v@samsung.com>,
sbkim73@samsung.com, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()
Date: Thu, 20 Nov 2014 11:11:09 +0100 [thread overview]
Message-ID: <546DBE3D.90206@samsung.com> (raw)
In-Reply-To: <CAAgF-BemHSdcmzkqOUX+JNMLu0-GXs0EGm8YWHt+CBRP8Wa5DA@mail.gmail.com>
Hi,
On 20/11/14 08:04, Padma Venkat wrote:
>> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
>> > index 947352d..8db8c66 100644
>> > --- a/sound/soc/samsung/i2s.c
>> > +++ b/sound/soc/samsung/i2s.c
>> > @@ -494,7 +494,7 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai,
>> > if (dir == SND_SOC_CLOCK_IN)
>> > mod |= 1 << i2s_regs->cdclkcon_off;
>> > else
>> > - mod &= 0 << i2s_regs->cdclkcon_off;
>> > + mod &= ~(1 << i2s_regs->cdclkcon_off);
>
> Thanks for pointing this. In my local machine it was properly done but
> while rebasing on linux-next I did some mistake. There is one more
> place in set_sysclk which need to be corrected here
> mod &= 0 << i2s_regs->rclksrc_off
> can you include this change also in your patch or should I post a new
> patch for all?
OK, I'll also correct this and resend the patch.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()
Date: Thu, 20 Nov 2014 11:11:09 +0100 [thread overview]
Message-ID: <546DBE3D.90206@samsung.com> (raw)
In-Reply-To: <CAAgF-BemHSdcmzkqOUX+JNMLu0-GXs0EGm8YWHt+CBRP8Wa5DA@mail.gmail.com>
Hi,
On 20/11/14 08:04, Padma Venkat wrote:
>> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
>> > index 947352d..8db8c66 100644
>> > --- a/sound/soc/samsung/i2s.c
>> > +++ b/sound/soc/samsung/i2s.c
>> > @@ -494,7 +494,7 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai,
>> > if (dir == SND_SOC_CLOCK_IN)
>> > mod |= 1 << i2s_regs->cdclkcon_off;
>> > else
>> > - mod &= 0 << i2s_regs->cdclkcon_off;
>> > + mod &= ~(1 << i2s_regs->cdclkcon_off);
>
> Thanks for pointing this. In my local machine it was properly done but
> while rebasing on linux-next I did some mistake. There is one more
> place in set_sysclk which need to be corrected here
> mod &= 0 << i2s_regs->rclksrc_off
> can you include this change also in your patch or should I post a new
> patch for all?
OK, I'll also correct this and resend the patch.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-11-20 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 18:11 [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk() Sylwester Nawrocki
2014-11-19 18:11 ` Sylwester Nawrocki
2014-11-20 7:04 ` [alsa-devel] " Padma Venkat
2014-11-20 7:04 ` Padma Venkat
2014-11-20 10:11 ` Sylwester Nawrocki [this message]
2014-11-20 10:11 ` Sylwester Nawrocki
2014-11-20 10:15 ` Padma Venkat
2014-11-20 10:15 ` Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DBE3D.90206@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.