All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>,
	Clark Laughlin <clark.laughlin@linaro.org>,
	tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 for-4.5 1/5] xen: arm: Add earlyprintk for McDivitt.
Date: Thu, 20 Nov 2014 11:18:10 +0000	[thread overview]
Message-ID: <546DCDF2.3050704@linaro.org> (raw)
In-Reply-To: <1416410895-20461-1-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 11/19/2014 03:28 PM, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>


> ---
> v2: Remove pointless/unused baud rate setting.
> 
> A bunch of other entries have these, but cleaning them up is out of scope here I think.

Agreed.

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

> ---
>  xen/arch/arm/Rules.mk |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 572d854..30c7823 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -95,6 +95,11 @@ EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x1c020000
>  EARLY_UART_REG_SHIFT := 2
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), xgene-mcdivitt)
> +EARLY_PRINTK_INC := 8250
> +EARLY_UART_BASE_ADDRESS := 0x1c021000
> +EARLY_UART_REG_SHIFT := 2
> +endif
>  ifeq ($(CONFIG_EARLY_PRINTK), juno)
>  EARLY_PRINTK_INC := pl011
>  EARLY_PRINTK_BAUD := 115200
> 


-- 
Julien Grall

  reply	other threads:[~2014-11-20 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 15:27 [PATCH 0/5 v2 for-4.5] xen: arm: xgene bug fixes + support for McDivitt Ian Campbell
2014-11-19 15:28 ` [PATCH v2 for-4.5 1/5] xen: arm: Add earlyprintk " Ian Campbell
2014-11-20 11:18   ` Julien Grall [this message]
2014-11-19 15:28 ` [PATCH v2 for-4.5 2/5] xen: arm: Drop EARLY_PRINTK_BAUD from entries which don't set ..._INIT_UART Ian Campbell
2014-11-20 11:20   ` Julien Grall
2014-11-19 15:28 ` [PATCH v2 for-4.5 3/5] xen: arm: correct off by one in xgene-storm's map_one_mmio Ian Campbell
2014-11-20 11:23   ` Julien Grall
2014-11-19 15:28 ` [PATCH v2 for-4.5 4/5] xen: arm: correct specific mappings for PCIE0 on X-Gene Ian Campbell
2014-11-19 15:28 ` [PATCH v2 for-4.5 5/5] xen: arm: Support the other 4 PCI buses on Xgene Ian Campbell
2014-11-20 11:26   ` Julien Grall
2014-11-25 15:01   ` Pranavkumar Sawargaonkar
2014-11-25 15:07     ` Ian Campbell
2014-11-19 21:27 ` [PATCH 0/5 v2 for-4.5] xen: arm: xgene bug fixes + support for McDivitt Konrad Rzeszutek Wilk
2014-11-20 15:58   ` Ian Campbell
2014-11-20 19:45     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546DCDF2.3050704@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=clark.laughlin@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=pranavkumar@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.