Re: [PATCH v2 for-4.5 2/5] xen: arm: Drop EARLY_PRINTK_BAUD from entries which don't set ..._INIT_UART

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 11/19/2014 03:28 PM, Ian Campbell wrote:
> EARLY_PRINTK_BAUD doesn't do anything unless EARLY_PRINTK_INIT_UART is set.
> 
> Furthermore only the pl011 driver implements the init routine at all, so the
> entries which use 8250 and specified a BAUD were doubly wrong.

NIT: and exynos4210

Maybe "use 8250" should be replaced by "other UARTs drivers"?

> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,


> ---
> v2: New patch.
> ---
>  xen/arch/arm/Rules.mk |    7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 30c7823..4ee51a9 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -45,7 +45,6 @@ ifeq ($(debug),y)
>  # Early printk for versatile express
>  ifeq ($(CONFIG_EARLY_PRINTK), vexpress)
>  EARLY_PRINTK_INC := pl011
> -EARLY_PRINTK_BAUD := 38400
>  EARLY_UART_BASE_ADDRESS := 0x1c090000
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), fastmodel)
> @@ -56,12 +55,10 @@ EARLY_UART_BASE_ADDRESS := 0x1c090000
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), exynos5250)
>  EARLY_PRINTK_INC := exynos4210
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x12c20000
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), midway)
>  EARLY_PRINTK_INC := pl011
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0xfff36000
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), omap5432)
> @@ -91,7 +88,6 @@ EARLY_UART_REG_SHIFT := 2
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), xgene-storm)
>  EARLY_PRINTK_INC := 8250
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x1c020000
>  EARLY_UART_REG_SHIFT := 2
>  endif
> @@ -102,18 +98,15 @@ EARLY_UART_REG_SHIFT := 2
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), juno)
>  EARLY_PRINTK_INC := pl011
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x7ff80000
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
>  EARLY_PRINTK_INC := 8250
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0xE4007000
>  EARLY_UART_REG_SHIFT := 2
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), seattle)
>  EARLY_PRINTK_INC := pl011
> -EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0xe1010000
>  endif
>  
> 


-- 
Julien Grall