Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am 20.11.2014 um 17:18 schrieb Kevin Wolf:
> Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
>> On Wed, 19 Nov 2014 14:40:07 +0000
>> Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>>> On 19 November 2014 14:01, Ekaterina Tumanova
>>> <tumanova@linux.vnet.ibm.com> wrote:
>>>> Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>>>
>>> Could you give the compiler error/warning message, please
>>> (and the compiler version)?
>>>
>>> These changes look sensible but it's not clear to me why
>>> the current code would cause a compilation failure or why
>>> that would be specific to i386...
>>
>> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry
>> and blocksize support for backing devices", which did not compile on
>> i386 (see <546C8161.10100@de.ibm.com>).
> 
> Where does it need to be squashed in? We want to keep the tree
> bisectable, so breaking the build and then fixing it at the end of the
> series isn't an option.

I think Kate just wanted to avoid spamming the list with v3 if only one 
patch is fixed up when there was no review comment about the content of
the series. Using the -in-reply-to option plus a comment in the patch
would have avoided the confusion - I guess.

Christian