Re: [PATCH 0/2] staging: mtd: Support for GigaDevice SPI NAND flash

["arnaud.mouiche@gmail.com" <arnaud.mouiche@gmail.com>]

Le 21/11/2014 02:16, Qi Wang 王起 (qiwang) a écrit :
>> On 11/20/2014 10:18 AM, Ezequiel Garcia wrote:
>> Hm, perhaps it's better to rely in the NAND core code and avoid that BBT
>> and ECC code handling duplication?
If it means using the framework from drivers/mtd/nand directory, no, 
definitely not.
This framework rely on common things that every raw nand devices are 
sharing, and on nand controllers from the SOC side.
That was my first attempt when looking for a spinand driver, but I 
quickly switch to
>>
>> Ionela and I are preparing an SPI NAND framework, but it's far from
>> ready yet, so if you have something to submit, please do so :)
> Yes, duplicate BBT and ECC code from nand code do is not a good idea.
> But SPI NAND framework should be a standalone module in MTD, might cause
> chaos if it still rely on NAND core code, that is my only concern.
> How do you think?
The ideal way to do should be to factorize the BBT for nand / onenand / 
spinand, or to provide helpers than are common.

Concerning ECC, we can even decide to drop software ECC for spinand. 
Current spinand device embed the required ecc hardware, correctly 
designed for the target nand (required ecc strength).
(may be I'm wrong on this point)

Arnaud

>
> Thanks
>
> Qi Wang
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/