From: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
To: bpqw <bpqw@micron.com>,
Brian Norris <computersforpeace@gmail.com>,
"arnaud.mouiche@invoxia.com" <arnaud.mouiche@invoxia.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Cc: "ionela.voinescu@imgtec.com" <ionela.voinescu@imgtec.com>
Subject: Re: [PATCH 0/2] staging: mtd: Support for GigaDevice SPI NAND flash
Date: Tue, 25 Nov 2014 13:59:00 -0300 [thread overview]
Message-ID: <5474B554.5070206@imgtec.com> (raw)
In-Reply-To: <87F60714EC601C4C83DFF1D2E3D390A049D3E5@NTXXIAMBX02.xacn.micron.com>
On 11/25/2014 04:02 AM, bpqw wrote:
>> Yeah, I've been thinking about this for some time. Right now, I think that
>> SPI NAND is just that: a NAND over SPI, so I'm doing some experiments
>> around this design:
>>
>> Userspace
>> ------------------
>> MTD
>> ------------------
>> NAND core
>> ------------------
>> SPI NAND core
>> ------------------
>> SPI NAND device
>> ------------------
>> SPI core
>> ------------------
>> SPI master
>> ------------------
>> Hardware
>
> I have finished a initial version of SPI-NAND framework based on drivers/staging/
> mt29f_spinand/mt29f_spinand.c . The structure is the same as yours, just treate SPI
> NAND as a NAND over SPI, put SPI NAND core under NAND core. Do you think it is a
> good structure to start with? Because it is a quick product, I even do not finish
> the unregisger function. So just care about the structure. Any suggestion about the
> patch is welcomed.
>
Hm.. interesting. Ionela and I have started a similar work. However,
we've splitted the code in two: spi-nand-base.c and spi-nand-device.c.
The former handles the NAND logic, and the latter implements the
specific SPI commands.
The idea behind this separation is to allow for better evolution of the
code, given we are not sure the direction the SPI NAND devices will take.
I'm not sure how to handle a parallel effort like this and I don't want
to stop you from working. I'll have some code submitted by this week.
Maybe we can discuss it as well?
--
Ezequiel
next prev parent reply other threads:[~2014-11-25 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 8:39 [PATCH 0/2] staging: mtd: Support for GigaDevice SPI NAND flash bpqw
2014-11-20 13:18 ` Ezequiel Garcia
2014-11-25 7:02 ` bpqw
2014-11-25 16:59 ` Ezequiel Garcia [this message]
[not found] <mailman.22397.1416508326.22890.linux-mtd@lists.infradead.org>
2014-11-21 1:16 ` Qi Wang 王起 (qiwang)
2014-11-21 9:24 ` arnaud.mouiche
2014-11-21 11:51 ` Ezequiel Garcia
-- strict thread matches above, loose matches on Subject: below --
2014-11-06 15:51 Ionela Voinescu
2014-11-06 16:05 ` Greg KH
2014-11-06 17:32 ` Ionela Voinescu
2014-11-06 17:44 ` Greg KH
2014-11-06 18:03 ` Ionela Voinescu
2014-11-06 18:17 ` Ezequiel Garcia
2014-11-06 19:20 ` Brian Norris
2014-11-07 13:00 ` Ionela Voinescu
2014-11-10 9:00 ` arnaud.mouiche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474B554.5070206@imgtec.com \
--to=ezequiel.garcia@imgtec.com \
--cc=arnaud.mouiche@invoxia.com \
--cc=bpqw@micron.com \
--cc=computersforpeace@gmail.com \
--cc=ionela.voinescu@imgtec.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.