From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-scsi@vger.kernel.org, davem@davemloft.net,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 00/10] Re-implement am53c974 driver
Date: Fri, 21 Nov 2014 11:33:35 +0100 [thread overview]
Message-ID: <546F14FF.3080509@suse.de> (raw)
In-Reply-To: <20141121102639.GA31016@lst.de>
On 11/21/2014 11:26 AM, Christoph Hellwig wrote:
> On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote:
>> Hi all,
>>
>> having found some issues with the current tmscsim driver
>> I looked at the code and found is really awkward to clean
>> up.
>> Seeing that the am53c974 chip is actually based on the
>> 'ESP' chip design I've re-implemented it based on the
>> common esp_scsi routines. This new driver
>> (cunningly named 'am53c974') provides all features
>> found on the tmscsim driver, with the goal of obsoleting
>> the old tmscsim driver.
>> Tested with Tekram DC390 and qemu esp-scsi.
>
> This looks very nice!
>
> Three high level comments:
>
> - please Cc Dave for changes to esp_scsi
That's what I thought, too, but 'get_maintainers.pl' doesn't
know about him. Maybe we should fix this up ...
> - please Cc Guennadi as the tmscsim maintainer
> - this probably should deprecated and/or remove the tmscsim driver
>
That was the general idea. I just thought to be conservative and
add a new driver. But yeah, the idea is to sent another patch
to remove tmscsim altogether.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-21 10:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:27 [PATCH 00/10] Re-implement am53c974 driver Hannes Reinecke
2014-11-21 9:27 ` [PATCH 01/10] esp_scsi: spellcheck 'driver' Hannes Reinecke
2014-11-21 9:35 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 02/10] esp_scsi: make number of tags configurable Hannes Reinecke
2014-11-21 9:37 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 03/10] esp_scsi: convert to dev_printk Hannes Reinecke
2014-11-21 9:37 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 04/10] esp_scsi: debug event and command Hannes Reinecke
2014-11-21 9:38 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 05/10] esp_scsi: read status registers Hannes Reinecke
2014-11-21 9:43 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 06/10] scsi: add 'am53c974' driver Hannes Reinecke
2014-11-21 10:14 ` Paolo Bonzini
2014-11-21 10:34 ` Hannes Reinecke
2014-11-21 10:20 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 07/10] esp: Use FIFO for command submission Hannes Reinecke
2014-11-21 10:04 ` Paolo Bonzini
2014-11-21 10:38 ` Hannes Reinecke
2014-11-21 10:50 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 08/10] am53c974: BLAST residual handling Hannes Reinecke
2014-11-21 10:10 ` Paolo Bonzini
2014-11-21 10:29 ` Hannes Reinecke
2014-11-21 9:27 ` [PATCH 09/10] esp: correctly detect am53c974 Hannes Reinecke
2014-11-21 10:11 ` Paolo Bonzini
2014-11-21 9:27 ` [PATCH 10/10] esp: enable CONFIG2_FENAB for am53c974 Hannes Reinecke
2014-11-21 10:08 ` Paolo Bonzini
2014-11-21 10:22 ` Hannes Reinecke
2014-11-21 10:52 ` Paolo Bonzini
2014-11-21 10:26 ` [PATCH 00/10] Re-implement am53c974 driver Christoph Hellwig
2014-11-21 10:33 ` Hannes Reinecke [this message]
2014-11-21 10:47 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F14FF.3080509@suse.de \
--to=hare@suse.de \
--cc=davem@davemloft.net \
--cc=g.liakhovetski@gmx.de \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.