All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] NVMe: Update module version major number
@ 2014-11-21 22:16 Keith Busch
  2014-11-22  1:23 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2014-11-21 22:16 UTC (permalink / raw)


It's already near impossible to tell what bits someone is running based on
a 'modinfo nvme', and I don't want to try guessing if someone is running
blk-mq or bio-based. Let's make it obvious with the module version that
the blk-mq conversion is a major change. Future bio-based versions can
increment to 0.10 in a fork if revisions occur.

Cc: Jens Axboe <axboe at kernel.dk>
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
Based on linux-block for-next

 drivers/block/nvme-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index dbb4aae..0da7756 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2966,6 +2966,6 @@ static void __exit nvme_exit(void)
 
 MODULE_AUTHOR("Matthew Wilcox <willy at linux.intel.com>");
 MODULE_LICENSE("GPL");
-MODULE_VERSION("0.9");
+MODULE_VERSION("1.0");
 module_init(nvme_init);
 module_exit(nvme_exit);
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] NVMe: Update module version major number
  2014-11-21 22:16 [PATCH] NVMe: Update module version major number Keith Busch
@ 2014-11-22  1:23 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2014-11-22  1:23 UTC (permalink / raw)


On 11/21/2014 03:16 PM, Keith Busch wrote:
> It's already near impossible to tell what bits someone is running based on
> a 'modinfo nvme', and I don't want to try guessing if someone is running
> blk-mq or bio-based. Let's make it obvious with the module version that
> the blk-mq conversion is a major change. Future bio-based versions can
> increment to 0.10 in a fork if revisions occur.

Thanks, added to the mix. In general I don't put much faith into version 
numbers, you should be able to tell when people report what kernel they 
are running. Distro backports sometimes make that difficult, though.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-22  1:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21 22:16 [PATCH] NVMe: Update module version major number Keith Busch
2014-11-22  1:23 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.