From: Kukjin Kim <kgene@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: kgene@kernel.org, drake@endlessm.com,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com
Subject: Re: [PATCH] ARM: dts: Specify default clocks for Exynos4 camera devices
Date: Sat, 22 Nov 2014 23:14:13 +0900 [thread overview]
Message-ID: <54709A35.5080101@kernel.org> (raw)
In-Reply-To: <1416500099-19656-1-git-send-email-s.nawrocki@samsung.com>
On 11/21/14 01:14, Sylwester Nawrocki wrote:
> Specify the default mux and divider clocks in device tree
> to ensure the FIMC devices on Trats, Trats2, Universal_c210
> and Odroid X2/U3 boards are clocked from recommended clock
> source and with maximum supported frequency.
> For Trats2 also the MIPI-CSIS and the camera sensor clocks
> are configured, the 'clock-frequency' property is deprecated
> in favour of 'assigned-clock-rates' property.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 16 ++++++++++++
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 16 ++++++++++++
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 16 ++++++++++++
> arch/arm/boot/dts/exynos4412-trats2.dts | 32 ++++++++++++++++++++---
> 4 files changed, 77 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index f516da9..7208362 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -431,18 +431,34 @@
>
> fimc_0: fimc@11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_1: fimc@11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_2: fimc@11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_3: fimc@11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index d50eb3a..aaf0cae 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -473,18 +473,34 @@
>
> fimc_0: fimc@11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_1: fimc@11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_2: fimc@11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_3: fimc@11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index c697ff0..adf1331 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -82,18 +82,34 @@
>
> fimc_0: fimc@11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_1: fimc@11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_2: fimc@11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_3: fimc@11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 8ee20bd..08bc948 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -701,28 +701,51 @@
> pinctrl-0 = <&cam_port_a_clk_active &cam_port_b_clk_active>;
> pinctrl-names = "default";
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_CAM0>,
> + <&clock CLK_MOUT_CAM1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>,
> + <&clock CLK_MOUT_MPLL_USER_T>;
>
> fimc_0: fimc@11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_1: fimc@11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_2: fimc@11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_3: fimc@11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> csis_0: csis@11880000 {
> status = "okay";
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> - clock-frequency = <176000000>;
> + assigned-clocks = <&clock CLK_MOUT_CSIS0>,
> + <&clock CLK_SCLK_CSIS0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
>
> /* Camera C (3) MIPI CSI-2 (CSIS0) */
> port@3 {
> @@ -736,10 +759,13 @@
> };
>
> csis_1: csis@11890000 {
> + status = "okay";
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> - clock-frequency = <160000000>;
> - status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_CSIS1>,
> + <&clock CLK_SCLK_CSIS1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
>
> /* Camera D (4) MIPI CSI-2 (CSIS1) */
> port@4 {
Applied, thanks.
- Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Specify default clocks for Exynos4 camera devices
Date: Sat, 22 Nov 2014 23:14:13 +0900 [thread overview]
Message-ID: <54709A35.5080101@kernel.org> (raw)
In-Reply-To: <1416500099-19656-1-git-send-email-s.nawrocki@samsung.com>
On 11/21/14 01:14, Sylwester Nawrocki wrote:
> Specify the default mux and divider clocks in device tree
> to ensure the FIMC devices on Trats, Trats2, Universal_c210
> and Odroid X2/U3 boards are clocked from recommended clock
> source and with maximum supported frequency.
> For Trats2 also the MIPI-CSIS and the camera sensor clocks
> are configured, the 'clock-frequency' property is deprecated
> in favour of 'assigned-clock-rates' property.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 16 ++++++++++++
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 16 ++++++++++++
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 16 ++++++++++++
> arch/arm/boot/dts/exynos4412-trats2.dts | 32 ++++++++++++++++++++---
> 4 files changed, 77 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index f516da9..7208362 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -431,18 +431,34 @@
>
> fimc_0: fimc at 11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_1: fimc at 11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_2: fimc at 11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_3: fimc at 11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index d50eb3a..aaf0cae 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -473,18 +473,34 @@
>
> fimc_0: fimc at 11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_1: fimc at 11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_2: fimc at 11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
>
> fimc_3: fimc at 11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
> + assigned-clock-rates = <0>, <160000000>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index c697ff0..adf1331 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -82,18 +82,34 @@
>
> fimc_0: fimc at 11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_1: fimc at 11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_2: fimc at 11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_3: fimc at 11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 8ee20bd..08bc948 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -701,28 +701,51 @@
> pinctrl-0 = <&cam_port_a_clk_active &cam_port_b_clk_active>;
> pinctrl-names = "default";
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_CAM0>,
> + <&clock CLK_MOUT_CAM1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>,
> + <&clock CLK_MOUT_MPLL_USER_T>;
>
> fimc_0: fimc at 11800000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC0>,
> + <&clock CLK_SCLK_FIMC0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_1: fimc at 11810000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC1>,
> + <&clock CLK_SCLK_FIMC1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_2: fimc at 11820000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC2>,
> + <&clock CLK_SCLK_FIMC2>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> fimc_3: fimc at 11830000 {
> status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_FIMC3>,
> + <&clock CLK_SCLK_FIMC3>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
> };
>
> csis_0: csis at 11880000 {
> status = "okay";
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> - clock-frequency = <176000000>;
> + assigned-clocks = <&clock CLK_MOUT_CSIS0>,
> + <&clock CLK_SCLK_CSIS0>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
>
> /* Camera C (3) MIPI CSI-2 (CSIS0) */
> port at 3 {
> @@ -736,10 +759,13 @@
> };
>
> csis_1: csis at 11890000 {
> + status = "okay";
> vddcore-supply = <&ldo8_reg>;
> vddio-supply = <&ldo10_reg>;
> - clock-frequency = <160000000>;
> - status = "okay";
> + assigned-clocks = <&clock CLK_MOUT_CSIS1>,
> + <&clock CLK_SCLK_CSIS1>;
> + assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>;
> + assigned-clock-rates = <0>, <176000000>;
>
> /* Camera D (4) MIPI CSI-2 (CSIS1) */
> port at 4 {
Applied, thanks.
- Kukjin
next prev parent reply other threads:[~2014-11-22 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 16:14 [PATCH] ARM: dts: Specify default clocks for Exynos4 camera devices Sylwester Nawrocki
2014-11-20 16:14 ` Sylwester Nawrocki
2014-11-22 14:14 ` Kukjin Kim [this message]
2014-11-22 14:14 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54709A35.5080101@kernel.org \
--to=kgene@kernel.org \
--cc=drake@endlessm.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.