From: xerofoify@gmail.com (nick)
To: linux-arm-kernel@lists.infradead.org
Subject: FIX ME in xsysace.c
Date: Mon, 24 Nov 2014 06:28:08 -0500 [thread overview]
Message-ID: <54731648.8010006@gmail.com> (raw)
In-Reply-To: <5a8be93a4204429daf16bc8f62cdd0cd@BY2FFO11FD005.protection.gbl>
On 14-11-24 02:47 AM, Michal Simek wrote:
> Hi,
>
> On 11/24/2014 05:19 AM, nick wrote:
>> Greetings Michal and others,
>> I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.
>
> I think that will be the best to c&p that fixme which you are talking about.
> Definitely feel free to fix whatever fixme is there and send the patch
> for fixing it.
>
> Thanks,
> Michal
>
Here is the fix me.
int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
Cheers Nick
WARNING: multiple messages have this Message-ID (diff)
From: nick <xerofoify@gmail.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, soren.brinkmann@xilinx.com,
grant.likely@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: FIX ME in xsysace.c
Date: Mon, 24 Nov 2014 06:28:08 -0500 [thread overview]
Message-ID: <54731648.8010006@gmail.com> (raw)
In-Reply-To: <5a8be93a4204429daf16bc8f62cdd0cd@BY2FFO11FD005.protection.gbl>
On 14-11-24 02:47 AM, Michal Simek wrote:
> Hi,
>
> On 11/24/2014 05:19 AM, nick wrote:
>> Greetings Michal and others,
>> I am wondering about the FIX ME in xsysace.c as it seems not correct due to my knowledge of most hardware protocols using a predetermined bit wide and therefore this could be hard coded. If someone can respond on if I am correct in removing this fix me it would be greatly appreciated.
>
> I think that will be the best to c&p that fixme which you are talking about.
> Definitely feel free to fix whatever fixme is there and send the patch
> for fixing it.
>
> Thanks,
> Michal
>
Here is the fix me.
int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
Cheers Nick
next prev parent reply other threads:[~2014-11-24 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 4:19 FIX ME in xsysace.c nick
2014-11-24 4:19 ` nick
2014-11-24 7:47 ` Michal Simek
2014-11-24 7:47 ` Michal Simek
2014-11-24 7:47 ` Michal Simek
2014-11-24 11:28 ` nick [this message]
2014-11-24 11:28 ` nick
2014-11-24 14:32 ` Michal Simek
2014-11-24 14:32 ` Michal Simek
2014-11-24 14:32 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54731648.8010006@gmail.com \
--to=xerofoify@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.