Re: [PATCH] ASoC: bt-sco: support wide band speech

[Lars-Peter Clausen <lars@metafoo.de>]

On 11/24/2014 01:58 PM, Barry Song wrote:
> 2014-11-24 20:45 GMT+08:00 Lars-Peter Clausen <lars@metafoo.de>:
>> On 11/24/2014 01:29 PM, Barry Song wrote:
>>>
>>> From: Yibo Cai <yibo.cai@csr.com>
>>>
>>> HFP1.6 requires support for wide band speech(16KHz) over Bluetooth.
>>>
>>> Signed-off-by: Yibo Cai <yibo.cai@csr.com>
>>> Signed-off-by: Barry Song <Baohua.Song@csr.com>
>>> ---
>>>    sound/soc/codecs/bt-sco.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/sound/soc/codecs/bt-sco.c b/sound/soc/codecs/bt-sco.c
>>> index c4cf069..fc0664b 100644
>>> --- a/sound/soc/codecs/bt-sco.c
>>> +++ b/sound/soc/codecs/bt-sco.c
>>> @@ -31,14 +31,14 @@ static struct snd_soc_dai_driver bt_sco_dai = {
>>>                  .stream_name = "Playback",
>>>                  .channels_min = 1,
>>>                  .channels_max = 1,
>>> -               .rates = SNDRV_PCM_RATE_8000,
>>> +               .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
>>
>>
>> This will break those bluetooth modules that only work with 8k.
>
> how do you think if we use device-tree "compatible" to differentiate
> these two kinds of BT modules?
> for non-DT platform, platform_device_id?

Yes, I think that's what we need to do.

- Lars