* [PATCH] ASoC: bt-sco: support wide band speech
@ 2014-11-24 12:29 Barry Song
2014-11-24 12:45 ` Lars-Peter Clausen
0 siblings, 1 reply; 4+ messages in thread
From: Barry Song @ 2014-11-24 12:29 UTC (permalink / raw)
To: broonie, lgirdwood; +Cc: alsa-devel, Yibo Cai, workgroup.linux, Barry Song
From: Yibo Cai <yibo.cai@csr.com>
HFP1.6 requires support for wide band speech(16KHz) over Bluetooth.
Signed-off-by: Yibo Cai <yibo.cai@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
sound/soc/codecs/bt-sco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/bt-sco.c b/sound/soc/codecs/bt-sco.c
index c4cf069..fc0664b 100644
--- a/sound/soc/codecs/bt-sco.c
+++ b/sound/soc/codecs/bt-sco.c
@@ -31,14 +31,14 @@ static struct snd_soc_dai_driver bt_sco_dai = {
.stream_name = "Playback",
.channels_min = 1,
.channels_max = 1,
- .rates = SNDRV_PCM_RATE_8000,
+ .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
.stream_name = "Capture",
.channels_min = 1,
.channels_max = 1,
- .rates = SNDRV_PCM_RATE_8000,
+ .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
};
--
2.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bt-sco: support wide band speech
2014-11-24 12:29 [PATCH] ASoC: bt-sco: support wide band speech Barry Song
@ 2014-11-24 12:45 ` Lars-Peter Clausen
2014-11-24 12:58 ` Barry Song
0 siblings, 1 reply; 4+ messages in thread
From: Lars-Peter Clausen @ 2014-11-24 12:45 UTC (permalink / raw)
To: Barry Song, broonie, lgirdwood
Cc: alsa-devel, Yibo Cai, workgroup.linux, Barry Song
On 11/24/2014 01:29 PM, Barry Song wrote:
> From: Yibo Cai <yibo.cai@csr.com>
>
> HFP1.6 requires support for wide band speech(16KHz) over Bluetooth.
>
> Signed-off-by: Yibo Cai <yibo.cai@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
> sound/soc/codecs/bt-sco.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/bt-sco.c b/sound/soc/codecs/bt-sco.c
> index c4cf069..fc0664b 100644
> --- a/sound/soc/codecs/bt-sco.c
> +++ b/sound/soc/codecs/bt-sco.c
> @@ -31,14 +31,14 @@ static struct snd_soc_dai_driver bt_sco_dai = {
> .stream_name = "Playback",
> .channels_min = 1,
> .channels_max = 1,
> - .rates = SNDRV_PCM_RATE_8000,
> + .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
This will break those bluetooth modules that only work with 8k.
- Lars
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bt-sco: support wide band speech
2014-11-24 12:45 ` Lars-Peter Clausen
@ 2014-11-24 12:58 ` Barry Song
2014-11-24 13:36 ` Lars-Peter Clausen
0 siblings, 1 reply; 4+ messages in thread
From: Barry Song @ 2014-11-24 12:58 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: alsa-devel@alsa-project.org, Yibo Cai, Liam Girdwood,
DL-SHA-WorkGroupLinux, Mark Brown, Barry Song
2014-11-24 20:45 GMT+08:00 Lars-Peter Clausen <lars@metafoo.de>:
> On 11/24/2014 01:29 PM, Barry Song wrote:
>>
>> From: Yibo Cai <yibo.cai@csr.com>
>>
>> HFP1.6 requires support for wide band speech(16KHz) over Bluetooth.
>>
>> Signed-off-by: Yibo Cai <yibo.cai@csr.com>
>> Signed-off-by: Barry Song <Baohua.Song@csr.com>
>> ---
>> sound/soc/codecs/bt-sco.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/codecs/bt-sco.c b/sound/soc/codecs/bt-sco.c
>> index c4cf069..fc0664b 100644
>> --- a/sound/soc/codecs/bt-sco.c
>> +++ b/sound/soc/codecs/bt-sco.c
>> @@ -31,14 +31,14 @@ static struct snd_soc_dai_driver bt_sco_dai = {
>> .stream_name = "Playback",
>> .channels_min = 1,
>> .channels_max = 1,
>> - .rates = SNDRV_PCM_RATE_8000,
>> + .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
>
>
> This will break those bluetooth modules that only work with 8k.
how do you think if we use device-tree "compatible" to differentiate
these two kinds of BT modules?
for non-DT platform, platform_device_id?
>
> - Lars
-barry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bt-sco: support wide band speech
2014-11-24 12:58 ` Barry Song
@ 2014-11-24 13:36 ` Lars-Peter Clausen
0 siblings, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2014-11-24 13:36 UTC (permalink / raw)
To: Barry Song
Cc: alsa-devel@alsa-project.org, Yibo Cai, Liam Girdwood,
DL-SHA-WorkGroupLinux, Mark Brown, Barry Song
On 11/24/2014 01:58 PM, Barry Song wrote:
> 2014-11-24 20:45 GMT+08:00 Lars-Peter Clausen <lars@metafoo.de>:
>> On 11/24/2014 01:29 PM, Barry Song wrote:
>>>
>>> From: Yibo Cai <yibo.cai@csr.com>
>>>
>>> HFP1.6 requires support for wide band speech(16KHz) over Bluetooth.
>>>
>>> Signed-off-by: Yibo Cai <yibo.cai@csr.com>
>>> Signed-off-by: Barry Song <Baohua.Song@csr.com>
>>> ---
>>> sound/soc/codecs/bt-sco.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/sound/soc/codecs/bt-sco.c b/sound/soc/codecs/bt-sco.c
>>> index c4cf069..fc0664b 100644
>>> --- a/sound/soc/codecs/bt-sco.c
>>> +++ b/sound/soc/codecs/bt-sco.c
>>> @@ -31,14 +31,14 @@ static struct snd_soc_dai_driver bt_sco_dai = {
>>> .stream_name = "Playback",
>>> .channels_min = 1,
>>> .channels_max = 1,
>>> - .rates = SNDRV_PCM_RATE_8000,
>>> + .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000,
>>
>>
>> This will break those bluetooth modules that only work with 8k.
>
> how do you think if we use device-tree "compatible" to differentiate
> these two kinds of BT modules?
> for non-DT platform, platform_device_id?
Yes, I think that's what we need to do.
- Lars
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-24 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 12:29 [PATCH] ASoC: bt-sco: support wide band speech Barry Song
2014-11-24 12:45 ` Lars-Peter Clausen
2014-11-24 12:58 ` Barry Song
2014-11-24 13:36 ` Lars-Peter Clausen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.