All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check"
Date: Tue, 25 Nov 2014 10:06:34 +0100	[thread overview]
Message-ID: <5474469A.1050009@redhat.com> (raw)
In-Reply-To: <87zjbfrb32.fsf@blackfin.pond.sub.org>

On 2014-11-25 at 08:30, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Fam Zheng <famz@redhat.com> writes:
>>
>>> qemu-iotests contains useful tests that have a nice coverage of block layer
>>> code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make
>>> check" is good for developers' self-testing.
>>>
>>> With the first patch, this set takes a half minute on my laptop. If
>>> "-j" option
>>> is used, it only takes a few more seconds than what we have now.
>> Different data point: elderly machine, spinning rust, /tmp is tmpfs, no
>> -j: elapsed time increases from ~2 to ~3 minutes.
> I'm very much in favour of actually running the tests we have.
>
> Running all the block tests for all the formats would be too slow, and
> that's why you run just the "quick" group, and only for qcow2.  Quick
> enough?
>
> Any ideas on speeding it up further?  Trimming image sizes, perhaps?
>
> What are the slowest tests in the quick group?  Why are they slow?  How
> are tests selected for the quick group anyway?

Last time I updated the associations it was "Whatever runs in under five 
seconds on my HDD".

Max

      reply	other threads:[~2014-11-25  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28  6:45 [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check" Fam Zheng
2014-10-28  6:45 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block Fam Zheng
2014-11-25  7:22   ` Markus Armbruster
2014-11-25  9:12   ` Max Reitz
2014-11-25  9:21     ` Kevin Wolf
2014-11-25  9:21       ` Max Reitz
2014-11-25  9:30         ` Kevin Wolf
2014-11-25  9:31           ` Max Reitz
2014-11-25  9:44             ` Fam Zheng
2014-11-25  9:58               ` Kevin Wolf
2014-10-28  6:45 ` [Qemu-devel] [PATCH 2/2] tests/Makefile: Add check-block to make check Fam Zheng
2014-11-25  9:17   ` Max Reitz
2014-10-28  8:28 ` [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check" Markus Armbruster
2014-11-25  7:30   ` Markus Armbruster
2014-11-25  9:06     ` Max Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5474469A.1050009@redhat.com \
    --to=mreitz@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.