From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block
Date: Tue, 25 Nov 2014 10:12:13 +0100 [thread overview]
Message-ID: <547447ED.9030708@redhat.com> (raw)
In-Reply-To: <1414478736-30064-2-git-send-email-famz@redhat.com>
On 2014-10-28 at 07:45, Fam Zheng wrote:
> Using /tmp (usually mounted as tmpfs) and cache=writeback, the quick
> group can be quicker.
>
> On my laptop (Lenovo T430s with Fedora 20), this reduces the time from
> 50s to 30s.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests-quick.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests-quick.sh b/tests/qemu-iotests-quick.sh
> index 12af731..0b54dbf 100755
> --- a/tests/qemu-iotests-quick.sh
> +++ b/tests/qemu-iotests-quick.sh
> @@ -3,6 +3,6 @@
> cd tests/qemu-iotests
>
> ret=0
> -./check -T -qcow2 -g quick || ret=1
> +TEST_DIR=/tmp/qemu-iotests-quick-$$ ./check -T -qcow2 -g quick -c writeback || ret=1
There are (at least) two tests which don't work with -c writeback (026
and 039), one of them is in the quick group (039). Why not use -c
writethrough? It doesn't make any difference on tmpfs anyway (we can't
omit it because that will break 091).
And thank you, I didn't know about TEST_DIR. I always built the full
qemu in /tmp. *g*
Max
> exit $ret
next prev parent reply other threads:[~2014-11-25 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 6:45 [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check" Fam Zheng
2014-10-28 6:45 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block Fam Zheng
2014-11-25 7:22 ` Markus Armbruster
2014-11-25 9:12 ` Max Reitz [this message]
2014-11-25 9:21 ` Kevin Wolf
2014-11-25 9:21 ` Max Reitz
2014-11-25 9:30 ` Kevin Wolf
2014-11-25 9:31 ` Max Reitz
2014-11-25 9:44 ` Fam Zheng
2014-11-25 9:58 ` Kevin Wolf
2014-10-28 6:45 ` [Qemu-devel] [PATCH 2/2] tests/Makefile: Add check-block to make check Fam Zheng
2014-11-25 9:17 ` Max Reitz
2014-10-28 8:28 ` [Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check" Markus Armbruster
2014-11-25 7:30 ` Markus Armbruster
2014-11-25 9:06 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547447ED.9030708@redhat.com \
--to=mreitz@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.