* [PATCH resend] serial: of-serial: fetch line number from DT
@ 2014-11-25 8:26 ` Lucas Stach
0 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2014-11-25 8:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Olof Johansson,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
The general agreed way to specify a fixed line number
for a serial console is to provide a "serial" alias
in the devicetree. Start parsing this property in
of_serial.
Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Acked-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---
As 3.16-rc6 landed the fix to avoid the regression that this patch
was causing on Tegra it should be safe to reapply it.
---
drivers/tty/serial/of_serial.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 8bc2563..920a831 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -101,6 +101,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
if (of_property_read_u32(np, "fifo-size", &prop) == 0)
port->fifosize = prop;
+ /* Check for a fixed line number */
+ if ((ret = of_alias_get_id(np, "serial")) >= 0)
+ port->line = ret;
+
port->irq = irq_of_parse_and_map(np, 0);
port->iotype = UPIO_MEM;
if (of_property_read_u32(np, "reg-io-width", &prop) == 0) {
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH resend] serial: of-serial: fetch line number from DT
@ 2014-11-25 8:26 ` Lucas Stach
0 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2014-11-25 8:26 UTC (permalink / raw)
To: linux-arm-kernel
The general agreed way to specify a fixed line number
for a serial console is to provide a "serial" alias
in the devicetree. Start parsing this property in
of_serial.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
Acked-by: Olof Johansson <olof@lixom.net>
---
As 3.16-rc6 landed the fix to avoid the regression that this patch
was causing on Tegra it should be safe to reapply it.
---
drivers/tty/serial/of_serial.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index 8bc2563..920a831 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -101,6 +101,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
if (of_property_read_u32(np, "fifo-size", &prop) == 0)
port->fifosize = prop;
+ /* Check for a fixed line number */
+ if ((ret = of_alias_get_id(np, "serial")) >= 0)
+ port->line = ret;
+
port->irq = irq_of_parse_and_map(np, 0);
port->iotype = UPIO_MEM;
if (of_property_read_u32(np, "reg-io-width", &prop) == 0) {
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1416904016-5567-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>]
* Re: [PATCH resend] serial: of-serial: fetch line number from DT
2014-11-25 8:26 ` Lucas Stach
@ 2014-11-25 14:24 ` Sergei Shtylyov
-1 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-11-25 14:24 UTC (permalink / raw)
To: Lucas Stach, Greg Kroah-Hartman
Cc: Olof Johansson,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren
Hello.
On 11/25/2014 11:26 AM, Lucas Stach wrote:
> The general agreed way to specify a fixed line number
> for a serial console is to provide a "serial" alias
> in the devicetree. Start parsing this property in
> of_serial.
> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
> Acked-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> ---
> As 3.16-rc6 landed the fix to avoid the regression that this patch
> was causing on Tegra it should be safe to reapply it.
> ---
> drivers/tty/serial/of_serial.c | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 8bc2563..920a831 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -101,6 +101,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
> if (of_property_read_u32(np, "fifo-size", &prop) == 0)
> port->fifosize = prop;
>
> + /* Check for a fixed line number */
> + if ((ret = of_alias_get_id(np, "serial")) >= 0)
Don't use assignment in the *if* statement. If you would have ran your
patch thru scripts/checkpatch.pl, it would have complained about that.
> + port->line = ret;
> +
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH resend] serial: of-serial: fetch line number from DT
@ 2014-11-25 14:24 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-11-25 14:24 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 11/25/2014 11:26 AM, Lucas Stach wrote:
> The general agreed way to specify a fixed line number
> for a serial console is to provide a "serial" alias
> in the devicetree. Start parsing this property in
> of_serial.
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> Acked-by: Olof Johansson <olof@lixom.net>
> ---
> As 3.16-rc6 landed the fix to avoid the regression that this patch
> was causing on Tegra it should be safe to reapply it.
> ---
> drivers/tty/serial/of_serial.c | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 8bc2563..920a831 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -101,6 +101,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
> if (of_property_read_u32(np, "fifo-size", &prop) == 0)
> port->fifosize = prop;
>
> + /* Check for a fixed line number */
> + if ((ret = of_alias_get_id(np, "serial")) >= 0)
Don't use assignment in the *if* statement. If you would have ran your
patch thru scripts/checkpatch.pl, it would have complained about that.
> + port->line = ret;
> +
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-25 14:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 8:26 [PATCH resend] serial: of-serial: fetch line number from DT Lucas Stach
2014-11-25 8:26 ` Lucas Stach
[not found] ` <1416904016-5567-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2014-11-25 14:24 ` Sergei Shtylyov
2014-11-25 14:24 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.