[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Chris Zhong]

The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set
to 1.4v. I've tested these patches on rk3288 evb board.


Chris Zhong (2):
  ARM: dts: rockchip: change the max voltage of cpu to 1.4v
  ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz

 arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
 arch/arm/boot/dts/rk3288.dtsi          | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
1.9.1

[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Chris Zhong]

The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set
to 1.4v. I've tested these patches on rk3288 evb board.


Chris Zhong (2):
  ARM: dts: rockchip: change the max voltage of cpu to 1.4v
  ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz

 arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
 arch/arm/boot/dts/rk3288.dtsi          | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
1.9.1

[PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v

[Chris Zhong]

If the cpu frequencies up to 1.8Ghz, we need set the vdd_cpu to 1.4v.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>
---

 arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
index d8c775e6..d4f74dd 100644
--- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
+++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
@@ -48,7 +48,7 @@
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
+				regulator-max-microvolt = <1400000>;
 				regulator-name = "vdd_arm";
 			};
 
-- 
1.9.1

[PATCH 1/2] ARM: dts: rockchip: change the max voltage of cpu to 1.4v

[Chris Zhong]

If the cpu frequencies up to 1.8Ghz, we need set the vdd_cpu to 1.4v.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>
---

 arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
index d8c775e6..d4f74dd 100644
--- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
+++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
@@ -48,7 +48,7 @@
 				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
+				regulator-max-microvolt = <1400000>;
 				regulator-name = "vdd_arm";
 			};
 
-- 
1.9.1

[PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz

[Chris Zhong]

The maximum cpu frequency of rk3288 can up to 1.8Ghz,
and it need to set the vdd_cpu to 1.4v correspondingly.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

 arch/arm/boot/dts/rk3288.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 0f50d5d..4f77a05 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -56,8 +56,10 @@
 			resets = <&cru SRST_CORE0>;
 			operating-points = <
 				/* KHz    uV */
-				1608000 1350000
-				1512000 1300000
+				1800000 1400000
+				1704000 1350000
+				1608000 1300000
+				1512000 1250000
 				1416000 1200000
 				1200000 1100000
 				1008000 1050000
-- 
1.9.1

[PATCH 2/2] ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz

[Chris Zhong]

The maximum cpu frequency of rk3288 can up to 1.8Ghz,
and it need to set the vdd_cpu to 1.4v correspondingly.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

 arch/arm/boot/dts/rk3288.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 0f50d5d..4f77a05 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -56,8 +56,10 @@
 			resets = <&cru SRST_CORE0>;
 			operating-points = <
 				/* KHz    uV */
-				1608000 1350000
-				1512000 1300000
+				1800000 1400000
+				1704000 1350000
+				1608000 1300000
+				1512000 1250000
 				1416000 1200000
 				1200000 1100000
 				1008000 1050000
-- 
1.9.1

[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Kever Yang]

Hi Chris,

On 11/25/2014 05:37 PM, Chris Zhong wrote:
> The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set
> to 1.4v. I've tested these patches on rk3288 evb board.
I'm not sure why you need this patch, I think we have a discuss
for the cpu operating point before.
In this case:
1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
a separate opp table in rk3288-evb-rk808.dts;
2. 1.4V may beyond the supported voltage range too much,
     and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?

- Kever
>
>
> Chris Zhong (2):
>    ARM: dts: rockchip: change the max voltage of cpu to 1.4v
>    ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz
>
>   arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
>   arch/arm/boot/dts/rk3288.dtsi          | 6 ++++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
>

Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Kever Yang]

Hi Chris,

On 11/25/2014 05:37 PM, Chris Zhong wrote:
> The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need set
> to 1.4v. I've tested these patches on rk3288 evb board.
I'm not sure why you need this patch, I think we have a discuss
for the cpu operating point before.
In this case:
1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
a separate opp table in rk3288-evb-rk808.dts;
2. 1.4V may beyond the supported voltage range too much,
     and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?

- Kever
>
>
> Chris Zhong (2):
>    ARM: dts: rockchip: change the max voltage of cpu to 1.4v
>    ARM: dts: rk3288: change the max clk of cpu to 1.8Ghz
>
>   arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +-
>   arch/arm/boot/dts/rk3288.dtsi          | 6 ++++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
>

[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Heiko Stübner]

Hi Chris, Kever,

Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang:
> On 11/25/2014 05:37 PM, Chris Zhong wrote:
> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need
> > set to 1.4v. I've tested these patches on rk3288 evb board.
> 
> I'm not sure why you need this patch, I think we have a discuss
> for the cpu operating point before.
> In this case:
> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
> a separate opp table in rk3288-evb-rk808.dts;
> 2. 1.4V may beyond the supported voltage range too much,
>      and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?

That is how I remember it as well ... the default opp table is supposed to 
contain only the safest of values, while individual boards can then increase 
those in conjunction with their thermal design.

As the evb itself does only have the naked soc without any heat-sink or 
similar, I'm not even sure if these additional frequencies should be enabled 
there at all.


Heiko

Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Heiko Stübner]

Hi Chris, Kever,

Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang:
> On 11/25/2014 05:37 PM, Chris Zhong wrote:
> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need
> > set to 1.4v. I've tested these patches on rk3288 evb board.
> 
> I'm not sure why you need this patch, I think we have a discuss
> for the cpu operating point before.
> In this case:
> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
> a separate opp table in rk3288-evb-rk808.dts;
> 2. 1.4V may beyond the supported voltage range too much,
>      and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?

That is how I remember it as well ... the default opp table is supposed to 
contain only the safest of values, while individual boards can then increase 
those in conjunction with their thermal design.

As the evb itself does only have the naked soc without any heat-sink or 
similar, I'm not even sure if these additional frequencies should be enabled 
there at all.


Heiko

[PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Doug Anderson]

Hi,

On Tue, Nov 25, 2014 at 8:23 AM, Heiko St?bner <heiko@sntech.de> wrote:
> Hi Chris, Kever,
>
> Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang:
>> On 11/25/2014 05:37 PM, Chris Zhong wrote:
>> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need
>> > set to 1.4v. I've tested these patches on rk3288 evb board.
>>
>> I'm not sure why you need this patch, I think we have a discuss
>> for the cpu operating point before.
>> In this case:
>> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
>> a separate opp table in rk3288-evb-rk808.dts;
>> 2. 1.4V may beyond the supported voltage range too much,
>>      and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
>> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?
>
> That is how I remember it as well ... the default opp table is supposed to
> contain only the safest of values, while individual boards can then increase
> those in conjunction with their thermal design.
>
> As the evb itself does only have the naked soc without any heat-sink or
> similar, I'm not even sure if these additional frequencies should be enabled
> there at all.

I'm not sure that the story from Rockchip is all straight about all of
this stuff, but I will say that:

* The latest datasheet I have (1.3) shows the maximum CPU frequency as
1.8GHz.  It shows the maximum CPU voltage as TBD.  That indicates that
rk3288.dtsi ought to list 1.8GHz values.

* The 1.4V number comes from folks at Rockchip.  Please check with
Jianqun Xu and Eddie Cai to check.  If 1.4V is not safe we certainly
shouldn't use it.  I believe they have seen boards where 1.8GHz needed
1.4V to be reliable.  Either the SoCs on these boards are out of spec
or 1.4V is needed.

* If you're worried about heat we should make sure that all the
thermal changes are in.  That will still let you run at 1.8GHz
temporarily.  You can put a heatsync on and run faster.

* These numbers are still conservative as far as I understand.  For
instance on rk3288-pinky 1.8GHz is a full .1V lower at 1.3V.

* If EVB was shipped with pre-production chips that can't support high
voltages or frequencies, it should override the table to remove the
high frequencies.  However, if the table that Chris submitted is
generally correct (and conservative) for rk3288 devices that are
expected in real products then it seems like it ought to land in
rk3288.dtsi.


-Doug

Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Doug Anderson]

Hi,

On Tue, Nov 25, 2014 at 8:23 AM, Heiko Stübner <heiko@sntech.de> wrote:
> Hi Chris, Kever,
>
> Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang:
>> On 11/25/2014 05:37 PM, Chris Zhong wrote:
>> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need
>> > set to 1.4v. I've tested these patches on rk3288 evb board.
>>
>> I'm not sure why you need this patch, I think we have a discuss
>> for the cpu operating point before.
>> In this case:
>> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
>> a separate opp table in rk3288-evb-rk808.dts;
>> 2. 1.4V may beyond the supported voltage range too much,
>>      and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
>> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?
>
> That is how I remember it as well ... the default opp table is supposed to
> contain only the safest of values, while individual boards can then increase
> those in conjunction with their thermal design.
>
> As the evb itself does only have the naked soc without any heat-sink or
> similar, I'm not even sure if these additional frequencies should be enabled
> there at all.

I'm not sure that the story from Rockchip is all straight about all of
this stuff, but I will say that:

* The latest datasheet I have (1.3) shows the maximum CPU frequency as
1.8GHz.  It shows the maximum CPU voltage as TBD.  That indicates that
rk3288.dtsi ought to list 1.8GHz values.

* The 1.4V number comes from folks at Rockchip.  Please check with
Jianqun Xu and Eddie Cai to check.  If 1.4V is not safe we certainly
shouldn't use it.  I believe they have seen boards where 1.8GHz needed
1.4V to be reliable.  Either the SoCs on these boards are out of spec
or 1.4V is needed.

* If you're worried about heat we should make sure that all the
thermal changes are in.  That will still let you run at 1.8GHz
temporarily.  You can put a heatsync on and run faster.

* These numbers are still conservative as far as I understand.  For
instance on rk3288-pinky 1.8GHz is a full .1V lower at 1.3V.

* If EVB was shipped with pre-production chips that can't support high
voltages or frequencies, it should override the table to remove the
high frequencies.  However, if the table that Chris submitted is
generally correct (and conservative) for rk3288 devices that are
expected in real products then it seems like it ought to land in
rk3288.dtsi.


-Doug

Re: [PATCH 0/2] Increase the maximum cpu frequency of rk3288

[Doug Anderson]

Hi,

On Tue, Nov 25, 2014 at 8:23 AM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
> Hi Chris, Kever,
>
> Am Mittwoch, 26. November 2014, 00:13:40 schrieb Kever Yang:
>> On 11/25/2014 05:37 PM, Chris Zhong wrote:
>> > The maximum cpu frequency of rk3288 can up to 1.8Ghz, but the vdd_cpu need
>> > set to 1.4v. I've tested these patches on rk3288 evb board.
>>
>> I'm not sure why you need this patch, I think we have a discuss
>> for the cpu operating point before.
>> In this case:
>> 1. rk3288.dtsi is for all the rk3288 Soc based system, you may need
>> a separate opp table in rk3288-evb-rk808.dts;
>> 2. 1.4V may beyond the supported voltage range too much,
>>      and it's not a good idea to add it to rk3288.dtsi as a safe voltage.
>> 3. Do you have a stress/heavy load test on evb with 1.4v at 1.8GHz?
>
> That is how I remember it as well ... the default opp table is supposed to
> contain only the safest of values, while individual boards can then increase
> those in conjunction with their thermal design.
>
> As the evb itself does only have the naked soc without any heat-sink or
> similar, I'm not even sure if these additional frequencies should be enabled
> there at all.

I'm not sure that the story from Rockchip is all straight about all of
this stuff, but I will say that:

* The latest datasheet I have (1.3) shows the maximum CPU frequency as
1.8GHz.  It shows the maximum CPU voltage as TBD.  That indicates that
rk3288.dtsi ought to list 1.8GHz values.

* The 1.4V number comes from folks at Rockchip.  Please check with
Jianqun Xu and Eddie Cai to check.  If 1.4V is not safe we certainly
shouldn't use it.  I believe they have seen boards where 1.8GHz needed
1.4V to be reliable.  Either the SoCs on these boards are out of spec
or 1.4V is needed.

* If you're worried about heat we should make sure that all the
thermal changes are in.  That will still let you run at 1.8GHz
temporarily.  You can put a heatsync on and run faster.

* These numbers are still conservative as far as I understand.  For
instance on rk3288-pinky 1.8GHz is a full .1V lower at 1.3V.

* If EVB was shipped with pre-production chips that can't support high
voltages or frequencies, it should override the table to remove the
high frequencies.  However, if the table that Chris submitted is
generally correct (and conservative) for rk3288 devices that are
expected in real products then it seems like it ought to land in
rk3288.dtsi.


-Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html