All of lore.kernel.org
 help / color / mirror / Atom feed
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] KVM: arm: guest debug, define API headers
Date: Tue, 25 Nov 2014 18:22:32 +0100	[thread overview]
Message-ID: <5474BAD8.7010307@redhat.com> (raw)
In-Reply-To: <CAFEAcA-ikeiciAh4RXpKQQ_pY9FRePxR7nEBUEjcaaxB0ZAAtA@mail.gmail.com>



On 25/11/2014 18:13, Peter Maydell wrote:
> On 25 November 2014 at 17:05, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> > So there is no register that says "this breakpoint has triggered" or
>> > "this watchpoint has triggered"?
> Nope. You take a debug exception; the syndrome register tells
> you if it was a bp or a wp, and if it was a wp the fault address
> register tells you the address being accessed (if it was a bp
> you know the program counter, obviously). The debugger is expected
> to be able to figure it out from there, if it cares.

That's already good enough---do the KVM_DEBUG_EXIT_* constants match the
syndrome register, or if not why?

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	kvm-devel <kvm@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"Christoffer Dall" <christoffer.dall@linaro.org>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	"Alexander Graf" <agraf@suse.de>,
	"J. Kiszka" <jan.kiszka@siemens.com>,
	"David Hildenbrand" <dahi@linux.vnet.ibm.com>,
	"Bharat Bhushan" <r65777@freescale.com>,
	bp@suse.de, "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] KVM: arm: guest debug, define API headers
Date: Tue, 25 Nov 2014 18:22:32 +0100	[thread overview]
Message-ID: <5474BAD8.7010307@redhat.com> (raw)
In-Reply-To: <CAFEAcA-ikeiciAh4RXpKQQ_pY9FRePxR7nEBUEjcaaxB0ZAAtA@mail.gmail.com>



On 25/11/2014 18:13, Peter Maydell wrote:
> On 25 November 2014 at 17:05, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> > So there is no register that says "this breakpoint has triggered" or
>> > "this watchpoint has triggered"?
> Nope. You take a debug exception; the syndrome register tells
> you if it was a bp or a wp, and if it was a wp the fault address
> register tells you the address being accessed (if it was a bp
> you know the program counter, obviously). The debugger is expected
> to be able to figure it out from there, if it cares.

That's already good enough---do the KVM_DEBUG_EXIT_* constants match the
syndrome register, or if not why?

Paolo

  reply	other threads:[~2014-11-25 17:22 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 16:09 [PATCH 0/7] KVM Guest Debug support for arm64 Alex Bennée
2014-11-25 16:09 ` Alex Bennée
2014-11-25 16:09 ` [PATCH 1/7] KVM: add commentary for kvm_debug_exit_arch struct Alex Bennée
2014-11-25 16:09   ` Alex Bennée
2014-11-25 16:09   ` Alex Bennée
     [not found]   ` <1416931805-23223-2-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-26 14:20     ` Andrew Jones
2014-11-26 14:20       ` Andrew Jones
2014-11-26 14:20       ` Andrew Jones
2014-11-25 16:10 ` [PATCH 2/7] KVM: arm: guest debug, define API headers Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-25 16:19   ` Peter Maydell
2014-11-25 16:19     ` Peter Maydell
2014-11-26 15:04     ` Alex Bennée
2014-11-26 15:04       ` Alex Bennée
2014-11-29 16:20       ` Christoffer Dall
2014-11-29 16:20         ` Christoffer Dall
2014-12-01 11:30         ` Alex Bennée
2014-12-01 11:30           ` Alex Bennée
2014-11-25 17:05   ` Paolo Bonzini
2014-11-25 17:05     ` Paolo Bonzini
2014-11-25 17:13     ` Peter Maydell
2014-11-25 17:13       ` Peter Maydell
2014-11-25 17:22       ` Paolo Bonzini [this message]
2014-11-25 17:22         ` Paolo Bonzini
2014-11-26 13:13         ` Alex Bennée
2014-11-26 13:13           ` Alex Bennée
2014-11-26 13:14           ` Paolo Bonzini
2014-11-26 13:14             ` Paolo Bonzini
2014-11-26 14:31   ` Andrew Jones
2014-11-26 14:31     ` Andrew Jones
2014-11-26 14:58     ` Alex Bennée
2014-11-26 14:58       ` Alex Bennée
2014-11-26 16:46       ` Paolo Bonzini
2014-11-26 16:46         ` Paolo Bonzini
2014-11-26 17:47         ` Andrew Jones
2014-11-26 17:47           ` Andrew Jones
2014-11-29 16:20   ` Christoffer Dall
2014-11-29 16:20     ` Christoffer Dall
2014-11-25 16:10 ` [PATCH 3/7] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-26 14:38   ` Andrew Jones
2014-11-26 14:38     ` Andrew Jones
2014-11-26 15:03     ` Alex Bennée
2014-11-26 15:03       ` Alex Bennée
2014-11-26 16:46       ` Paolo Bonzini
2014-11-26 16:46         ` Paolo Bonzini
2014-11-29 16:21   ` Christoffer Dall
2014-11-29 16:21     ` Christoffer Dall
2014-11-25 16:10 ` [PATCH 4/7] KVM: arm64: guest debug, add SW break point support Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-26 16:07   ` Andrew Jones
2014-11-26 16:07     ` Andrew Jones
2014-11-26 17:14     ` Peter Maydell
2014-11-26 17:14       ` Peter Maydell
2014-11-29 16:21     ` Christoffer Dall
2014-11-29 16:21       ` Christoffer Dall
2014-11-29 16:21   ` Christoffer Dall
2014-11-29 16:21     ` Christoffer Dall
2014-12-01 11:33     ` Alex Bennée
2014-12-01 11:33       ` Alex Bennée
2014-11-25 16:10 ` [PATCH 5/7] KVM: arm64: guest debug, add support for single-step Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-25 16:10   ` Alex Bennée
     [not found]   ` <1416931805-23223-6-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-26 16:40     ` Andrew Jones
2014-11-26 16:40       ` Andrew Jones
2014-11-26 16:40       ` Andrew Jones
     [not found]       ` <20141126164057.GE3245-EoAxxbxdFnFvD/m4c++uL6fLeoKvNuZc@public.gmane.org>
2014-11-26 18:00         ` Alex Bennée
2014-11-26 18:00           ` Alex Bennée
2014-11-26 18:00           ` Alex Bennée
2014-11-26 18:00           ` Alex Bennée
2014-11-26 19:27     ` Peter Maydell
2014-11-26 19:27       ` Peter Maydell
2014-11-26 19:27       ` Peter Maydell
     [not found]       ` <CAFEAcA-cjM9yUXi6tc79UP0fBKAagtFKQgV3iAjz5DWr9yxZUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-30 10:10         ` Christoffer Dall
2014-11-30 10:10           ` Christoffer Dall
2014-11-30 10:10           ` Christoffer Dall
2014-11-30 10:20           ` Peter Maydell
2014-11-30 10:20             ` Peter Maydell
2014-11-30 10:20             ` Peter Maydell
2014-11-30 10:21   ` Christoffer Dall
2014-11-30 10:21     ` Christoffer Dall
2014-12-01 11:50     ` Alex Bennée
2014-12-01 11:50       ` Alex Bennée
2014-12-01 11:50       ` Alex Bennée
2014-12-01 11:50       ` Alex Bennée
     [not found]       ` <87r3wj1te1.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-12-02 13:17         ` Christoffer Dall
2014-12-02 13:17           ` Christoffer Dall
2014-12-02 13:17           ` Christoffer Dall
2014-11-25 16:10 ` [PATCH 6/7] KVM: arm64: re-factor hyp.S debug register code Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-26 16:49   ` Andrew Jones
2014-11-26 16:49     ` Andrew Jones
2014-11-30 10:25   ` Christoffer Dall
2014-11-30 10:25     ` Christoffer Dall
2014-12-01 11:52     ` Alex Bennée
2014-12-01 11:52       ` Alex Bennée
2014-12-02 13:23       ` Christoffer Dall
2014-12-02 13:23         ` Christoffer Dall
2014-11-25 16:10 ` [PATCH 7/7] KVM: arm64: guest debug, HW assisted debug support Alex Bennée
2014-11-25 16:10   ` Alex Bennée
2014-11-25 16:10   ` Alex Bennée
     [not found]   ` <1416931805-23223-8-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-26 17:34     ` Andrew Jones
2014-11-26 17:34       ` Andrew Jones
2014-11-26 17:34       ` Andrew Jones
2014-11-30 10:34   ` Christoffer Dall
2014-11-30 10:34     ` Christoffer Dall
2014-12-01 11:54     ` Alex Bennée
2014-12-01 11:54       ` Alex Bennée
2014-12-01 11:54       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5474BAD8.7010307@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.