From: Khalid Aziz <khalid.aziz@oracle.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
corbet@lwn.net, mingo@redhat.com, hpa@zytor.com,
peterz@infradead.org, riel@redhat.com, akpm@linux-foundation.org,
rientjes@google.com, ak@linux.intel.com, mgorman@suse.de,
raistlin@linux.it, kirill.shutemov@linux.intel.com,
atomlin@redhat.com, avagin@openvz.org, gorcunov@openvz.org,
serge.hallyn@canonical.com, athorlton@sgi.com, oleg@redhat.com,
vdavydov@parallels.com, daeseok.youn@gmail.com,
keescook@chromium.org, yangds.fnst@cn.fujitsu.com,
sbauer@eng.utah.edu, vishnu.ps@samsung.com, axboe@fb.com,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice
Date: Tue, 25 Nov 2014 12:23:10 -0700 [thread overview]
Message-ID: <5474D71E.8070603@oracle.com> (raw)
In-Reply-To: <1416940024.26209.2.camel@linux-t7sj.site>
On 11/25/2014 11:27 AM, Davidlohr Bueso wrote:
> On Tue, 2014-11-25 at 07:45 -0700, Khalid Aziz wrote:
>> This solution has been used by both database and java on other OSs and
>> has shown performance improvement. Andrew had asked for performance
>> numbers on Linux with this patch last time I sent this out and it took
>> me a while to get performance folks to run a full TPC-C workload. They
>> did see a 3% improvement in tpcc as I noted in commit log and that is a
>> significant improvement.
>
> 3% for such a change seems pretty worthless... I would have expected
> this having to impact performance much more.
>
Performance impact will depend upon how big a bottleneck the spinlock
was creating and how severe the resulting convoy problem was. Database
guys try to squeeze every bit out of the system and 3% is considered to
be very good gain. 10% gain would have been nicer :)
--
Khalid
next prev parent reply other threads:[~2014-11-25 19:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 20:56 [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice (was: Pre-emption control for userspace) Khalid Aziz
2014-11-24 22:43 ` Andi Kleen
[not found] ` <20141124224302.GL10824-KWJ+5VKanrL29G5dvP0v1laTQe2KTcn/@public.gmane.org>
2014-11-24 23:20 ` Khalid Aziz
2014-11-24 23:20 ` Khalid Aziz
2014-11-24 23:35 ` Thomas Gleixner
2014-11-25 2:12 ` Davidlohr Bueso
2014-11-25 2:12 ` Davidlohr Bueso
2014-11-25 4:20 ` Mike Galbraith
[not found] ` <1416889208.4335.127.camel-sZ+7a5bGyC/1wTEvPJ5Q0F6hYfS7NtTn@public.gmane.org>
2014-11-25 14:50 ` [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice Khalid Aziz
2014-11-25 14:50 ` Khalid Aziz
2014-11-25 17:46 ` Mike Galbraith
[not found] ` <1416937564.3512.15.camel-sZ+7a5bGyC/1wTEvPJ5Q0F6hYfS7NtTn@public.gmane.org>
2014-11-25 19:38 ` Khalid Aziz
2014-11-25 19:38 ` Khalid Aziz
2014-11-25 14:45 ` Khalid Aziz
[not found] ` <54749617.5030309-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-11-25 18:27 ` Davidlohr Bueso
2014-11-25 18:27 ` Davidlohr Bueso
2014-11-25 19:23 ` Khalid Aziz [this message]
[not found] ` <5474D71E.8070603-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-11-25 19:40 ` Davidlohr Bueso
2014-11-25 19:40 ` Davidlohr Bueso
2014-11-25 2:03 ` [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice (was: Pre-emption control for userspace) Rik van Riel
2014-11-25 6:30 ` Davidlohr Bueso
2014-11-25 13:38 ` Rik van Riel
2014-11-25 14:52 ` [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice Khalid Aziz
2014-11-25 15:25 ` Rik van Riel
[not found] ` <54749F77.50905-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-25 17:22 ` Khalid Aziz
2014-11-25 17:22 ` Khalid Aziz
2014-11-25 17:45 ` Rik van Riel
[not found] ` <1416862595-24513-1-git-send-email-khalid.aziz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-11-25 10:12 ` [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice (was: Pre-emption control for userspace) Srikar Dronamraju
2014-11-25 10:12 ` Srikar Dronamraju
2014-11-25 14:56 ` [PATCH v3] sched/fair: Add advisory flag for borrowing a timeslice Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474D71E.8070603@oracle.com \
--to=khalid.aziz@oracle.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=atomlin@redhat.com \
--cc=avagin@openvz.org \
--cc=axboe@fb.com \
--cc=corbet@lwn.net \
--cc=daeseok.youn@gmail.com \
--cc=dave@stgolabs.net \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sbauer@eng.utah.edu \
--cc=serge.hallyn@canonical.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@parallels.com \
--cc=vishnu.ps@samsung.com \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.