[meta-oe][master][dizzy]PATCH] xserver-common: disable TCP connections

[meta-oe][master][dizzy]PATCH] xserver-common: disable TCP connections

[Javier Viguera]

For security reasons disable TCP connections to the xserver.

Signed-off-by: Javier Viguera <javier.viguera@digi.com>
---
 ...15-xserver-common-disable-TCP-connections.patch | 22 ++++++++++++++++++++++
 .../xserver-common/xserver-common_1.34.bb          |  1 +
 2 files changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch

diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch
new file mode 100644
index 000000000000..0af8030160e2
--- /dev/null
+++ b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch
@@ -0,0 +1,22 @@
+From: Javier Viguera <javier.viguera@digi.com>
+Date: Tue, 25 Nov 2014 18:47:12 +0100
+Subject: [PATCH] xserver-common: disable TCP connections
+
+Signed-off-by: Javier Viguera <javier.viguera@digi.com>
+---
+ X11/xserver-common | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/X11/xserver-common b/X11/xserver-common
+index 017e5aee1ab0..4dc48c412741 100644
+--- a/X11/xserver-common
++++ b/X11/xserver-common
+@@ -44,7 +44,7 @@ SCREEN_SIZE=`fallback_screen_arg`
+ export USER=root
+ export XSERVER_DEFAULT_ORIENTATION=normal
+ 
+-ARGS="-br -pn $INPUT_EXTRA_ARGS"
++ARGS="-br -pn -nolisten tcp $INPUT_EXTRA_ARGS"
+ DPI="100"
+ MOUSE=""
+ KDRIVEARGS=""
diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
index 12fff9ae9a0d..f5b1984cdde3 100644
--- a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
+++ b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
@@ -24,6 +24,7 @@ SRC_URI_append = " \
     file://0012-xserver-common-add-support-for-gta04-alias-OpenPhoen.patch \
     file://0013-xserver-common-add-support-for-tuna-alias-Galaxy-Nex.patch \
     file://0014-Xserver-Start-Xsession-like-x11-common-does.patch \
+    file://0015-xserver-common-disable-TCP-connections.patch \
 "
 
 do_install_append() {

Re: [meta-oe][master][dizzy]PATCH] xserver-common: disable TCP connections

[akuster]

Javier,

What is the disposition of the patch?

There is a recommend format, see:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations

please resubmit once correct.

regards,
- Armin

On 11/25/2014 10:17 AM, Javier Viguera wrote:
> For security reasons disable TCP connections to the xserver.
>
> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> ---
>   ...15-xserver-common-disable-TCP-connections.patch | 22 ++++++++++++++++++++++
>   .../xserver-common/xserver-common_1.34.bb          |  1 +
>   2 files changed, 23 insertions(+)
>   create mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch
>
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch
> new file mode 100644
> index 000000000000..0af8030160e2
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/0015-xserver-common-disable-TCP-connections.patch
> @@ -0,0 +1,22 @@
> +From: Javier Viguera <javier.viguera@digi.com>
> +Date: Tue, 25 Nov 2014 18:47:12 +0100
> +Subject: [PATCH] xserver-common: disable TCP connections
> +
> +Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> +---
> + X11/xserver-common | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/X11/xserver-common b/X11/xserver-common
> +index 017e5aee1ab0..4dc48c412741 100644
> +--- a/X11/xserver-common
> ++++ b/X11/xserver-common
> +@@ -44,7 +44,7 @@ SCREEN_SIZE=`fallback_screen_arg`
> + export USER=root
> + export XSERVER_DEFAULT_ORIENTATION=normal
> +
> +-ARGS="-br -pn $INPUT_EXTRA_ARGS"
> ++ARGS="-br -pn -nolisten tcp $INPUT_EXTRA_ARGS"
> + DPI="100"
> + MOUSE=""
> + KDRIVEARGS=""
> diff --git a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> index 12fff9ae9a0d..f5b1984cdde3 100644
> --- a/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> +++ b/meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb
> @@ -24,6 +24,7 @@ SRC_URI_append = " \
>       file://0012-xserver-common-add-support-for-gta04-alias-OpenPhoen.patch \
>       file://0013-xserver-common-add-support-for-tuna-alias-Galaxy-Nex.patch \
>       file://0014-Xserver-Start-Xsession-like-x11-common-does.patch \
> +    file://0015-xserver-common-disable-TCP-connections.patch \
>   "
>
>   do_install_append() {
>

Re: [meta-oe][master][dizzy]PATCH] xserver-common: disable TCP connections

[Viguera, Javier]

Hi Armin

> -----Original Message-----
> From: akuster [mailto:akuster@mvista.com]
> Sent: Tuesday, November 25, 2014 10:14 PM
> To: Viguera, Javier
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][master][dizzy]PATCH] xserver-common:
> disable TCP connections
> 
> Javier,
> 
> What is the disposition of the patch?
> 
> There is a recommend format, see:
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_
> Header_Recommendations
> 
> please resubmit once correct.
> 
> regards,
> - Armin

Resubmitted with 'upstream-status' as V2.

-- jviguera