Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test for relative backing file names

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On 11/24/2014 02:43 AM, Max Reitz wrote:
> Sometimes, qemu does not have a filename to work with, so it does not
> know which directory to use for a backing file specified by a relative
> filename. Add a test which tests that qemu exits with an appropriate
> error message.
> 
> Additionally, add a test for qemu-img create with a backing filename
> relative to the backed image's base directory while omitting the image
> size.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/110     | 94 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/110.out | 19 ++++++++++
>  tests/qemu-iotests/group   |  1 +
>  3 files changed, 114 insertions(+)
>  create mode 100755 tests/qemu-iotests/110
>  create mode 100644 tests/qemu-iotests/110.out
> 

> +echo
> +echo '=== Backing name is always relative to the backed image ==='
> +echo
> +
> +# omit the image size; it shoud work anyway

s/shoud/should/

With the typo fix,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]