Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test for relative backing file names

[Max Reitz <mreitz@redhat.com>]

On 2014-11-25 at 23:06, Eric Blake wrote:
> On 11/24/2014 02:43 AM, Max Reitz wrote:
>> Sometimes, qemu does not have a filename to work with, so it does not
>> know which directory to use for a backing file specified by a relative
>> filename. Add a test which tests that qemu exits with an appropriate
>> error message.
>>
>> Additionally, add a test for qemu-img create with a backing filename
>> relative to the backed image's base directory while omitting the image
>> size.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/110     | 94 ++++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/110.out | 19 ++++++++++
>>   tests/qemu-iotests/group   |  1 +
>>   3 files changed, 114 insertions(+)
>>   create mode 100755 tests/qemu-iotests/110
>>   create mode 100644 tests/qemu-iotests/110.out
>>
>> +echo
>> +echo '=== Backing name is always relative to the backed image ==='
>> +echo
>> +
>> +# omit the image size; it shoud work anyway
> s/shoud/should/

As I did the same mistake twice in some other series, I'm beginning to 
want to blame my keyboard... (I know that certain key sequences work 
bad, for instance, the U in NULL is sometimes omitted (not in null, only 
in NULL))

Max

> With the typo fix,
> Reviewed-by: Eric Blake <eblake@redhat.com>