From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: davinci: make I2C support optional
Date: Fri, 05 Feb 2016 15:15:16 +0100 [thread overview]
Message-ID: <5475182.6SLDQGvbZt@wuerfel> (raw)
In-Reply-To: <56B4A19D.4060307@ti.com>
On Friday 05 February 2016 18:50:29 Sekhar Nori wrote:
> > I checked that CONFIG_I2C is still enabled with davinci_all_defconfig,
> > so that does not have to change.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 45b146d746ea ("ARM: Davinci: Fix I2C build errors")
> > Fixes: 22ca466847ad ("davinci: kconfig: select at24 eeprom for selected boards")
>
> This looks good to me. The #ifdefs in the middle of davinci_evm_init()
> are an eyesore, but getting rid of the selects is a big plus.
>
I agree on the eyesore. I had an earlier version using "if (IS_BUILTIN(CONFIG_I2C))"
checks that was much nicer, but it didn't work because all the declarations
in include/linux/i2c.h are hidden behind an #ifdef.
I thought about sending a patch for that file too, but I think it has come up
before and was nacked then.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: davinci: make I2C support optional
Date: Fri, 05 Feb 2016 15:15:16 +0100 [thread overview]
Message-ID: <5475182.6SLDQGvbZt@wuerfel> (raw)
In-Reply-To: <56B4A19D.4060307@ti.com>
On Friday 05 February 2016 18:50:29 Sekhar Nori wrote:
> > I checked that CONFIG_I2C is still enabled with davinci_all_defconfig,
> > so that does not have to change.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 45b146d746ea ("ARM: Davinci: Fix I2C build errors")
> > Fixes: 22ca466847ad ("davinci: kconfig: select at24 eeprom for selected boards")
>
> This looks good to me. The #ifdefs in the middle of davinci_evm_init()
> are an eyesore, but getting rid of the selects is a big plus.
>
I agree on the eyesore. I had an earlier version using "if (IS_BUILTIN(CONFIG_I2C))"
checks that was much nicer, but it didn't work because all the declarations
in include/linux/i2c.h are hidden behind an #ifdef.
I thought about sending a patch for that file too, but I think it has come up
before and was nacked then.
Arnd
next prev parent reply other threads:[~2016-02-05 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 20:35 [PATCH 0/4] ARM Davinci warning fixes Arnd Bergmann
2016-02-01 20:35 ` [PATCH 1/4] ARM: davinci: limit DT support to DA850 Arnd Bergmann
2016-02-01 20:35 ` Arnd Bergmann
2016-02-01 20:35 ` [PATCH 2/4] ARM: davinci: avoid unused mityomapl138_pn_info variable Arnd Bergmann
2016-02-01 20:35 ` Arnd Bergmann
2016-02-01 20:35 ` [PATCH 3/4] ARM: davinci: DA8xx+DMx combined kernels need PATCH_PHYS_VIRT Arnd Bergmann
2016-02-01 20:35 ` Arnd Bergmann
2016-02-01 20:35 ` [PATCH 4/4] ARM: davinci: make I2C support optional Arnd Bergmann
2016-02-01 20:35 ` Arnd Bergmann
2016-02-05 13:20 ` Sekhar Nori
2016-02-05 13:20 ` Sekhar Nori
2016-02-05 14:15 ` Arnd Bergmann [this message]
2016-02-05 14:15 ` Arnd Bergmann
2016-02-17 15:11 ` [PATCH 0/4] ARM Davinci warning fixes Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475182.6SLDQGvbZt@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.