Re: [PATCH i-g-t, v5 1/7] lib/igt_kms: Rename IGT_COLOROP_FIXED_MATRIX to IGT_COLOROP_FIXED_MATRIX_TYPE

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 9/1/2026 12:59 AM, Swati Sharma wrote:
> Rename the enum/prop name to match the actual DRM colorop property
> name "FIXED_MATRIX_TYPE" and update its users accordingly.
> 

LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Assisted-by: GitHub Copilot
> ---
>   lib/igt_kms.c              | 2 +-
>   lib/igt_kms.h              | 2 +-
>   tests/kms_colorop_helper.c | 4 ++--
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 2d78e3bee..1e27a25f6 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -725,7 +725,7 @@ const char * const igt_colorop_prop_names[IGT_NUM_COLOROP_PROPS] = {
>   	[IGT_COLOROP_MULTIPLIER] = "MULTIPLIER",
>   	[IGT_COLOROP_LUT3D_INTERPOLATION] = "LUT3D_INTERPOLATION",
>   	[IGT_COLOROP_NEXT] = "NEXT",
> -	[IGT_COLOROP_FIXED_MATRIX] = "FIXED_MATRIX_TYPE",
> +	[IGT_COLOROP_FIXED_MATRIX_TYPE] = "FIXED_MATRIX_TYPE",
>   };
>   
>   const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 695f666ba..c8fa11b47 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -363,7 +363,7 @@ enum igt_atomic_colorop_properties {
>   	IGT_COLOROP_MULTIPLIER,
>   	IGT_COLOROP_LUT3D_INTERPOLATION,
>   	IGT_COLOROP_NEXT,
> -	IGT_COLOROP_FIXED_MATRIX,
> +	IGT_COLOROP_FIXED_MATRIX_TYPE,
>   	IGT_NUM_COLOROP_PROPS
>   };
>   
> diff --git a/tests/kms_colorop_helper.c b/tests/kms_colorop_helper.c
> index 3243d01d3..f58f629f5 100644
> --- a/tests/kms_colorop_helper.c
> +++ b/tests/kms_colorop_helper.c
> @@ -263,7 +263,7 @@ static bool can_use_colorop(igt_display_t *display, igt_colorop_t *colorop, kms_
>   		return (igt_colorop_get_prop(display, colorop, IGT_COLOROP_TYPE) == DRM_COLOROP_3D_LUT);
>   	case KMS_COLOROP_FIXED_MATRIX:
>   		if (igt_colorop_get_prop(display, colorop, IGT_COLOROP_TYPE) == DRM_COLOROP_FIXED_MATRIX &&
> -		    igt_colorop_try_prop_enum(colorop, IGT_COLOROP_FIXED_MATRIX, desired->fixed_matrix_info.fixed_matrix_type_name))
> +		    igt_colorop_try_prop_enum(colorop, IGT_COLOROP_FIXED_MATRIX_TYPE, desired->fixed_matrix_info.fixed_matrix_type_name))
>   			return true;
>   		return false;
>   	default:
> @@ -411,7 +411,7 @@ static void set_colorop(igt_display_t *display, kms_colorop_t *colorop)
>   		configure_3dlut(display, colorop, lut_size);
>   		break;
>   	case KMS_COLOROP_FIXED_MATRIX:
> -		igt_colorop_set_prop_enum(colorop->colorop, IGT_COLOROP_FIXED_MATRIX,
> +		igt_colorop_set_prop_enum(colorop->colorop, IGT_COLOROP_FIXED_MATRIX_TYPE,
>   					  colorop->fixed_matrix_info.fixed_matrix_type_name);
>   		break;
>   	default: