From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf
Date: Wed, 26 Nov 2014 13:22:53 +0530 [thread overview]
Message-ID: <547586D5.2040902@samsung.com> (raw)
In-Reply-To: <2379473.Yu7PYOQ3m0@amdc1032>
Hi Bartilomiej,
On Tuesday 08 July 2014 05:33 PM, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
> text data bss dec hex filename
> 5264 4 4 5272 1498 arch/arm/mach-exynos/pmu.o.before
> 2992 4 4 3000 bb8 arch/arm/mach-exynos/pmu.o.after
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
I tested this patch and it's really helpful to reduce size.
How about resubmitting this change? As this will not get applied on
current tree.
Thanks,
Pankaj Dubey
> ---
> arch/arm/mach-exynos/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index b850db4..55ff019 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -101,7 +101,7 @@ enum sys_powerdown {
>
> struct exynos_pmu_conf {
> void __iomem *reg;
> - unsigned int val[NUM_SYS_POWERDOWN];
> + u8 val[NUM_SYS_POWERDOWN];
> };
>
> extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
>
WARNING: multiple messages have this Message-ID (diff)
From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf
Date: Wed, 26 Nov 2014 13:22:53 +0530 [thread overview]
Message-ID: <547586D5.2040902@samsung.com> (raw)
In-Reply-To: <2379473.Yu7PYOQ3m0@amdc1032>
Hi Bartilomiej,
On Tuesday 08 July 2014 05:33 PM, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
> text data bss dec hex filename
> 5264 4 4 5272 1498 arch/arm/mach-exynos/pmu.o.before
> 2992 4 4 3000 bb8 arch/arm/mach-exynos/pmu.o.after
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
I tested this patch and it's really helpful to reduce size.
How about resubmitting this change? As this will not get applied on
current tree.
Thanks,
Pankaj Dubey
> ---
> arch/arm/mach-exynos/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index b850db4..55ff019 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -101,7 +101,7 @@ enum sys_powerdown {
>
> struct exynos_pmu_conf {
> void __iomem *reg;
> - unsigned int val[NUM_SYS_POWERDOWN];
> + u8 val[NUM_SYS_POWERDOWN];
> };
>
> extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
>
next prev parent reply other threads:[~2014-11-26 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 12:03 [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf Bartlomiej Zolnierkiewicz
2014-07-08 12:03 ` Bartlomiej Zolnierkiewicz
2014-11-26 7:52 ` Pankaj Dubey [this message]
2014-11-26 7:52 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547586D5.2040902@samsung.com \
--to=pankaj.dubey@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.