From: Roger Quadros <rogerq@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers
Date: Wed, 26 Nov 2014 13:22:50 +0200 [thread overview]
Message-ID: <5475B80A.5010207@ti.com> (raw)
In-Reply-To: <20141124154403.GB2817@atomide.com>
On 24/11/14 17:44, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [141124 02:02]:
>> On 11/21/2014 08:34 PM, Tony Lindgren wrote:
>>> --- a/drivers/memory/Kconfig
>>> +++ b/drivers/memory/Kconfig
>>> @@ -41,6 +41,14 @@ config TI_EMIF
>>> parameters and other settings during frequency, voltage and
>>> temperature changes
>>>
>>> +config OMAP_GPMC
>>> + bool
>>
>> We should depend on ARCH_OMAP2PLUS. Other platforms won't benefit
>> anything from this driver.
>
> We can't do that yet until we have sorted out the remaining platform
> data issues with arch/arm/mach-omap2/*gpmc*.c files.
>
> So OMAP_GPMC is currently a silent Kconfig option that does not show
> up as the description after the bool is not there, we select
> OMAP_GPMC automatically based on ARCH_OMAP2PLUS.
>
> Once we have the remaining legacy code issues sorted out, we can
> make this into just a regular device driver.
OK. In that case,
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers
Date: Wed, 26 Nov 2014 13:22:50 +0200 [thread overview]
Message-ID: <5475B80A.5010207@ti.com> (raw)
In-Reply-To: <20141124154403.GB2817@atomide.com>
On 24/11/14 17:44, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [141124 02:02]:
>> On 11/21/2014 08:34 PM, Tony Lindgren wrote:
>>> --- a/drivers/memory/Kconfig
>>> +++ b/drivers/memory/Kconfig
>>> @@ -41,6 +41,14 @@ config TI_EMIF
>>> parameters and other settings during frequency, voltage and
>>> temperature changes
>>>
>>> +config OMAP_GPMC
>>> + bool
>>
>> We should depend on ARCH_OMAP2PLUS. Other platforms won't benefit
>> anything from this driver.
>
> We can't do that yet until we have sorted out the remaining platform
> data issues with arch/arm/mach-omap2/*gpmc*.c files.
>
> So OMAP_GPMC is currently a silent Kconfig option that does not show
> up as the description after the bool is not there, we select
> OMAP_GPMC automatically based on ARCH_OMAP2PLUS.
>
> Once we have the remaining legacy code issues sorted out, we can
> make this into just a regular device driver.
OK. In that case,
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
next prev parent reply other threads:[~2014-11-26 11:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:34 [PATCHv2 0/3] Move omap GPMC to live in drivers/memory Tony Lindgren
2014-11-21 18:34 ` Tony Lindgren
2014-11-21 18:34 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-21 18:34 ` Tony Lindgren
2014-11-26 11:28 ` Roger Quadros
2014-11-26 11:28 ` Roger Quadros
2014-11-21 18:34 ` [PATCH 2/3] ARM: OMAP2+: Move GPMC initcall to devices.c Tony Lindgren
2014-11-21 18:34 ` Tony Lindgren
2014-11-21 18:34 ` [PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers Tony Lindgren
2014-11-21 18:34 ` Tony Lindgren
2014-11-21 18:39 ` Felipe Balbi
2014-11-21 18:39 ` Felipe Balbi
2014-11-21 18:45 ` Tony Lindgren
2014-11-21 18:45 ` Tony Lindgren
2014-11-24 10:00 ` Roger Quadros
2014-11-24 10:00 ` Roger Quadros
2014-11-24 15:44 ` Tony Lindgren
2014-11-24 15:44 ` Tony Lindgren
2014-11-26 11:22 ` Roger Quadros [this message]
2014-11-26 11:22 ` Roger Quadros
2014-11-26 20:10 ` Tony Lindgren
2014-11-26 20:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475B80A.5010207@ti.com \
--to=rogerq@ti.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.