* Re: [PATCH 1/1] HID: add BETOP game controller force feedback support [not found] <3e9f782f.a7fa.149df95fef7.Coremail.huangbobupt@163.com> @ 2014-11-25 14:38 ` Jiri Kosina [not found] ` <3497222f.2152a.149ec27f2c1.Coremail.huangbobupt@163.com> 0 siblings, 1 reply; 7+ messages in thread From: Jiri Kosina @ 2014-11-25 14:38 UTC (permalink / raw) To: 黄波; +Cc: linux-input, linux-kernel On Mon, 24 Nov 2014, 黄波 wrote: > From: Huang Bo <huangbobupt@163.com> > > Adds force feedback support for BETOP USB game controllers. > These devices are mass produced in China. Thanks a lot for the patch. A few minor things below. First, the whole driver formatting doesn't comply with our coding style (it has 4 spaces instead of tab). Please reformat that for v2. [ ... snip ... ] > diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c > new file mode 100644 > index 0000000..d97301a > --- /dev/null > +++ b/drivers/hid/hid-betopff.c > @@ -0,0 +1,170 @@ > +/* > + * Force feedback support for Betop based devices > + * > + * The devices are distributed under various names and the same USB device ID > + * can be used in both adapters and actual game controllers. > + * > + * 0x11C0:0x5506 "BTP2185 PC mode Joystick" > + * - tested with BTP2185 V2 PC Mode. > + * > + * 0x8380:0x1850 "BTP2185 V2 PC mode USB Gamepad" > + * - tested with BTP2185 PC Mode with another version. > + * > + * 0x20bc:0x5500 "BTP2185 V2 BFM mode Joystick" > + * - tested with BTP2185 BFM Mode. > + * - tested with BTP2171s. > + * > + * Copyright (c) 2014 Huang Bo <huangbobupt@163.com> > + */ > + > +/* > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the Free > + * Software Foundation; either version 2 of the License, or (at your option) > + * any later version. > + */ > + > +/* #define DEBUG */ > + > +#define debug(format, arg...) pr_debug("hid-betopff: " format "\n" , ## arg) > + > +#include <linux/input.h> > +#include <linux/slab.h> > +#include <linux/module.h> > +#include <linux/hid.h> > + > +#include "hid-ids.h" > + > +struct betopff_device { > + struct hid_report *report; > +}; > + > +static int hid_betopff_play(struct input_dev *dev, void *data, > + struct ff_effect *effect) > +{ > + struct hid_device *hid = input_get_drvdata(dev); > + struct betopff_device *betopff = data; > + __u16 left, right; > + > + left = effect->u.rumble.strong_magnitude; > + right = effect->u.rumble.weak_magnitude; > + > + betopff->report->field[2]->value[0] = left / 256; > + betopff->report->field[3]->value[0] = right / 256; > + debug("running with 0x%02x 0x%02x", left, right); Is there really a need for keeping this debug() in the "production" version? [ ... snip ... ] > +static const struct hid_device_id betop_devices[] = { > + { HID_USB_DEVICE(0x11C0, 0x5506), }, /* BTP2185 PC mode */ > + { HID_USB_DEVICE(0x8380, 0x1850), }, /* BTP2185 V2 PC mode */ > + { HID_USB_DEVICE(0x20bc, 0x5500), }, /* BTP2185 V2 BFM mode */ > + { } You also need an entry for these devices in hid_have_special_driver[] array in drivers/hid/hid-core.c, otherwise correct device <-> driver binding can't be guaranteed. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <3497222f.2152a.149ec27f2c1.Coremail.huangbobupt@163.com>]
* Re:Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support [not found] ` <3497222f.2152a.149ec27f2c1.Coremail.huangbobupt@163.com> @ 2014-11-26 13:15 ` Jiri Kosina 0 siblings, 0 replies; 7+ messages in thread From: Jiri Kosina @ 2014-11-26 13:15 UTC (permalink / raw) To: 黄波; +Cc: linux-input, linux-kernel On Wed, 26 Nov 2014, 黄波 wrote: > From: Huang Bo <huangbobupt@163.com>Adds force feedback support for BETOP USB game controllers. > > These devices are mass produced in China. > > Signed-off-by: Huang Bo <huangbobupt@163.com> It's unfortunately whitespace damaged again. If it's not possible to set up your e-mail client not to cause whitespace damage to patches (please see Documentation/email-clients.txt for some hints), attach the patch as an e-mail attachment. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support @ 2014-11-26 13:15 ` Jiri Kosina 0 siblings, 0 replies; 7+ messages in thread From: Jiri Kosina @ 2014-11-26 13:15 UTC (permalink / raw) To: 黄波; +Cc: linux-input, linux-kernel On Wed, 26 Nov 2014, 黄波 wrote: > From: Huang Bo <huangbobupt@163.com>Adds force feedback support for BETOP USB game controllers. > > These devices are mass produced in China. > > Signed-off-by: Huang Bo <huangbobupt@163.com> It's unfortunately whitespace damaged again. If it's not possible to set up your e-mail client not to cause whitespace damage to patches (please see Documentation/email-clients.txt for some hints), attach the patch as an e-mail attachment. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support 2014-11-26 13:15 ` Jiri Kosina (?) @ 2014-11-26 13:38 ` Huang Bo 2014-11-26 13:49 ` Jiri Kosina -1 siblings, 1 reply; 7+ messages in thread From: Huang Bo @ 2014-11-26 13:38 UTC (permalink / raw) To: Jiri Kosina; +Cc: linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 8924 bytes --] On 11/26/2014 09:15 PM, Jiri Kosina wrote: > On Wed, 26 Nov 2014, 黄波 wrote: > >> From: Huang Bo <huangbobupt@163.com>Adds force feedback support for BETOP USB game controllers. >> >> These devices are mass produced in China. >> >> Signed-off-by: Huang Bo <huangbobupt@163.com> > It's unfortunately whitespace damaged again. If it's not possible to set > up your e-mail client not to cause whitespace damage to patches (please > see Documentation/email-clients.txt for some hints), attach the patch as > an e-mail attachment. > From: Huang Bo <huangbobupt@163.com> Adds force feedback support for BETOP USB game controllers. These devices are mass produced in China. Signed-off-by: Huang Bo <huangbobupt@163.com> --- drivers/hid/Kconfig | 10 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-betopff.c | 168 +++++++++++++++++++++++++++++++++++++++++++++ drivers/hid/hid-core.c | 4 ++ drivers/hid/hid-ids.h | 9 +++ 5 files changed, 192 insertions(+) create mode 100644 drivers/hid/hid-betopff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 4938bd3..0a8fdc5 100755 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -201,6 +201,16 @@ config DRAGONRISE_FF Say Y here if you want to enable force feedback support for DragonRise Inc. game controllers. +config HID_BETOP_FF + tristate "Betop Production Inc. force feedback support" + depends on USB_HID + select INPUT_FF_MEMLESS + ---help--- + Say Y here if you want to enable force feedback support for devices by + BETOP Production Ltd. + Currently the following devices are known to be supported: + - BETOP 2185 PC & BFM MODE + config HID_EMS_FF tristate "EMS Production Inc. force feedback support" depends on HID diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index 4113999..a0546ca 100755 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -46,6 +46,7 @@ obj-$(CONFIG_HID_CHERRY) += hid-cherry.o obj-$(CONFIG_HID_CHICONY) += hid-chicony.o obj-$(CONFIG_HID_CYPRESS) += hid-cypress.o obj-$(CONFIG_HID_DRAGONRISE) += hid-dr.o +obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o obj-$(CONFIG_HID_EMS_FF) += hid-emsff.o obj-$(CONFIG_HID_ELECOM) += hid-elecom.o obj-$(CONFIG_HID_EZKEY) += hid-ezkey.o diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c new file mode 100644 index 0000000..b94acb2 --- /dev/null +++ b/drivers/hid/hid-betopff.c @@ -0,0 +1,168 @@ +/* + * Force feedback support for Betop based devices + * + * The devices are distributed under various names and the same USB device ID + * can be used in both adapters and actual game controllers. + * + * 0x11C0:0x5506 "BTP2185 PC mode Joystick" + * - tested with BTP2185 PC Mode. + * + * 0x11c2:0x2208 "BTP2185 BFM mode Joystick" + * - tested with BTP2185 BFM Mode. + * + * 0x8380:0x1850 "BTP2185 V2 PC mode USB Gamepad" + * - tested with BTP2185 PC Mode with another version. + * + * 0x20bc:0x5500 "BTP2185 V2 BFM mode Joystick" + * - tested with BTP2171s. + * Copyright (c) 2014 Huang Bo <huangbobupt@163.com> + */ + +/* + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the Free + * Software Foundation; either version 2 of the License, or (at your option) + * any later version. + */ + + +#include <linux/input.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/hid.h> + +#include "hid-ids.h" + +struct betopff_device { + struct hid_report *report; +}; + +static int hid_betopff_play(struct input_dev *dev, void *data, + struct ff_effect *effect) +{ + struct hid_device *hid = input_get_drvdata(dev); + struct betopff_device *betopff = data; + __u16 left, right; + + left = effect->u.rumble.strong_magnitude; + right = effect->u.rumble.weak_magnitude; + + betopff->report->field[2]->value[0] = left / 256; + betopff->report->field[3]->value[0] = right / 256; + + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + + return 0; +} + +static int betopff_init(struct hid_device *hid) +{ + struct betopff_device *betopff; + struct hid_report *report; + struct hid_input *hidinput; + struct list_head *report_list = + &hid->report_enum[HID_OUTPUT_REPORT].report_list; + struct list_head *report_ptr = report_list; + struct input_dev *dev; + int error; + int i, j; + int field_count = 0; + + if (list_empty(report_list)) { + hid_err(hid, "no output reports found\n"); + return -ENODEV; + } + + list_for_each_entry(hidinput, &hid->inputs, list) { + + report_ptr = report_ptr->next; + + if (report_ptr == report_list) { + hid_err(hid, "required output report is missing\n"); + return -ENODEV; + } + + report = list_entry(report_ptr, struct hid_report, list); + if (report->maxfield < 1) { + hid_err(hid, "no fields in the report\n"); + return -ENODEV; + } + + for (i = 0; i < report->maxfield; i++) { + for (j = 0; j < report->field[i]->report_count; j++) { + report->field[i]->value[j] = 0x00; + field_count++; + } + } + + if (field_count < 4) { + hid_err(hid, "not enough fields in the report: %d\n", + field_count); + return -ENODEV; + } + + betopff = kzalloc(sizeof(struct betopff_device), GFP_KERNEL); + if (!betopff) + return -ENOMEM; + + dev = hidinput->input; + set_bit(FF_RUMBLE, dev->ffbit); + + error = input_ff_create_memless(dev, betopff, hid_betopff_play); + if (error) { + kfree(betopff); + return error; + } + + betopff->report = report; + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + } + + hid_info(hid, "Force feedback for betop devices by huangbo <huangbobupt@163.com>\n"); + + return 0; +} + +static int betop_probe(struct hid_device *hdev, const struct hid_device_id *id) +{ + int ret; + + if (id->driver_data) + hdev->quirks |= HID_QUIRK_MULTI_INPUT; + + ret = hid_parse(hdev); + if (ret) { + hid_err(hdev, "parse failed\n"); + goto err; + } + + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF); + if (ret) { + hid_err(hdev, "hw start failed\n"); + goto err; + } + + betopff_init(hdev); + + return 0; +err: + return ret; +} + +static const struct hid_device_id betop_devices[] = { + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, USB_DEVICE_ID_BETOP_2185PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, USB_DEVICE_ID_BETOP_2185BFM) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, USB_DEVICE_ID_BETOP_2185V2PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, USB_DEVICE_ID_BETOP_2185V2BFM) }, + { } +}; +MODULE_DEVICE_TABLE(hid, betop_devices); + +static struct hid_driver betop_driver = { + .name = "betop", + .id_table = betop_devices, + .probe = betop_probe, +}; +module_hid_driver(betop_driver); + +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index a622590..90f608f 100755 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1820,6 +1820,10 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, USB_DEVICE_ID_BETOP_2185PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, USB_DEVICE_ID_BETOP_2185BFM) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, USB_DEVICE_ID_BETOP_2185V2PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, USB_DEVICE_ID_BETOP_2185V2BFM) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 161ee89..d3f7537 100755 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -907,6 +907,15 @@ #define USB_VENDOR_ID_ZYDACRON 0x13EC #define USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL 0x0006 +#define USB_VENDOR_ID_BETOP_2185PC 0x11c0 +#define USB_VENDOR_ID_BETOP_2185BFM 0x11c2 +#define USB_VENDOR_ID_BETOP_2185V2PC 0x8380 +#define USB_VENDOR_ID_BETOP_2185V2BFM 0x20bc +#define USB_DEVICE_ID_BETOP_2185PC 0x5506 +#define USB_DEVICE_ID_BETOP_2185BFM 0x2208 +#define USB_DEVICE_ID_BETOP_2185V2PC 0x1850 +#define USB_DEVICE_ID_BETOP_2185V2BFM 0x5500 + #define USB_VENDOR_ID_ZYTRONIC 0x14c8 #define USB_DEVICE_ID_ZYTRONIC_ZXY100 0x0005 -- 1.7.9.5 [-- Attachment #2: 0001-HID-add-BETOP-game-controller-force-feedback-support.patch --] [-- Type: text/x-patch, Size: 8442 bytes --] >From a9282c8ebb866b26b8cb7dd7ae54628301d704d6 Mon Sep 17 00:00:00 2001 From: Huang Bo <huangbobupt@163.com> Date: Wed, 26 Nov 2014 18:21:03 +0800 Subject: [PATCH] HID: add BETOP game controller force feedback support Adds force feedback support for BETOP USB game controllers. These devices are mass produced in China. Signed-off-by: Huang Bo <huangbobupt@163.com> --- drivers/hid/Kconfig | 10 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-betopff.c | 168 +++++++++++++++++++++++++++++++++++++++++++++ drivers/hid/hid-core.c | 4 ++ drivers/hid/hid-ids.h | 9 +++ 5 files changed, 192 insertions(+) create mode 100644 drivers/hid/hid-betopff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 4938bd3..0a8fdc5 100755 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -201,6 +201,16 @@ config DRAGONRISE_FF Say Y here if you want to enable force feedback support for DragonRise Inc. game controllers. +config HID_BETOP_FF + tristate "Betop Production Inc. force feedback support" + depends on USB_HID + select INPUT_FF_MEMLESS + ---help--- + Say Y here if you want to enable force feedback support for devices by + BETOP Production Ltd. + Currently the following devices are known to be supported: + - BETOP 2185 PC & BFM MODE + config HID_EMS_FF tristate "EMS Production Inc. force feedback support" depends on HID diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index 4113999..a0546ca 100755 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -46,6 +46,7 @@ obj-$(CONFIG_HID_CHERRY) += hid-cherry.o obj-$(CONFIG_HID_CHICONY) += hid-chicony.o obj-$(CONFIG_HID_CYPRESS) += hid-cypress.o obj-$(CONFIG_HID_DRAGONRISE) += hid-dr.o +obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o obj-$(CONFIG_HID_EMS_FF) += hid-emsff.o obj-$(CONFIG_HID_ELECOM) += hid-elecom.o obj-$(CONFIG_HID_EZKEY) += hid-ezkey.o diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c new file mode 100644 index 0000000..b94acb2 --- /dev/null +++ b/drivers/hid/hid-betopff.c @@ -0,0 +1,168 @@ +/* + * Force feedback support for Betop based devices + * + * The devices are distributed under various names and the same USB device ID + * can be used in both adapters and actual game controllers. + * + * 0x11C0:0x5506 "BTP2185 PC mode Joystick" + * - tested with BTP2185 PC Mode. + * + * 0x11c2:0x2208 "BTP2185 BFM mode Joystick" + * - tested with BTP2185 BFM Mode. + * + * 0x8380:0x1850 "BTP2185 V2 PC mode USB Gamepad" + * - tested with BTP2185 PC Mode with another version. + * + * 0x20bc:0x5500 "BTP2185 V2 BFM mode Joystick" + * - tested with BTP2171s. + * Copyright (c) 2014 Huang Bo <huangbobupt@163.com> + */ + +/* + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the Free + * Software Foundation; either version 2 of the License, or (at your option) + * any later version. + */ + + +#include <linux/input.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/hid.h> + +#include "hid-ids.h" + +struct betopff_device { + struct hid_report *report; +}; + +static int hid_betopff_play(struct input_dev *dev, void *data, + struct ff_effect *effect) +{ + struct hid_device *hid = input_get_drvdata(dev); + struct betopff_device *betopff = data; + __u16 left, right; + + left = effect->u.rumble.strong_magnitude; + right = effect->u.rumble.weak_magnitude; + + betopff->report->field[2]->value[0] = left / 256; + betopff->report->field[3]->value[0] = right / 256; + + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + + return 0; +} + +static int betopff_init(struct hid_device *hid) +{ + struct betopff_device *betopff; + struct hid_report *report; + struct hid_input *hidinput; + struct list_head *report_list = + &hid->report_enum[HID_OUTPUT_REPORT].report_list; + struct list_head *report_ptr = report_list; + struct input_dev *dev; + int error; + int i, j; + int field_count = 0; + + if (list_empty(report_list)) { + hid_err(hid, "no output reports found\n"); + return -ENODEV; + } + + list_for_each_entry(hidinput, &hid->inputs, list) { + + report_ptr = report_ptr->next; + + if (report_ptr == report_list) { + hid_err(hid, "required output report is missing\n"); + return -ENODEV; + } + + report = list_entry(report_ptr, struct hid_report, list); + if (report->maxfield < 1) { + hid_err(hid, "no fields in the report\n"); + return -ENODEV; + } + + for (i = 0; i < report->maxfield; i++) { + for (j = 0; j < report->field[i]->report_count; j++) { + report->field[i]->value[j] = 0x00; + field_count++; + } + } + + if (field_count < 4) { + hid_err(hid, "not enough fields in the report: %d\n", + field_count); + return -ENODEV; + } + + betopff = kzalloc(sizeof(struct betopff_device), GFP_KERNEL); + if (!betopff) + return -ENOMEM; + + dev = hidinput->input; + set_bit(FF_RUMBLE, dev->ffbit); + + error = input_ff_create_memless(dev, betopff, hid_betopff_play); + if (error) { + kfree(betopff); + return error; + } + + betopff->report = report; + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + } + + hid_info(hid, "Force feedback for betop devices by huangbo <huangbobupt@163.com>\n"); + + return 0; +} + +static int betop_probe(struct hid_device *hdev, const struct hid_device_id *id) +{ + int ret; + + if (id->driver_data) + hdev->quirks |= HID_QUIRK_MULTI_INPUT; + + ret = hid_parse(hdev); + if (ret) { + hid_err(hdev, "parse failed\n"); + goto err; + } + + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF); + if (ret) { + hid_err(hdev, "hw start failed\n"); + goto err; + } + + betopff_init(hdev); + + return 0; +err: + return ret; +} + +static const struct hid_device_id betop_devices[] = { + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, USB_DEVICE_ID_BETOP_2185PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, USB_DEVICE_ID_BETOP_2185BFM) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, USB_DEVICE_ID_BETOP_2185V2PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, USB_DEVICE_ID_BETOP_2185V2BFM) }, + { } +}; +MODULE_DEVICE_TABLE(hid, betop_devices); + +static struct hid_driver betop_driver = { + .name = "betop", + .id_table = betop_devices, + .probe = betop_probe, +}; +module_hid_driver(betop_driver); + +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index a622590..90f608f 100755 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1820,6 +1820,10 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, USB_DEVICE_ID_BETOP_2185PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, USB_DEVICE_ID_BETOP_2185BFM) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, USB_DEVICE_ID_BETOP_2185V2PC) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, USB_DEVICE_ID_BETOP_2185V2BFM) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 161ee89..d3f7537 100755 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -907,6 +907,15 @@ #define USB_VENDOR_ID_ZYDACRON 0x13EC #define USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL 0x0006 +#define USB_VENDOR_ID_BETOP_2185PC 0x11c0 +#define USB_VENDOR_ID_BETOP_2185BFM 0x11c2 +#define USB_VENDOR_ID_BETOP_2185V2PC 0x8380 +#define USB_VENDOR_ID_BETOP_2185V2BFM 0x20bc +#define USB_DEVICE_ID_BETOP_2185PC 0x5506 +#define USB_DEVICE_ID_BETOP_2185BFM 0x2208 +#define USB_DEVICE_ID_BETOP_2185V2PC 0x1850 +#define USB_DEVICE_ID_BETOP_2185V2BFM 0x5500 + #define USB_VENDOR_ID_ZYTRONIC 0x14c8 #define USB_DEVICE_ID_ZYTRONIC_ZXY100 0x0005 -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support 2014-11-26 13:38 ` Huang Bo @ 2014-11-26 13:49 ` Jiri Kosina 2014-11-26 14:16 ` Huang Bo 0 siblings, 1 reply; 7+ messages in thread From: Jiri Kosina @ 2014-11-26 13:49 UTC (permalink / raw) To: Huang Bo; +Cc: linux-input, linux-kernel On Wed, 26 Nov 2014, Huang Bo wrote: > > It's unfortunately whitespace damaged again. If it's not possible to set > > up your e-mail client not to cause whitespace damage to patches (please > > see Documentation/email-clients.txt for some hints), attach the patch as > > an e-mail attachment. > > > From: Huang Bo <huangbobupt@163.com> > > Adds force feedback support for BETOP USB game controllers. > These devices are mass produced in China. Alright, so you apparently wrote the code with incorrect formatting, as even the version you attached doesn't have the formatting right. Please reformat the code according to Documentation/CodingStyle and resubmit. Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support 2014-11-26 13:49 ` Jiri Kosina @ 2014-11-26 14:16 ` Huang Bo 2014-11-26 16:22 ` Jiri Kosina 0 siblings, 1 reply; 7+ messages in thread From: Huang Bo @ 2014-11-26 14:16 UTC (permalink / raw) To: Jiri Kosina; +Cc: linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 8753 bytes --] On 11/26/2014 09:49 PM, Jiri Kosina wrote: > On Wed, 26 Nov 2014, Huang Bo wrote: > >>> It's unfortunately whitespace damaged again. If it's not possible to set >>> up your e-mail client not to cause whitespace damage to patches (please >>> see Documentation/email-clients.txt for some hints), attach the patch as >>> an e-mail attachment. >>> >> From: Huang Bo <huangbobupt@163.com> >> >> Adds force feedback support for BETOP USB game controllers. >> These devices are mass produced in China. > Alright, so you apparently wrote the code with incorrect formatting, as > even the version you attached doesn't have the formatting right. > > Please reformat the code according to Documentation/CodingStyle and > resubmit. > > Thanks, > From: Huang Bo <huangbobupt@163.com> Adds force feedback support for BETOP USB game controllers. These devices are mass produced in China. Signed-off-by: Huang Bo <huangbobupt@163.com> --- drivers/hid/Kconfig | 10 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-betopff.c | 168 +++++++++++++++++++++++++++++++++++++++++++++ drivers/hid/hid-core.c | 4 ++ drivers/hid/hid-ids.h | 5 ++ 5 files changed, 188 insertions(+) create mode 100644 drivers/hid/hid-betopff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 4938bd3..0a8fdc5 100755 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -201,6 +201,16 @@ config DRAGONRISE_FF Say Y here if you want to enable force feedback support for DragonRise Inc. game controllers. +config HID_BETOP_FF + tristate "Betop Production Inc. force feedback support" + depends on USB_HID + select INPUT_FF_MEMLESS + ---help--- + Say Y here if you want to enable force feedback support for devices by + BETOP Production Ltd. + Currently the following devices are known to be supported: + - BETOP 2185 PC & BFM MODE + config HID_EMS_FF tristate "EMS Production Inc. force feedback support" depends on HID diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index 4113999..a0546ca 100755 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -46,6 +46,7 @@ obj-$(CONFIG_HID_CHERRY) += hid-cherry.o obj-$(CONFIG_HID_CHICONY) += hid-chicony.o obj-$(CONFIG_HID_CYPRESS) += hid-cypress.o obj-$(CONFIG_HID_DRAGONRISE) += hid-dr.o +obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o obj-$(CONFIG_HID_EMS_FF) += hid-emsff.o obj-$(CONFIG_HID_ELECOM) += hid-elecom.o obj-$(CONFIG_HID_EZKEY) += hid-ezkey.o diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c new file mode 100644 index 0000000..447d6ba --- /dev/null +++ b/drivers/hid/hid-betopff.c @@ -0,0 +1,168 @@ +/* + * Force feedback support for Betop based devices + * + * The devices are distributed under various names and the same USB device ID + * can be used in both adapters and actual game controllers. + * + * 0x11C0:0x5506 "BTP2185 PC mode Joystick" + * - tested with BTP2185 PC Mode. + * + * 0x11c2:0x2208 "BTP2185 BFM mode Joystick" + * - tested with BTP2185 BFM Mode. + * + * 0x8380:0x1850 "BTP2185 V2 PC mode USB Gamepad" + * - tested with BTP2185 PC Mode with another version. + * + * 0x20bc:0x5500 "BTP2185 V2 BFM mode Joystick" + * - tested with BTP2171s. + * Copyright (c) 2014 Huang Bo <huangbobupt@163.com> + */ + +/* + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the Free + * Software Foundation; either version 2 of the License, or (at your option) + * any later version. + */ + + +#include <linux/input.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/hid.h> + +#include "hid-ids.h" + +struct betopff_device { + struct hid_report *report; +}; + +static int hid_betopff_play(struct input_dev *dev, void *data, + struct ff_effect *effect) +{ + struct hid_device *hid = input_get_drvdata(dev); + struct betopff_device *betopff = data; + __u16 left, right; + + left = effect->u.rumble.strong_magnitude; + right = effect->u.rumble.weak_magnitude; + + betopff->report->field[2]->value[0] = left / 256; + betopff->report->field[3]->value[0] = right / 256; + + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + + return 0; +} + +static int betopff_init(struct hid_device *hid) +{ + struct betopff_device *betopff; + struct hid_report *report; + struct hid_input *hidinput; + struct list_head *report_list = + &hid->report_enum[HID_OUTPUT_REPORT].report_list; + struct list_head *report_ptr = report_list; + struct input_dev *dev; + int error; + int i, j; + int field_count = 0; + + if (list_empty(report_list)) { + hid_err(hid, "no output reports found\n"); + return -ENODEV; + } + + list_for_each_entry(hidinput, &hid->inputs, list) { + + report_ptr = report_ptr->next; + + if (report_ptr == report_list) { + hid_err(hid, "required output report is missing\n"); + return -ENODEV; + } + + report = list_entry(report_ptr, struct hid_report, list); + if (report->maxfield < 1) { + hid_err(hid, "no fields in the report\n"); + return -ENODEV; + } + + for (i = 0; i < report->maxfield; i++) { + for (j = 0; j < report->field[i]->report_count; j++) { + report->field[i]->value[j] = 0x00; + field_count++; + } + } + + if (field_count < 4) { + hid_err(hid, "not enough fields in the report: %d\n", + field_count); + return -ENODEV; + } + + betopff = kzalloc(sizeof(*betopff), GFP_KERNEL); + if (!betopff) + return -ENOMEM; + + dev = hidinput->input; + set_bit(FF_RUMBLE, dev->ffbit); + + error = input_ff_create_memless(dev, betopff, hid_betopff_play); + if (error) { + kfree(betopff); + return error; + } + + betopff->report = report; + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + } + + hid_info(hid, "Force feedback for betop devices by huangbo <huangbobupt@163.com>\n"); + + return 0; +} + +static int betop_probe(struct hid_device *hdev, const struct hid_device_id *id) +{ + int ret; + + if (id->driver_data) + hdev->quirks |= HID_QUIRK_MULTI_INPUT; + + ret = hid_parse(hdev); + if (ret) { + hid_err(hdev, "parse failed\n"); + goto err; + } + + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF); + if (ret) { + hid_err(hdev, "hw start failed\n"); + goto err; + } + + betopff_init(hdev); + + return 0; +err: + return ret; +} + +static const struct hid_device_id betop_devices[] = { + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, 0x5506) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, 0x2208) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, 0x1850) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, 0x5500) }, + { } +}; +MODULE_DEVICE_TABLE(hid, betop_devices); + +static struct hid_driver betop_driver = { + .name = "betop", + .id_table = betop_devices, + .probe = betop_probe, +}; +module_hid_driver(betop_driver); + +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index a622590..5ae554e 100755 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1820,6 +1820,10 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, 0x5506) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, 0x2208) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, 0x1850) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, 0x5500) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 161ee89..dce26bb 100755 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -907,6 +907,11 @@ #define USB_VENDOR_ID_ZYDACRON 0x13EC #define USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL 0x0006 +#define USB_VENDOR_ID_BETOP_2185PC 0x11c0 +#define USB_VENDOR_ID_BETOP_2185BFM 0x11c2 +#define USB_VENDOR_ID_BETOP_2185V2PC 0x8380 +#define USB_VENDOR_ID_BETOP_2185V2BFM 0x20bc + #define USB_VENDOR_ID_ZYTRONIC 0x14c8 #define USB_DEVICE_ID_ZYTRONIC_ZXY100 0x0005 -- 1.7.9.5 [-- Attachment #2: 0001-HID-add-BETOP-game-controller-force-feedback-support.patch --] [-- Type: text/x-patch, Size: 7634 bytes --] >From ce4bd236f4fc23c7c8540d122c8ffc4327dab893 Mon Sep 17 00:00:00 2001 From: Huang Bo <huangbobupt@163.com> Date: Wed, 26 Nov 2014 18:21:03 +0800 Subject: [PATCH] HID: add BETOP game controller force feedback support Adds force feedback support for BETOP USB game controllers. These devices are mass produced in China. Signed-off-by: Huang Bo <huangbobupt@163.com> --- drivers/hid/Kconfig | 10 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-betopff.c | 168 +++++++++++++++++++++++++++++++++++++++++++++ drivers/hid/hid-core.c | 4 ++ drivers/hid/hid-ids.h | 5 ++ 5 files changed, 188 insertions(+) create mode 100644 drivers/hid/hid-betopff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 4938bd3..0a8fdc5 100755 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -201,6 +201,16 @@ config DRAGONRISE_FF Say Y here if you want to enable force feedback support for DragonRise Inc. game controllers. +config HID_BETOP_FF + tristate "Betop Production Inc. force feedback support" + depends on USB_HID + select INPUT_FF_MEMLESS + ---help--- + Say Y here if you want to enable force feedback support for devices by + BETOP Production Ltd. + Currently the following devices are known to be supported: + - BETOP 2185 PC & BFM MODE + config HID_EMS_FF tristate "EMS Production Inc. force feedback support" depends on HID diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile index 4113999..a0546ca 100755 --- a/drivers/hid/Makefile +++ b/drivers/hid/Makefile @@ -46,6 +46,7 @@ obj-$(CONFIG_HID_CHERRY) += hid-cherry.o obj-$(CONFIG_HID_CHICONY) += hid-chicony.o obj-$(CONFIG_HID_CYPRESS) += hid-cypress.o obj-$(CONFIG_HID_DRAGONRISE) += hid-dr.o +obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o obj-$(CONFIG_HID_EMS_FF) += hid-emsff.o obj-$(CONFIG_HID_ELECOM) += hid-elecom.o obj-$(CONFIG_HID_EZKEY) += hid-ezkey.o diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c new file mode 100644 index 0000000..447d6ba --- /dev/null +++ b/drivers/hid/hid-betopff.c @@ -0,0 +1,168 @@ +/* + * Force feedback support for Betop based devices + * + * The devices are distributed under various names and the same USB device ID + * can be used in both adapters and actual game controllers. + * + * 0x11C0:0x5506 "BTP2185 PC mode Joystick" + * - tested with BTP2185 PC Mode. + * + * 0x11c2:0x2208 "BTP2185 BFM mode Joystick" + * - tested with BTP2185 BFM Mode. + * + * 0x8380:0x1850 "BTP2185 V2 PC mode USB Gamepad" + * - tested with BTP2185 PC Mode with another version. + * + * 0x20bc:0x5500 "BTP2185 V2 BFM mode Joystick" + * - tested with BTP2171s. + * Copyright (c) 2014 Huang Bo <huangbobupt@163.com> + */ + +/* + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the Free + * Software Foundation; either version 2 of the License, or (at your option) + * any later version. + */ + + +#include <linux/input.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/hid.h> + +#include "hid-ids.h" + +struct betopff_device { + struct hid_report *report; +}; + +static int hid_betopff_play(struct input_dev *dev, void *data, + struct ff_effect *effect) +{ + struct hid_device *hid = input_get_drvdata(dev); + struct betopff_device *betopff = data; + __u16 left, right; + + left = effect->u.rumble.strong_magnitude; + right = effect->u.rumble.weak_magnitude; + + betopff->report->field[2]->value[0] = left / 256; + betopff->report->field[3]->value[0] = right / 256; + + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + + return 0; +} + +static int betopff_init(struct hid_device *hid) +{ + struct betopff_device *betopff; + struct hid_report *report; + struct hid_input *hidinput; + struct list_head *report_list = + &hid->report_enum[HID_OUTPUT_REPORT].report_list; + struct list_head *report_ptr = report_list; + struct input_dev *dev; + int error; + int i, j; + int field_count = 0; + + if (list_empty(report_list)) { + hid_err(hid, "no output reports found\n"); + return -ENODEV; + } + + list_for_each_entry(hidinput, &hid->inputs, list) { + + report_ptr = report_ptr->next; + + if (report_ptr == report_list) { + hid_err(hid, "required output report is missing\n"); + return -ENODEV; + } + + report = list_entry(report_ptr, struct hid_report, list); + if (report->maxfield < 1) { + hid_err(hid, "no fields in the report\n"); + return -ENODEV; + } + + for (i = 0; i < report->maxfield; i++) { + for (j = 0; j < report->field[i]->report_count; j++) { + report->field[i]->value[j] = 0x00; + field_count++; + } + } + + if (field_count < 4) { + hid_err(hid, "not enough fields in the report: %d\n", + field_count); + return -ENODEV; + } + + betopff = kzalloc(sizeof(*betopff), GFP_KERNEL); + if (!betopff) + return -ENOMEM; + + dev = hidinput->input; + set_bit(FF_RUMBLE, dev->ffbit); + + error = input_ff_create_memless(dev, betopff, hid_betopff_play); + if (error) { + kfree(betopff); + return error; + } + + betopff->report = report; + hid_hw_request(hid, betopff->report, HID_REQ_SET_REPORT); + } + + hid_info(hid, "Force feedback for betop devices by huangbo <huangbobupt@163.com>\n"); + + return 0; +} + +static int betop_probe(struct hid_device *hdev, const struct hid_device_id *id) +{ + int ret; + + if (id->driver_data) + hdev->quirks |= HID_QUIRK_MULTI_INPUT; + + ret = hid_parse(hdev); + if (ret) { + hid_err(hdev, "parse failed\n"); + goto err; + } + + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF); + if (ret) { + hid_err(hdev, "hw start failed\n"); + goto err; + } + + betopff_init(hdev); + + return 0; +err: + return ret; +} + +static const struct hid_device_id betop_devices[] = { + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, 0x5506) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, 0x2208) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, 0x1850) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, 0x5500) }, + { } +}; +MODULE_DEVICE_TABLE(hid, betop_devices); + +static struct hid_driver betop_driver = { + .name = "betop", + .id_table = betop_devices, + .probe = betop_probe, +}; +module_hid_driver(betop_driver); + +MODULE_LICENSE("GPL"); diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index a622590..5ae554e 100755 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1820,6 +1820,10 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185PC, 0x5506) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185BFM, 0x2208) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2PC, 0x1850) }, + { HID_USB_DEVICE(USB_VENDOR_ID_BETOP_2185V2BFM, 0x5500) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 161ee89..dce26bb 100755 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -907,6 +907,11 @@ #define USB_VENDOR_ID_ZYDACRON 0x13EC #define USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL 0x0006 +#define USB_VENDOR_ID_BETOP_2185PC 0x11c0 +#define USB_VENDOR_ID_BETOP_2185BFM 0x11c2 +#define USB_VENDOR_ID_BETOP_2185V2PC 0x8380 +#define USB_VENDOR_ID_BETOP_2185V2BFM 0x20bc + #define USB_VENDOR_ID_ZYTRONIC 0x14c8 #define USB_DEVICE_ID_ZYTRONIC_ZXY100 0x0005 -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCHv2 1/1] HID: add BETOP game controller force feedback support 2014-11-26 14:16 ` Huang Bo @ 2014-11-26 16:22 ` Jiri Kosina 0 siblings, 0 replies; 7+ messages in thread From: Jiri Kosina @ 2014-11-26 16:22 UTC (permalink / raw) To: Huang Bo; +Cc: linux-input, linux-kernel On Wed, 26 Nov 2014, Huang Bo wrote: > On 11/26/2014 09:49 PM, Jiri Kosina wrote: > > On Wed, 26 Nov 2014, Huang Bo wrote: > > > >>> It's unfortunately whitespace damaged again. If it's not possible to set > >>> up your e-mail client not to cause whitespace damage to patches (please > >>> see Documentation/email-clients.txt for some hints), attach the patch as > >>> an e-mail attachment. > >>> > >> From: Huang Bo <huangbobupt@163.com> > >> > >> Adds force feedback support for BETOP USB game controllers. > >> These devices are mass produced in China. > > Alright, so you apparently wrote the code with incorrect formatting, as > > even the version you attached doesn't have the formatting right. > > > > Please reformat the code according to Documentation/CodingStyle and > > resubmit. > > > > Thanks, > > > From: Huang Bo <huangbobupt@163.com> > > Adds force feedback support for BETOP USB game controllers. > These devices are mass produced in China. The inline version is still whitespace-damaged, but the version you attached looks good. [ ... snip ... ] > diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile > index 4113999..a0546ca 100755 > --- a/drivers/hid/Makefile > +++ b/drivers/hid/Makefile > @@ -46,6 +46,7 @@ obj-$(CONFIG_HID_CHERRY) += hid-cherry.o > obj-$(CONFIG_HID_CHICONY) += hid-chicony.o > obj-$(CONFIG_HID_CYPRESS) += hid-cypress.o > obj-$(CONFIG_HID_DRAGONRISE) += hid-dr.o > +obj-$(CONFIG_HID_BETOP_FF) += hid-betopff.o Please try to keep the list ordered. [ ... snip ... ] > +static int betopff_init(struct hid_device *hid) > +{ > + struct betopff_device *betopff; > + struct hid_report *report; > + struct hid_input *hidinput; > + struct list_head *report_list = > + &hid->report_enum[HID_OUTPUT_REPORT].report_list; > + struct list_head *report_ptr = report_list; > + struct input_dev *dev; > + int error; > + int i, j; > + int field_count = 0; > + > + if (list_empty(report_list)) { > + hid_err(hid, "no output reports found\n"); > + return -ENODEV; > + } > + > + list_for_each_entry(hidinput, &hid->inputs, list) { > + > + report_ptr = report_ptr->next; > + > + if (report_ptr == report_list) { > + hid_err(hid, "required output report is missing\n"); > + return -ENODEV; > + } > + > + report = list_entry(report_ptr, struct hid_report, list); > + if (report->maxfield < 1) { > + hid_err(hid, "no fields in the report\n"); > + return -ENODEV; > + } > + > + for (i = 0; i < report->maxfield; i++) { > + for (j = 0; j < report->field[i]->report_count; j++) { > + report->field[i]->value[j] = 0x00; > + field_count++; It's not obvious why this is needed, so a comment before the loop would be nice. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-26 16:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <3e9f782f.a7fa.149df95fef7.Coremail.huangbobupt@163.com>
2014-11-25 14:38 ` [PATCH 1/1] HID: add BETOP game controller force feedback support Jiri Kosina
[not found] ` <3497222f.2152a.149ec27f2c1.Coremail.huangbobupt@163.com>
2014-11-26 13:15 ` Re:Re: [PATCHv2 " Jiri Kosina
2014-11-26 13:15 ` Jiri Kosina
2014-11-26 13:38 ` Huang Bo
2014-11-26 13:49 ` Jiri Kosina
2014-11-26 14:16 ` Huang Bo
2014-11-26 16:22 ` Jiri Kosina
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.