From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Clemens Ladisch <clemens@ladisch.de>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk
Date: Wed, 26 Nov 2014 23:22:09 +0900 [thread overview]
Message-ID: <5475E211.3040106@sakamocchi.jp> (raw)
In-Reply-To: <5474FA18.7000501@ladisch.de>
Clemens,
On Nov 26 2014 06:52, Clemens Ladisch wrote:
> There are several devices that expect to receive MIDI data only in the
> first eight data blocks of a packet. If the driver restricts the data
> rate to the allowed rate (as mandated by the specification, but not yet
> implemented by this driver), this happens naturally. Therefore, there
> is no reason to ever try to use more data packets with any device.
>
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> sound/firewire/amdtp.c | 10 +++++++---
> sound/firewire/amdtp.h | 3 ---
> sound/firewire/bebob/bebob_stream.c | 7 -------
> sound/firewire/fireworks/fireworks_stream.c | 5 -----
> 4 files changed, 7 insertions(+), 18 deletions(-)
Can I ask your opinion about applying this patch to devices with
non-blocking mode? At least, your comment of this patch is for blocking
mode (the fixed number of data blocks in a packet).
Regards
Takashi Sakamoto
o-takashi@sakamocchi.jp
next prev parent reply other threads:[~2014-11-26 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 21:52 [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk Clemens Ladisch
2014-11-25 21:54 ` [PATCH 2/2] ALSA: firewire-lib: limit the MIDI data rate Clemens Ladisch
2014-11-26 8:43 ` [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk Takashi Iwai
2014-11-26 9:17 ` Clemens Ladisch
2014-11-26 14:22 ` Takashi Sakamoto [this message]
2014-11-26 14:38 ` Clemens Ladisch
2014-11-27 12:45 ` Takashi Sakamoto
2014-12-07 13:31 ` Takashi Sakamoto
2015-01-16 21:18 ` Clemens Ladisch
2015-01-16 21:54 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475E211.3040106@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.