From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Tejun Heo <tj@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator
Date: Thu, 16 Jun 2011 14:13:59 +0300 [thread overview]
Message-ID: <5476342.2jZLF0UGcI@barack> (raw)
In-Reply-To: <20110615082301.GN8141@htj.dyndns.org>
On Wednesday 15 June 2011 10:23:01 Tejun Heo wrote:
> On Wed, Jun 15, 2011 at 10:18:58AM +0200, Tejun Heo wrote:
> > No human being can feel 120usec difference and I can't see how using
> > HIGHPRI is justified here (which is what the code is doing
> > _accidentally_ by using singlethread_workqueue).
>
> Ooh, one more thing, and even if you insist on using HIGHPRI (please
> don't), you don't need to create workqueue for each device. You can
> just create one for the whole driver in init and destroy it from exit.
> What matters is the HIGHPRI attribute of the workqueue. The number of
> workqueues is completely irrelevant.
Fair enough.
I'll move to create_workqueue.
If we later find issues with this (in a 'live' system), we can figure out a
way to fix it.
Thank you for your time on this.
I'll make the changes accordingly.
Regards,
Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Tejun Heo <tj@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Girdwood, Liam" <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: Re: Re: Re: Re: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator
Date: Thu, 16 Jun 2011 14:13:59 +0300 [thread overview]
Message-ID: <5476342.2jZLF0UGcI@barack> (raw)
In-Reply-To: <20110615082301.GN8141@htj.dyndns.org>
On Wednesday 15 June 2011 10:23:01 Tejun Heo wrote:
> On Wed, Jun 15, 2011 at 10:18:58AM +0200, Tejun Heo wrote:
> > No human being can feel 120usec difference and I can't see how using
> > HIGHPRI is justified here (which is what the code is doing
> > _accidentally_ by using singlethread_workqueue).
>
> Ooh, one more thing, and even if you insist on using HIGHPRI (please
> don't), you don't need to create workqueue for each device. You can
> just create one for the whole driver in init and destroy it from exit.
> What matters is the HIGHPRI attribute of the workqueue. The number of
> workqueues is completely irrelevant.
Fair enough.
I'll move to create_workqueue.
If we later find issues with this (in a 'live' system), we can figure out a
way to fix it.
Thank you for your time on this.
I'll make the changes accordingly.
Regards,
Péter
next prev parent reply other threads:[~2011-06-16 10:10 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 11:54 [PATCH v4 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 01/18] OMAP: New twl-common for common TWL configuration Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 02/18] OMAP4: Move common twl6030 configuration to twl-common Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 03/18] OMAP3: Move common twl " Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 04/18] OMAP3: Move common regulator " Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 05/18] MFD: twl4030-codec: Rename internals from codec to audio Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 06/18] MFD: twl4030-codec -> twl4030-audio: Rename the driver Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 07/18] MFD: twl4030-audio: Rename platform data Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 08/18] mfd: twl6040: Add initial support Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 09/18] ASoC: twl6040: Convert into TWL6040 MFD child Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 10/18] MFD: twl6040: Change platform data for soc codec driver Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-11 23:18 ` Dmitry Torokhov
2011-06-13 9:51 ` Péter Ujfalusi
2011-06-13 9:51 ` Péter Ujfalusi
2011-06-13 21:20 ` Dmitry Torokhov
2011-06-13 21:20 ` Dmitry Torokhov
2011-06-14 6:34 ` Tejun Heo
2011-06-14 6:34 ` Tejun Heo
2011-06-14 7:17 ` Péter Ujfalusi
2011-06-14 7:17 ` Re: " Péter Ujfalusi
2011-06-14 7:31 ` Tejun Heo
2011-06-14 7:31 ` Tejun Heo
2011-06-14 7:51 ` Péter Ujfalusi
2011-06-14 7:51 ` Re: Re: " Péter Ujfalusi
2011-06-14 8:18 ` Tejun Heo
2011-06-14 8:18 ` Tejun Heo
2011-06-14 10:22 ` Péter Ujfalusi
2011-06-14 10:22 ` Re: Re: Re: " Péter Ujfalusi
2011-06-15 8:18 ` Tejun Heo
2011-06-15 8:18 ` Tejun Heo
2011-06-15 8:23 ` Tejun Heo
2011-06-16 11:13 ` Péter Ujfalusi [this message]
2011-06-16 11:13 ` Péter Ujfalusi
2011-06-16 12:02 ` Tejun Heo
2011-06-16 12:02 ` Tejun Heo
2011-06-16 14:06 ` Péter Ujfalusi
2011-06-16 14:06 ` Re: Re: Re: Re: Re: " Péter Ujfalusi
2011-06-17 9:39 ` Péter Ujfalusi
2011-06-17 9:39 ` Re: [alsa-devel] " Péter Ujfalusi
2011-06-17 9:43 ` Tejun Heo
2011-06-17 9:43 ` Tejun Heo
2011-06-17 10:59 ` Péter Ujfalusi
2011-06-17 10:59 ` Re: Re: [alsa-devel] " Péter Ujfalusi
2011-06-18 14:57 ` Dmitry Torokhov
2011-06-18 14:57 ` Re: Re: [alsa-devel] " Dmitry Torokhov
2011-06-18 15:36 ` Tejun Heo
2011-06-18 15:36 ` Tejun Heo
2011-06-10 11:54 ` [PATCH v4 12/18] OMAP4: SDP4430: Add twl6040 vibrator platform support Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 13/18] ASoC: twl6040: add all ABE DAIs Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 14/18] ASoC: twl6040: Support other sample rates in constraints Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 15/18] ASoC: twl6040: Remove pll and headset mode dependency Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 16/18] ASoC: twl6040: set default constraints Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 17/18] ASoC: twl6040: Configure ramp step based on platform Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-10 11:54 ` [PATCH v4 18/18] OMAP4: SDP4430: Add twl6040 codec platform support Peter Ujfalusi
2011-06-10 11:54 ` Peter Ujfalusi
2011-06-17 10:06 ` [PATCH v4 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Péter Ujfalusi
2011-06-17 10:06 ` Péter Ujfalusi
2011-06-17 9:39 ` Mark Brown
2011-06-17 9:39 ` Mark Brown
2011-06-17 10:53 ` Péter Ujfalusi
2011-06-17 9:51 ` Mark Brown
2011-06-17 10:57 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476342.2jZLF0UGcI@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=tj@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.