* [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
@ 2014-11-26 22:35 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-11-26 22:35 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, kernel-janitors
The "changed" variable should be set to false at the start.
Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index 34fdc40..d53680a 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -661,7 +661,8 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp,
struct snd_card *card = sigmadsp->component->card->snd_card;
struct snd_kcontrol_volatile *vd;
struct snd_ctl_elem_id id;
- bool active, changed;
+ bool active;
+ bool changed = false;
active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask);
^ permalink raw reply related [flat|nested] 5+ messages in thread* [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
@ 2014-11-26 22:35 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-11-26 22:35 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, kernel-janitors
The "changed" variable should be set to false at the start.
Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index 34fdc40..d53680a 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -661,7 +661,8 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp,
struct snd_card *card = sigmadsp->component->card->snd_card;
struct snd_kcontrol_volatile *vd;
struct snd_ctl_elem_id id;
- bool active, changed;
+ bool active;
+ bool changed = false;
active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
2014-11-26 22:35 ` Dan Carpenter
@ 2014-11-27 8:09 ` Lars-Peter Clausen
-1 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-11-27 8:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Takashi Iwai, kernel-janitors, Liam Girdwood,
Mark Brown
On 11/26/2014 11:35 PM, Dan Carpenter wrote:
> The "changed" variable should be set to false at the start.
>
> Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
@ 2014-11-27 8:09 ` Lars-Peter Clausen
0 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-11-27 8:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Takashi Iwai, kernel-janitors, Liam Girdwood,
Mark Brown
On 11/26/2014 11:35 PM, Dan Carpenter wrote:
> The "changed" variable should be set to false at the start.
>
> Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
2014-11-26 22:35 ` Dan Carpenter
(?)
(?)
@ 2014-11-27 10:59 ` Mark Brown
-1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2014-11-27 10:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
On Thu, Nov 27, 2014 at 01:35:16AM +0300, Dan Carpenter wrote:
> The "changed" variable should be set to false at the start.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-27 10:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-26 22:35 [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl() Dan Carpenter
2014-11-26 22:35 ` Dan Carpenter
2014-11-27 8:09 ` Lars-Peter Clausen
2014-11-27 8:09 ` Lars-Peter Clausen
2014-11-27 10:59 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.