possible event_space corruption with ipp_get_event()?

possible event_space corruption with ipp_get_event()?

[Rob Clark]

Hey Inki,

Could you or one of the exynos folks have a look at ipp_get_event()?
That handling of file_priv->event_space looks rather suspect.  I don't
see where event_space is decremented in the first place.  I'm not sure
if that is just broken, or if there is something subtle going on.. but
I guess it probably either needs fixing or a comment.

BR,
-R
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: possible event_space corruption with ipp_get_event()?

[Andrzej Hajda]

On 11/26/2014 06:05 PM, Rob Clark wrote:
> Hey Inki,
> 
> Could you or one of the exynos folks have a look at ipp_get_event()?
> That handling of file_priv->event_space looks rather suspect.  I don't
> see where event_space is decremented in the first place.  I'm not sure
> if that is just broken, or if there is something subtle going on.. but
> I guess it probably either needs fixing or a comment.

It is just broken. I have looked at it some time ago and I saw more
things to fix. I plan to prepare another ipp fix/improve patchset after
finishing other tasks.

Regards
Andrzej

> 
> BR,
> -R
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel