Fwd: [PATCH] mmc: davinci_mmc: add warnings for edma failures

[Angelo Dureghello <angelo@sysam.it>]

Dear all,

would like some feedback / comment to this patch.

Even a NACK is good if you find it nonsense or un-useful, just
to close the loop.

Regards
angelo


-------- Original Message --------
Message-ID: <546FD21C.7010208@sysam.it>
Date: Sat, 22 Nov 2014 01:00:28 +0100
From: Angelo Dureghello <angelo@sysam.it>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 
Icedove/24.5.0
MIME-Version: 1.0
To: linux-mmc@vger.kernel.org
Subject: [PATCH] mmc: davinci_mmc: add warnings for edma failures
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Add warnings in case the edma engine driver fails to allocate slots or
channels requested from the davinci_mmc driver.

Some ti-davinci based boards (i.e. board-da850-evm.c) are asking for
some reserved chans / slots at board init stage. Later, the mmc driver
results in a silent locked state.

Signed-off-by: Angelo Dureghello <angelo <at> sysam.it>

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 5d4c5e0..65d4990 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -439,8 +439,8 @@ static int mmc_davinci_send_dma_request(struct
mmc_davinci_host *host,
                                 DMA_MEM_TO_DEV,
                                 DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
                 if (!desc) {
-                       dev_dbg(mmc_dev(host->mmc),
-                               "failed to allocate DMA TX descriptor");
+                       WARN(1, KERN_WARNING
+                               "failed to allocate DMA TX descriptor\n");
                         ret = -1;
                         goto out;
                 }
@@ -461,8 +461,8 @@ static int mmc_davinci_send_dma_request(struct
mmc_davinci_host *host,
                                 DMA_DEV_TO_MEM,
                                 DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
                 if (!desc) {
-                       dev_dbg(mmc_dev(host->mmc),
-                               "failed to allocate DMA RX descriptor");
+                       WARN(1, KERN_WARNING
+                               "failed to allocate DMA RX descriptor\n");
                         ret = -1;
                         goto out;
                 }