All of lore.kernel.org
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: linux-mmc@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: davinci_mmc: add warnings for edma failures
Date: Thu, 27 Nov 2014 11:18:48 +0100	[thread overview]
Message-ID: <5476FA88.6070105@sysam.it> (raw)
In-Reply-To: <CAPDyKFrBgv9OTzwNfiOSn58Ai7QTbrZm4pKgLrzrM1MgD4=zAA@mail.gmail.com>

Hi Uffe,

many hanks for the reply,

 >> Add warnings in case the edma engine driver fails to allocate slots or
 >> channels requested from the davinci_mmc driver.
 >>
 >> Some ti-davinci based boards (i.e. board-da850-evm.c) are asking for
 >> some reserved chans / slots at board init stage. Later, the mmc driver
 >> results in a silent locked state.
 >
 > So why does davinci_acquire_dma_channels() succeed then? Isn't that
 > real problem you should be looking into?

i explain with more details,

my custom am1808 board initialization, based on 
arch/arm/mach-davinci/board-da850-evm.c, reserves some dma chans / slots 
for the audio at
early boot.

While on kernel 3.5.1 mmc was working properly, moving to kernel
3.17.0, due to the dma-engine wrapper introduction (to be selected
into menuconfig), the mmc host driver locks silently. System cannot
even "reboot" after the failed attempt to reserve the dma slots.

I hardly found out the reason due to missing of clear warnings.

So there is nothing to fix in any other place. Simply, i am suggesting
a more visible warning so the driver, instead of lock-up silently,
throws a problem.

Feel free to add or discard the patch, as you can see it is nothing 
functional.

Regards,
Angelo




  reply	other threads:[~2014-11-27 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-22  0:00 [PATCH] mmc: davinci_mmc: add warnings for edma failures Angelo Dureghello
2014-11-27  9:50 ` Fwd: " Angelo Dureghello
2014-11-27 10:04 ` Ulf Hansson
2014-11-27 10:18   ` Angelo Dureghello [this message]
2014-11-28 11:20     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5476FA88.6070105@sysam.it \
    --to=angelo@sysam.it \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.