From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: do not use get_clock()
Date: Thu, 27 Nov 2014 18:46:44 +0100 [thread overview]
Message-ID: <54776384.4040507@redhat.com> (raw)
In-Reply-To: <87y4qwa66f.fsf@blackfin.pond.sub.org>
On 27/11/2014 18:45, Markus Armbruster wrote:
>> >
>> > Because no one else calls it directly, it is an internal function. I
>> > want to keep it confined to qemu-timer.c (and possibly cpus.c in the
>> > icount implementation, but maybe not even that is necessary).
> That's a perfectly sensible reason. Please add it to the commit
> message, so we have a more permanent record.
>
> Of course, the best permanent record would be a static keyword :)
That's on the todo list. :) I'll send v2 as a toplevel patch if I don't
hear from Kevin or Stefan in a few days. This is 2.3 work so there's time.
Paolo
next prev parent reply other threads:[~2014-11-27 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 14:01 [Qemu-devel] [PATCH] block: do not use get_clock() Paolo Bonzini
2014-11-27 9:19 ` Markus Armbruster
2014-11-27 16:37 ` Paolo Bonzini
2014-11-27 17:45 ` Markus Armbruster
2014-11-27 17:46 ` Paolo Bonzini [this message]
2014-11-27 16:44 ` Stefan Hajnoczi
2014-11-27 17:24 ` Paolo Bonzini
2014-11-28 11:38 ` Stefan Hajnoczi
2014-11-28 13:41 ` Markus Armbruster
2014-12-01 11:15 ` Stefan Hajnoczi
2014-12-01 12:42 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54776384.4040507@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.