* [PATCH 1.1 1/1] arcmsr: Notify has sense data report
@ 2014-11-28 10:07 Ching Huang
2014-11-28 10:14 ` Hannes Reinecke
0 siblings, 1 reply; 5+ messages in thread
From: Ching Huang @ 2014-11-28 10:07 UTC (permalink / raw)
To: hch, thenzl, jbottomley, dan.carpenter, linux-scsi, linux-kernel; +Cc: hare
From: Ching Huang <ching2048@areca.com.tw>
Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data.
Signed-off-by: Ching Huang <ching2048@areca.com.tw>
---
This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
--- a/drivers/scsi/arcmsr/arcmsr.h 2014-09-19 11:04:41.845100000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr.h 2014-11-28 10:54:30.000000000 +0800
@@ -52,7 +52,7 @@ struct device_attribute;
#define ARCMSR_MAX_FREECCB_NUM 320
#define ARCMSR_MAX_OUTSTANDING_CMD 255
#endif
-#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
+#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
#define ARCMSR_SCSI_INITIATOR_ID 255
#define ARCMSR_MAX_XFER_SECTORS 512
#define ARCMSR_MAX_XFER_SECTORS_B 4096
diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-09-19 11:01:26.990090000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-11-28 17:51:04.000000000 +0800
@@ -989,16 +989,15 @@ static void arcmsr_report_sense_info(str
struct scsi_cmnd *pcmd = ccb->pcmd;
struct SENSE_DATA *sensebuffer = (struct SENSE_DATA *)pcmd->sense_buffer;
- pcmd->result = DID_OK << 16;
- if (sensebuffer) {
- int sense_data_length =
+
+ pcmd->result = (DRIVER_SENSE << 24) | (DID_OK << 16) | (CHECK_CONDITION << 1);
+ int sense_data_length =
sizeof(struct SENSE_DATA) < SCSI_SENSE_BUFFERSIZE
? sizeof(struct SENSE_DATA) : SCSI_SENSE_BUFFERSIZE;
- memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
- memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
- sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
- sensebuffer->Valid = 1;
- }
+ memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
+ memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
+ sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
+ sensebuffer->Valid = 1;
}
static u32 arcmsr_disable_outbound_ints(struct AdapterControlBlock *acb)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report
2014-11-28 10:07 [PATCH 1.1 1/1] arcmsr: Notify has sense data report Ching Huang
@ 2014-11-28 10:14 ` Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2014-11-28 10:14 UTC (permalink / raw)
To: Ching Huang, hch, thenzl, jbottomley, dan.carpenter, linux-scsi,
linux-kernel
On 11/28/2014 11:07 AM, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
>
> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data.
>
> Signed-off-by: Ching Huang <ching2048@areca.com.tw>
> ---
>
> This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
>
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
> --- a/drivers/scsi/arcmsr/arcmsr.h 2014-09-19 11:04:41.845100000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-11-28 10:54:30.000000000 +0800
> @@ -52,7 +52,7 @@ struct device_attribute;
> #define ARCMSR_MAX_FREECCB_NUM 320
> #define ARCMSR_MAX_OUTSTANDING_CMD 255
> #endif
> -#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
> +#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
> #define ARCMSR_SCSI_INITIATOR_ID 255
> #define ARCMSR_MAX_XFER_SECTORS 512
> #define ARCMSR_MAX_XFER_SECTORS_B 4096
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-09-19 11:01:26.990090000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-11-28 17:51:04.000000000 +0800
> @@ -989,16 +989,15 @@ static void arcmsr_report_sense_info(str
>
> struct scsi_cmnd *pcmd = ccb->pcmd;
> struct SENSE_DATA *sensebuffer = (struct SENSE_DATA *)pcmd->sense_buffer;
> - pcmd->result = DID_OK << 16;
> - if (sensebuffer) {
> - int sense_data_length =
> +
> + pcmd->result = (DRIVER_SENSE << 24) | (DID_OK << 16) | (CHECK_CONDITION << 1);
> + int sense_data_length =
> sizeof(struct SENSE_DATA) < SCSI_SENSE_BUFFERSIZE
> ? sizeof(struct SENSE_DATA) : SCSI_SENSE_BUFFERSIZE;
> - memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
> - memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
> - sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
> - sensebuffer->Valid = 1;
> - }
> + memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
> + memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
> + sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
> + sensebuffer->Valid = 1;
> }
>
> static u32 arcmsr_disable_outbound_ints(struct AdapterControlBlock *acb)
>
>
Hmm. Sorry to be picky, but:
Is there a chance the _no_ sense data will be provided?
If so we'd end up starting the error handler, calling REQUEST SENSE
(which will fail, too), and finally offlining the device.
I'd rather provide a default sense code for these cases.
Plus please use SAM_STAT_CHECK_CONDITION instead of
CHECK_CONDITION << 1.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report
@ 2014-11-28 10:14 ` Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2014-11-28 10:14 UTC (permalink / raw)
To: Ching Huang, hch, thenzl, jbottomley, dan.carpenter, linux-scsi,
linux-kernel
On 11/28/2014 11:07 AM, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
>
> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data.
>
> Signed-off-by: Ching Huang <ching2048@areca.com.tw>
> ---
>
> This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
>
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
> --- a/drivers/scsi/arcmsr/arcmsr.h 2014-09-19 11:04:41.845100000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-11-28 10:54:30.000000000 +0800
> @@ -52,7 +52,7 @@ struct device_attribute;
> #define ARCMSR_MAX_FREECCB_NUM 320
> #define ARCMSR_MAX_OUTSTANDING_CMD 255
> #endif
> -#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
> +#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
> #define ARCMSR_SCSI_INITIATOR_ID 255
> #define ARCMSR_MAX_XFER_SECTORS 512
> #define ARCMSR_MAX_XFER_SECTORS_B 4096
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-09-19 11:01:26.990090000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-11-28 17:51:04.000000000 +0800
> @@ -989,16 +989,15 @@ static void arcmsr_report_sense_info(str
>
> struct scsi_cmnd *pcmd = ccb->pcmd;
> struct SENSE_DATA *sensebuffer = (struct SENSE_DATA *)pcmd->sense_buffer;
> - pcmd->result = DID_OK << 16;
> - if (sensebuffer) {
> - int sense_data_length =
> +
> + pcmd->result = (DRIVER_SENSE << 24) | (DID_OK << 16) | (CHECK_CONDITION << 1);
> + int sense_data_length =
> sizeof(struct SENSE_DATA) < SCSI_SENSE_BUFFERSIZE
> ? sizeof(struct SENSE_DATA) : SCSI_SENSE_BUFFERSIZE;
> - memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
> - memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
> - sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
> - sensebuffer->Valid = 1;
> - }
> + memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
> + memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
> + sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
> + sensebuffer->Valid = 1;
> }
>
> static u32 arcmsr_disable_outbound_ints(struct AdapterControlBlock *acb)
>
>
Hmm. Sorry to be picky, but:
Is there a chance the _no_ sense data will be provided?
If so we'd end up starting the error handler, calling REQUEST SENSE
(which will fail, too), and finally offlining the device.
I'd rather provide a default sense code for these cases.
Plus please use SAM_STAT_CHECK_CONDITION instead of
CHECK_CONDITION << 1.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report
2014-11-28 10:14 ` Hannes Reinecke
@ 2014-11-28 10:29 ` 黃清隆
-1 siblings, 0 replies; 5+ messages in thread
From: 黃清隆 @ 2014-11-28 10:29 UTC (permalink / raw)
To: Hannes Reinecke
Cc: hch@infradead.org, Tomas Henzl, James Bottomley, Dan Carpenter,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
There is no this case.
We always have auto request sense to device in case of CHECK_CONDITION status.
2014-11-28 18:14 GMT+08:00 Hannes Reinecke <hare@suse.de>:
> On 11/28/2014 11:07 AM, Ching Huang wrote:
>> From: Ching Huang <ching2048@areca.com.tw>
>>
>> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data.
>>
>> Signed-off-by: Ching Huang <ching2048@areca.com.tw>
>> ---
>>
>> This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
>>
>>
>> diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
>> --- a/drivers/scsi/arcmsr/arcmsr.h 2014-09-19 11:04:41.845100000 +0800
>> +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-11-28 10:54:30.000000000 +0800
>> @@ -52,7 +52,7 @@ struct device_attribute;
>> #define ARCMSR_MAX_FREECCB_NUM 320
>> #define ARCMSR_MAX_OUTSTANDING_CMD 255
>> #endif
>> -#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
>> +#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
>> #define ARCMSR_SCSI_INITIATOR_ID 255
>> #define ARCMSR_MAX_XFER_SECTORS 512
>> #define ARCMSR_MAX_XFER_SECTORS_B 4096
>> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
>> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-09-19 11:01:26.990090000 +0800
>> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-11-28 17:51:04.000000000 +0800
>> @@ -989,16 +989,15 @@ static void arcmsr_report_sense_info(str
>>
>> struct scsi_cmnd *pcmd = ccb->pcmd;
>> struct SENSE_DATA *sensebuffer = (struct SENSE_DATA *)pcmd->sense_buffer;
>> - pcmd->result = DID_OK << 16;
>> - if (sensebuffer) {
>> - int sense_data_length =
>> +
>> + pcmd->result = (DRIVER_SENSE << 24) | (DID_OK << 16) | (CHECK_CONDITION << 1);
>> + int sense_data_length =
>> sizeof(struct SENSE_DATA) < SCSI_SENSE_BUFFERSIZE
>> ? sizeof(struct SENSE_DATA) : SCSI_SENSE_BUFFERSIZE;
>> - memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
>> - memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
>> - sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
>> - sensebuffer->Valid = 1;
>> - }
>> + memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
>> + memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
>> + sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
>> + sensebuffer->Valid = 1;
>> }
>>
>> static u32 arcmsr_disable_outbound_ints(struct AdapterControlBlock *acb)
>>
>>
> Hmm. Sorry to be picky, but:
>
> Is there a chance the _no_ sense data will be provided?
> If so we'd end up starting the error handler, calling REQUEST SENSE
> (which will fail, too), and finally offlining the device.
> I'd rather provide a default sense code for these cases.
>
> Plus please use SAM_STAT_CHECK_CONDITION instead of
> CHECK_CONDITION << 1.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke zSeries & Storage
> hare@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report
@ 2014-11-28 10:29 ` 黃清隆
0 siblings, 0 replies; 5+ messages in thread
From: 黃清隆 @ 2014-11-28 10:29 UTC (permalink / raw)
To: Hannes Reinecke
Cc: hch@infradead.org, Tomas Henzl, James Bottomley, Dan Carpenter,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
There is no this case.
We always have auto request sense to device in case of CHECK_CONDITION status.
2014-11-28 18:14 GMT+08:00 Hannes Reinecke <hare@suse.de>:
> On 11/28/2014 11:07 AM, Ching Huang wrote:
>> From: Ching Huang <ching2048@areca.com.tw>
>>
>> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data.
>>
>> Signed-off-by: Ching Huang <ching2048@areca.com.tw>
>> ---
>>
>> This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
>>
>>
>> diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
>> --- a/drivers/scsi/arcmsr/arcmsr.h 2014-09-19 11:04:41.845100000 +0800
>> +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-11-28 10:54:30.000000000 +0800
>> @@ -52,7 +52,7 @@ struct device_attribute;
>> #define ARCMSR_MAX_FREECCB_NUM 320
>> #define ARCMSR_MAX_OUTSTANDING_CMD 255
>> #endif
>> -#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
>> +#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
>> #define ARCMSR_SCSI_INITIATOR_ID 255
>> #define ARCMSR_MAX_XFER_SECTORS 512
>> #define ARCMSR_MAX_XFER_SECTORS_B 4096
>> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
>> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-09-19 11:01:26.990090000 +0800
>> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-11-28 17:51:04.000000000 +0800
>> @@ -989,16 +989,15 @@ static void arcmsr_report_sense_info(str
>>
>> struct scsi_cmnd *pcmd = ccb->pcmd;
>> struct SENSE_DATA *sensebuffer = (struct SENSE_DATA *)pcmd->sense_buffer;
>> - pcmd->result = DID_OK << 16;
>> - if (sensebuffer) {
>> - int sense_data_length =
>> +
>> + pcmd->result = (DRIVER_SENSE << 24) | (DID_OK << 16) | (CHECK_CONDITION << 1);
>> + int sense_data_length =
>> sizeof(struct SENSE_DATA) < SCSI_SENSE_BUFFERSIZE
>> ? sizeof(struct SENSE_DATA) : SCSI_SENSE_BUFFERSIZE;
>> - memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
>> - memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
>> - sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
>> - sensebuffer->Valid = 1;
>> - }
>> + memset(sensebuffer, 0, SCSI_SENSE_BUFFERSIZE);
>> + memcpy(sensebuffer, ccb->arcmsr_cdb.SenseData, sense_data_length);
>> + sensebuffer->ErrorCode = SCSI_SENSE_CURRENT_ERRORS;
>> + sensebuffer->Valid = 1;
>> }
>>
>> static u32 arcmsr_disable_outbound_ints(struct AdapterControlBlock *acb)
>>
>>
> Hmm. Sorry to be picky, but:
>
> Is there a chance the _no_ sense data will be provided?
> If so we'd end up starting the error handler, calling REQUEST SENSE
> (which will fail, too), and finally offlining the device.
> I'd rather provide a default sense code for these cases.
>
> Plus please use SAM_STAT_CHECK_CONDITION instead of
> CHECK_CONDITION << 1.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke zSeries & Storage
> hare@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-28 10:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-28 10:07 [PATCH 1.1 1/1] arcmsr: Notify has sense data report Ching Huang
2014-11-28 10:14 ` Hannes Reinecke
2014-11-28 10:14 ` Hannes Reinecke
2014-11-28 10:29 ` 黃清隆
2014-11-28 10:29 ` 黃清隆
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.