From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Liu,
Jijiang" <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields
Date: Fri, 28 Nov 2014 12:18:45 +0100 [thread overview]
Message-ID: <54785A15.1090301@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258213BB258-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi Konstantin,
On 11/28/2014 12:13 PM, Ananyev, Konstantin wrote:
>>> For the upper layer, I think there would be no big difference, what ways we will choose.
>>
>> I think the 2 informations are transversal, and that's why I would
>> prefer 2 flags. Also, having 2 separate flags would also help to keep
>> backward compatibility with previous versions.
>
> Hmm, not sure how we will break compatibility in that case?
> If we'll make TX_IP_CKSUM to be 1 bit value (1 << X) then for current drivers nothing should change, no?
Yes, you're right, sorry.
Olivier
next prev parent reply other threads:[~2014-11-28 11:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:03 [PATCH v3 0/4] i40e VXLAN TX checksum rework Jijiang Liu
[not found] ` <1417107801-9544-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-27 17:03 ` [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields Jijiang Liu
[not found] ` <1417107801-9544-2-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-28 9:36 ` Olivier MATZ
[not found] ` <54784232.8030707-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 10:27 ` Ananyev, Konstantin
2014-11-28 10:33 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F2B9-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-28 10:40 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BB218-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-28 11:00 ` Olivier MATZ
[not found] ` <547855C9.80507-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 11:13 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BB258-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-28 11:18 ` Olivier MATZ [this message]
[not found] ` <54785A15.1090301-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 15:46 ` Ananyev, Konstantin
2014-11-27 17:03 ` [PATCH v3 2/4] mbuf:change PKT_TX_IPV4 and PKT_TX_IPV6 definition Jijiang Liu
[not found] ` <1417107801-9544-3-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-28 9:37 ` Olivier MATZ
2014-11-27 17:03 ` [PATCH v3 3/4] i40e:PMD change for VXLAN TX checksum Jijiang Liu
2014-11-27 17:03 ` [PATCH v3 4/4] testpmd:rework csum forward engine Jijiang Liu
[not found] ` <1417107801-9544-5-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-28 9:50 ` Olivier MATZ
[not found] ` <54784562.90906-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 10:10 ` Thomas Monjalon
2014-11-27 17:24 ` [PATCH v3 0/4] i40e VXLAN TX checksum rework Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54785A15.1090301@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.