Fix me in htc.c relating to skb_reserve

Fix me in htc.c relating to skb_reserve

[nick]

Greetings Kalle, John and others,
I am wondering why this file is complaining about the code below, if someone can explain to me the issue I would be 
very glad :).
 static struct sk_buff *ath10k_htc_build_tx_ctrl_skb(void *ar)
{
       struct sk_buff *skb;
       struct ath10k_skb_cb *skb_cb;

       skb = dev_alloc_skb(ATH10K_HTC_CONTROL_BUFFER_SIZE);
       if (!skb)
               return NULL;

  skb_reserve(skb, 20); /* FIXME: why 20 bytes? */
  WARN_ONCE((unsigned long)skb->data & 3, "unaligned skb");

  skb_cb = ATH10K_SKB_CB(skb);
  memset(skb_cb, 0, sizeof(*skb_cb));

  ath10k_dbg(ar, ATH10K_DBG_HTC, "%s: skb %p\n", __func__, skb);
  return skb;
}

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Fix me in htc.c relating to skb_reserve

[nick]

Greetings Kalle, John and others,
I am wondering why this file is complaining about the code below, if someone can explain to me the issue I would be 
very glad :).
 static struct sk_buff *ath10k_htc_build_tx_ctrl_skb(void *ar)
{
       struct sk_buff *skb;
       struct ath10k_skb_cb *skb_cb;

       skb = dev_alloc_skb(ATH10K_HTC_CONTROL_BUFFER_SIZE);
       if (!skb)
               return NULL;

  skb_reserve(skb, 20); /* FIXME: why 20 bytes? */
  WARN_ONCE((unsigned long)skb->data & 3, "unaligned skb");

  skb_cb = ATH10K_SKB_CB(skb);
  memset(skb_cb, 0, sizeof(*skb_cb));

  ath10k_dbg(ar, ATH10K_DBG_HTC, "%s: skb %p\n", __func__, skb);
  return skb;
}