From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, a.zummo@towertech.it,
kernel@stlinux.com, rtc-linux@googlegroups.com,
devicetree@vger.kernel.org, wim@iguana.be, linux@roeck-us.net,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 5/8] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device
Date: Wed, 17 Dec 2014 22:54:12 +0100 [thread overview]
Message-ID: <5479005.CEJLtxOOIa@wuerfel> (raw)
In-Reply-To: <1418834727-1602-6-git-send-email-lee.jones@linaro.org>
On Wednesday 17 December 2014 16:45:24 Lee Jones wrote:
> +- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> + "st,stih415-lpc" "st,stid127-lpc"
> +- reg : LPC registers base address + size
> +- interrupts : LPC interrupt line number and associated flags
> +- clocks : Clock used by LPC device (See: ../clock/clock-bindings.txt)
> +- st,lpc-mode : The LPC can run either one of two modes ST_LPC_MODE_RTC [0] or
> + ST_LPC_MODE_WDT [1]. One (and only one) mode must be
> + selected.
>
I'm glad you got it to work with two drivers for the same device.
With this binding, I'm still a bit unhappy about the st,lpc-mode property,
in particular since you rely on a shared include file for something that
can only be set in one way or another and always has to be present.
Why not just use a boolean property that enforces one mode when present
and another mode when absent?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device
Date: Wed, 17 Dec 2014 22:54:12 +0100 [thread overview]
Message-ID: <5479005.CEJLtxOOIa@wuerfel> (raw)
In-Reply-To: <1418834727-1602-6-git-send-email-lee.jones@linaro.org>
On Wednesday 17 December 2014 16:45:24 Lee Jones wrote:
> +- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> + "st,stih415-lpc" "st,stid127-lpc"
> +- reg : LPC registers base address + size
> +- interrupts : LPC interrupt line number and associated flags
> +- clocks : Clock used by LPC device (See: ../clock/clock-bindings.txt)
> +- st,lpc-mode : The LPC can run either one of two modes ST_LPC_MODE_RTC [0] or
> + ST_LPC_MODE_WDT [1]. One (and only one) mode must be
> + selected.
>
I'm glad you got it to work with two drivers for the same device.
With this binding, I'm still a bit unhappy about the st,lpc-mode property,
in particular since you rely on a shared include file for something that
can only be set in one way or another and always has to be present.
Why not just use a boolean property that enforces one mode when present
and another mode when absent?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/8] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device
Date: Wed, 17 Dec 2014 22:54:12 +0100 [thread overview]
Message-ID: <5479005.CEJLtxOOIa@wuerfel> (raw)
In-Reply-To: <1418834727-1602-6-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Wednesday 17 December 2014 16:45:24 Lee Jones wrote:
> +- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> + "st,stih415-lpc" "st,stid127-lpc"
> +- reg : LPC registers base address + size
> +- interrupts : LPC interrupt line number and associated flags
> +- clocks : Clock used by LPC device (See: ../clock/clock-bindings.txt)
> +- st,lpc-mode : The LPC can run either one of two modes ST_LPC_MODE_RTC [0] or
> + ST_LPC_MODE_WDT [1]. One (and only one) mode must be
> + selected.
>
I'm glad you got it to work with two drivers for the same device.
With this binding, I'm still a bit unhappy about the st,lpc-mode property,
in particular since you rely on a shared include file for something that
can only be set in one way or another and always has to be present.
Why not just use a boolean property that enforces one mode when present
and another mode when absent?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-17 21:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 16:45 [PATCH v2 0/8] watchdog: rtc: New driver(s) for ST's LPC IP Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 1/8] mfd: dt-bindings: Provide human readable defines for LPC mode choosing Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 2/8] ARM: multi_v7_defconfig: Enable support for ST's LPC Watchdog Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 3/8] ARM: multi_v7_defconfig: Enable support for ST's LPC RTC Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 4/8] ARM: STi: DT: STiH407: Add Device Tree node for the LPC Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 5/8] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 21:54 ` Arnd Bergmann [this message]
2014-12-17 21:54 ` Arnd Bergmann
2014-12-17 21:54 ` Arnd Bergmann
2014-12-18 8:13 ` Lee Jones
2014-12-18 8:13 ` Lee Jones
2014-12-18 8:13 ` Lee Jones
2014-12-18 8:46 ` Arnd Bergmann
2014-12-18 8:46 ` Arnd Bergmann
2014-12-18 8:46 ` Arnd Bergmann
2014-12-18 9:04 ` Lee Jones
2014-12-18 9:04 ` Lee Jones
2014-12-18 9:04 ` Lee Jones
2014-12-18 9:15 ` Arnd Bergmann
2014-12-18 9:15 ` Arnd Bergmann
2014-12-18 9:28 ` Lee Jones
2014-12-18 9:28 ` Lee Jones
2014-12-18 9:28 ` Lee Jones
2014-12-17 16:45 ` [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 18:02 ` Guenter Roeck
2014-12-17 18:02 ` Guenter Roeck
2014-12-18 8:26 ` Lee Jones
2014-12-18 8:26 ` Lee Jones
2014-12-18 8:26 ` Lee Jones
2014-12-18 16:00 ` Guenter Roeck
2014-12-18 16:00 ` Guenter Roeck
2014-12-18 17:20 ` Lee Jones
2014-12-18 17:20 ` Lee Jones
2014-12-18 17:20 ` Lee Jones
2014-12-18 17:20 ` Lee Jones
2014-12-18 8:43 ` [STLinux Kernel] " Peter Griffin
2014-12-18 8:43 ` Peter Griffin
2014-12-18 8:43 ` Peter Griffin
2014-12-18 9:08 ` Lee Jones
2014-12-18 9:08 ` Lee Jones
2014-12-18 9:08 ` Lee Jones
2014-12-18 9:08 ` Lee Jones
2014-12-17 16:45 ` [PATCH 7/8] rtc: bindings: Provide ST bindings for ST's LPC RTC device Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` [PATCH 8/8] rtc: st: add new driver for ST's LPC RTC Lee Jones
2014-12-17 16:45 ` Lee Jones
2014-12-17 16:45 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5479005.CEJLtxOOIa@wuerfel \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rtc-linux@googlegroups.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.