* [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
@ 2014-11-30 2:24 Nicholas Krause
2014-11-30 13:02 ` Patrik Jakobsson
0 siblings, 1 reply; 4+ messages in thread
From: Nicholas Krause @ 2014-11-30 2:24 UTC (permalink / raw)
To: airlied; +Cc: daniel.vetter, linux-kernel, dri-devel, arthurborsboom, airlied
Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
is no needed due to never being used in the header file, psb_drv.h and therefore
should be removed from this header file.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/gpu/drm/gma500/psb_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 55ebe2b..fc74518 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -522,7 +522,6 @@ struct drm_psb_private {
struct drm_display_mode *sdvo_lvds_vbt_mode;
struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
- struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
/* Feature bits from the VBIOS */
unsigned int int_tv_support:1;
--
2.1.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
2014-11-30 2:24 [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h Nicholas Krause
@ 2014-11-30 13:02 ` Patrik Jakobsson
0 siblings, 0 replies; 4+ messages in thread
From: Patrik Jakobsson @ 2014-11-30 13:02 UTC (permalink / raw)
To: Nicholas Krause
Cc: Daniel Vetter, linux-kernel, dri-devel, Arthur Borsboom,
Dave Airlie
On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
> is no needed due to never being used in the header file, psb_drv.h and therefore
> should be removed from this header file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
The lvds_i2c_bus is in use and can't be removed. Please at least compile test
your patches before submitting them.
Cheers
Patrik
> ---
> drivers/gpu/drm/gma500/psb_drv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
> index 55ebe2b..fc74518 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.h
> +++ b/drivers/gpu/drm/gma500/psb_drv.h
> @@ -522,7 +522,6 @@ struct drm_psb_private {
> struct drm_display_mode *sdvo_lvds_vbt_mode;
>
> struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
> - struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
>
> /* Feature bits from the VBIOS */
> unsigned int int_tv_support:1;
> --
> 2.1.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
@ 2014-11-30 13:02 ` Patrik Jakobsson
0 siblings, 0 replies; 4+ messages in thread
From: Patrik Jakobsson @ 2014-11-30 13:02 UTC (permalink / raw)
To: Nicholas Krause
Cc: David Airlie, Dave Airlie, Arthur Borsboom, Daniel Vetter,
dri-devel, linux-kernel
On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
> is no needed due to never being used in the header file, psb_drv.h and therefore
> should be removed from this header file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
The lvds_i2c_bus is in use and can't be removed. Please at least compile test
your patches before submitting them.
Cheers
Patrik
> ---
> drivers/gpu/drm/gma500/psb_drv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
> index 55ebe2b..fc74518 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.h
> +++ b/drivers/gpu/drm/gma500/psb_drv.h
> @@ -522,7 +522,6 @@ struct drm_psb_private {
> struct drm_display_mode *sdvo_lvds_vbt_mode;
>
> struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
> - struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
>
> /* Feature bits from the VBIOS */
> unsigned int int_tv_support:1;
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
2014-11-30 13:02 ` Patrik Jakobsson
(?)
@ 2014-11-30 19:12 ` nick
-1 siblings, 0 replies; 4+ messages in thread
From: nick @ 2014-11-30 19:12 UTC (permalink / raw)
To: Patrik Jakobsson
Cc: Daniel Vetter, linux-kernel, dri-devel, Arthur Borsboom,
Dave Airlie
Sorry about that Patrik. I will resend a v2 with just the FIXME removed.
Regards Nick
On 2014-11-30 08:02 AM, Patrik Jakobsson wrote:
> On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
>> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
>> is no needed due to never being used in the header file, psb_drv.h and therefore
>> should be removed from this header file.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>
> The lvds_i2c_bus is in use and can't be removed. Please at least compile test
> your patches before submitting them.
>
> Cheers
> Patrik
>
>> ---
>> drivers/gpu/drm/gma500/psb_drv.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
>> index 55ebe2b..fc74518 100644
>> --- a/drivers/gpu/drm/gma500/psb_drv.h
>> +++ b/drivers/gpu/drm/gma500/psb_drv.h
>> @@ -522,7 +522,6 @@ struct drm_psb_private {
>> struct drm_display_mode *sdvo_lvds_vbt_mode;
>>
>> struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
>> - struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
>>
>> /* Feature bits from the VBIOS */
>> unsigned int int_tv_support:1;
>> --
>> 2.1.0
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-30 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-30 2:24 [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h Nicholas Krause
2014-11-30 13:02 ` Patrik Jakobsson
2014-11-30 13:02 ` Patrik Jakobsson
2014-11-30 19:12 ` nick
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.