From: Pekka Enberg <penberg@iki.fi>
To: Paul Mackerras <paulus@samba.org>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
linuxppc-dev@ozlabs.org, David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs
Date: Mon, 01 Dec 2014 11:22:27 +0200 [thread overview]
Message-ID: <547C3353.9030502@iki.fi> (raw)
In-Reply-To: <20141201042844.GB11234@drongo>
On 12/1/14 6:28 AM, Paul Mackerras wrote:
> ---
> v2: include the oops message in the patch description
>
> mm/slab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index eb2b2ea..f34e053 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3076,7 +3076,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
> void *obj;
> int x;
>
> - VM_BUG_ON(nodeid > num_online_nodes());
> + VM_BUG_ON(nodeid < 0 || nodeid >= MAX_NUMNODES);
> n = get_node(cachep, nodeid);
> BUG_ON(!n);
Reviewed-by: Pekka Enberg <penberg@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@iki.fi>
To: Paul Mackerras <paulus@samba.org>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs
Date: Mon, 01 Dec 2014 11:22:27 +0200 [thread overview]
Message-ID: <547C3353.9030502@iki.fi> (raw)
In-Reply-To: <20141201042844.GB11234@drongo>
On 12/1/14 6:28 AM, Paul Mackerras wrote:
> ---
> v2: include the oops message in the patch description
>
> mm/slab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index eb2b2ea..f34e053 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3076,7 +3076,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
> void *obj;
> int x;
>
> - VM_BUG_ON(nodeid > num_online_nodes());
> + VM_BUG_ON(nodeid < 0 || nodeid >= MAX_NUMNODES);
> n = get_node(cachep, nodeid);
> BUG_ON(!n);
Reviewed-by: Pekka Enberg <penberg@kernel.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@iki.fi>
To: Paul Mackerras <paulus@samba.org>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs
Date: Mon, 01 Dec 2014 11:22:27 +0200 [thread overview]
Message-ID: <547C3353.9030502@iki.fi> (raw)
In-Reply-To: <20141201042844.GB11234@drongo>
On 12/1/14 6:28 AM, Paul Mackerras wrote:
> ---
> v2: include the oops message in the patch description
>
> mm/slab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index eb2b2ea..f34e053 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3076,7 +3076,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
> void *obj;
> int x;
>
> - VM_BUG_ON(nodeid > num_online_nodes());
> + VM_BUG_ON(nodeid < 0 || nodeid >= MAX_NUMNODES);
> n = get_node(cachep, nodeid);
> BUG_ON(!n);
Reviewed-by: Pekka Enberg <penberg@kernel.org>
next prev parent reply other threads:[~2014-12-01 9:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 4:28 [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs Paul Mackerras
2014-12-01 4:28 ` Paul Mackerras
2014-12-01 4:28 ` Paul Mackerras
2014-12-01 4:58 ` Yasuaki Ishimatsu
2014-12-01 4:58 ` Yasuaki Ishimatsu
2014-12-01 4:58 ` Yasuaki Ishimatsu
2014-12-01 5:02 ` Michael Ellerman
2014-12-01 5:02 ` Michael Ellerman
2014-12-01 5:02 ` Michael Ellerman
2014-12-01 5:24 ` Paul Mackerras
2014-12-01 5:24 ` Paul Mackerras
2014-12-01 5:24 ` Paul Mackerras
2014-12-01 8:52 ` Michael Ellerman
2014-12-01 8:52 ` Michael Ellerman
2014-12-01 8:52 ` Michael Ellerman
2014-12-01 9:22 ` Pekka Enberg [this message]
2014-12-01 9:22 ` Pekka Enberg
2014-12-01 9:22 ` Pekka Enberg
2014-12-01 21:06 ` David Rientjes
2014-12-01 21:06 ` David Rientjes
2014-12-01 21:06 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C3353.9030502@iki.fi \
--to=penberg@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.