From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
To: Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>,
Sanjeev Sharma
<sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
Paul Gortmaker
<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
Jan Kardell <jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.orglinux
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 1 Dec 2014 15:23:25 +0530 [thread overview]
Message-ID: <547C3A95.30605@ti.com> (raw)
In-Reply-To: <20141124115116.GA14997-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Hi Sebastian,
On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote:
> * Vignesh R | 2014-11-14 10:37:25 [+0530]:
>
>> This series of patches fix TSC defects related to lag in touchscreen
>> performance and cursor jump at touch release. The lag was result of
>> udelay in TSC interrupt handler. Cursor jump due to false pen-up event.
>> The patches implement Advisory 1.0.31 in silicon errata of am335x-evm
> am335x not -evm. The am335x-evm is a board (with its own advisory
> document) built around the SoC.
>
> Just testing the v4. I can use now IIO and touchscren at the same time.
> back at v1 I reported that it does not work, this has been fixed now.
> I had it running for a few minutes, now I see one of WARN_ON() beeing
> triggered (I've cut a few numbers so don't wonder about PID 2 and so on):
>
I fixed the issue that was triggering the WARN_ON(). I think it would be
better if you tested these patches, before I posted them on the
mainline. I don't want to clutter the list with too main versions. Here
is the link to the tree with latest changes:
git clone -b tsc-devel git://git.ti.com/kernel/tsc-adc.git
(tsc-devel branch)
Please test the above tree and let me know the results.
I will post new version(v5) if there are no issues wrt IIO and TSC
working at the same time.
The cursor jump at touch release has been fixed. But I do see random
cursor movement when dragging on the screen. This is not due to false
pen-up events. My patches do not aim at fixing them. (the aim is to
remove udelay in irq handler and fix false pen-ups).
With these changes, false pen-ups have been eliminated and there is a
significant improvement in the performance of TSC. I feel these patches
can go in, if there are no other serious issues.
I will work on random cursor jump in a separate patch series.
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>, <richardcochran@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Brad Griffis <bgriffis@ti.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Kardell <jan.kardell@telliq.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <linux-input@vger.kernel.org>
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 1 Dec 2014 15:23:25 +0530 [thread overview]
Message-ID: <547C3A95.30605@ti.com> (raw)
In-Reply-To: <20141124115116.GA14997@linutronix.de>
Hi Sebastian,
On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote:
> * Vignesh R | 2014-11-14 10:37:25 [+0530]:
>
>> This series of patches fix TSC defects related to lag in touchscreen
>> performance and cursor jump at touch release. The lag was result of
>> udelay in TSC interrupt handler. Cursor jump due to false pen-up event.
>> The patches implement Advisory 1.0.31 in silicon errata of am335x-evm
> am335x not -evm. The am335x-evm is a board (with its own advisory
> document) built around the SoC.
>
> Just testing the v4. I can use now IIO and touchscren at the same time.
> back at v1 I reported that it does not work, this has been fixed now.
> I had it running for a few minutes, now I see one of WARN_ON() beeing
> triggered (I've cut a few numbers so don't wonder about PID 2 and so on):
>
I fixed the issue that was triggering the WARN_ON(). I think it would be
better if you tested these patches, before I posted them on the
mainline. I don't want to clutter the list with too main versions. Here
is the link to the tree with latest changes:
git clone -b tsc-devel git://git.ti.com/kernel/tsc-adc.git
(tsc-devel branch)
Please test the above tree and let me know the results.
I will post new version(v5) if there are no issues wrt IIO and TSC
working at the same time.
The cursor jump at touch release has been fixed. But I do see random
cursor movement when dragging on the screen. This is not due to false
pen-up events. My patches do not aim at fixing them. (the aim is to
remove udelay in irq handler and fix false pen-ups).
With these changes, false pen-ups have been eliminated and there is a
significant improvement in the performance of TSC. I feel these patches
can go in, if there are no other serious issues.
I will work on random cursor jump in a separate patch series.
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 1 Dec 2014 15:23:25 +0530 [thread overview]
Message-ID: <547C3A95.30605@ti.com> (raw)
In-Reply-To: <20141124115116.GA14997@linutronix.de>
Hi Sebastian,
On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote:
> * Vignesh R | 2014-11-14 10:37:25 [+0530]:
>
>> This series of patches fix TSC defects related to lag in touchscreen
>> performance and cursor jump at touch release. The lag was result of
>> udelay in TSC interrupt handler. Cursor jump due to false pen-up event.
>> The patches implement Advisory 1.0.31 in silicon errata of am335x-evm
> am335x not -evm. The am335x-evm is a board (with its own advisory
> document) built around the SoC.
>
> Just testing the v4. I can use now IIO and touchscren at the same time.
> back at v1 I reported that it does not work, this has been fixed now.
> I had it running for a few minutes, now I see one of WARN_ON() beeing
> triggered (I've cut a few numbers so don't wonder about PID 2 and so on):
>
I fixed the issue that was triggering the WARN_ON(). I think it would be
better if you tested these patches, before I posted them on the
mainline. I don't want to clutter the list with too main versions. Here
is the link to the tree with latest changes:
git clone -b tsc-devel git://git.ti.com/kernel/tsc-adc.git
(tsc-devel branch)
Please test the above tree and let me know the results.
I will post new version(v5) if there are no issues wrt IIO and TSC
working at the same time.
The cursor jump at touch release has been fixed. But I do see random
cursor movement when dragging on the screen. This is not due to false
pen-up events. My patches do not aim at fixing them. (the aim is to
remove udelay in irq handler and fix false pen-ups).
With these changes, false pen-ups have been eliminated and there is a
significant improvement in the performance of TSC. I feel these patches
can go in, if there are no other serious issues.
I will work on random cursor jump in a separate patch series.
Regards
Vignesh
next prev parent reply other threads:[~2014-12-01 9:53 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 5:07 [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
[not found] ` <1415941651-28962-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-14 5:07 ` [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
[not found] ` <1415941651-28962-3-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2014-11-15 19:27 ` Richard Cochran
2014-11-15 19:27 ` Richard Cochran
2014-11-15 19:27 ` Richard Cochran
[not found] ` <20141115192739.GA18766-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17 4:27 ` Vignesh R
2014-11-17 4:27 ` Vignesh R
2014-11-17 4:27 ` Vignesh R
[not found] ` <54697919.5030302-l0cyMroinI0@public.gmane.org>
2014-11-17 8:23 ` Richard Cochran
2014-11-17 8:23 ` Richard Cochran
2014-11-17 8:23 ` Richard Cochran
[not found] ` <20141117082337.GA3946-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-18 14:30 ` Lee Jones
2014-11-18 14:30 ` Lee Jones
2014-11-18 14:30 ` Lee Jones
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-20 13:56 ` Sekhar Nori
2014-11-20 13:56 ` Sekhar Nori
2014-11-20 13:56 ` Sekhar Nori
[not found] ` <546DF2F0.9080405-l0cyMroinI0@public.gmane.org>
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
[not found] ` <20141120144028.GB5809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 13:10 ` Richard Cochran
2014-11-21 13:10 ` Richard Cochran
2014-11-21 13:10 ` Richard Cochran
2014-11-21 15:11 ` Johannes Pointner
2014-11-21 15:11 ` Johannes Pointner
2014-11-21 15:11 ` Johannes Pointner
[not found] ` <CAJKbBDDVTA+=priRu7sCD=vHrC8AUg4DM3kycuGrqbpF-5FGAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 21:40 ` Richard Cochran
2014-11-21 21:40 ` Richard Cochran
2014-11-21 21:40 ` Richard Cochran
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:32 ` Johannes Pointner
[not found] ` <20141121131036.GA18931-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 10:01 ` Richard Cochran
2014-11-24 10:01 ` Richard Cochran
2014-11-24 10:01 ` Richard Cochran
2014-11-14 5:07 ` [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 5:07 ` [PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-24 11:51 ` [PATCH v4 0/6] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-11-24 11:51 ` Sebastian Andrzej Siewior
2014-11-24 11:51 ` Sebastian Andrzej Siewior
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:35 ` Sebastian Andrzej Siewior
2014-11-24 12:35 ` Sebastian Andrzej Siewior
2014-11-24 12:35 ` Sebastian Andrzej Siewior
[not found] ` <547325FA.6020004-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-11-27 4:29 ` Vignesh R
2014-11-27 4:29 ` Vignesh R
2014-11-27 4:29 ` Vignesh R
[not found] ` <20141124115116.GA14997-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-12-01 9:53 ` Vignesh R [this message]
2014-12-01 9:53 ` Vignesh R
2014-12-01 9:53 ` Vignesh R
[not found] ` <547C3A95.30605-l0cyMroinI0@public.gmane.org>
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 10:29 ` Vignesh R
2014-12-01 10:29 ` Vignesh R
2014-12-01 10:29 ` Vignesh R
[not found] ` <547C42FF.5010700-l0cyMroinI0@public.gmane.org>
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
[not found] ` <912A29987EAE174BA6CF187D7CDFA9CE26FA135A-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
[not found] ` <CABH3fy8S1Hb9LK=ZceWgJsNvLbq8pwu00Tcj_0vE4j6QzcO+kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-16 15:30 ` Richard Cochran
2014-12-16 15:30 ` Richard Cochran
2014-12-16 15:30 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C3A95.30605@ti.com \
--to=vigneshr-l0cymroini0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=bgriffis-l0cyMroinI0@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.orglinux \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.