* [PATCH] gf116: remove copy1 engine
@ 2014-11-30 17:56 Ilia Mirkin
[not found] ` <1417370178-2048-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ilia Mirkin @ 2014-11-30 17:56 UTC (permalink / raw)
To: Ben Skeggs; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Indications are that no GF116's actually have a copy engine there, but
actually have the decompression engine. This engine can be made to do
copies, but that should be done separately.
Unclear why this didn't turn up on all GF116's, but perhaps the
non-mobile ones came with enough VRAM to not trigger ttm migrations in
test scenarios.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=85465
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=59168
Cc: stable@vger.kernel.org
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
---
nvkm/engine/device/nvc0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/nvkm/engine/device/nvc0.c b/nvkm/engine/device/nvc0.c
index cd05677..72a40f9 100644
--- a/nvkm/engine/device/nvc0.c
+++ b/nvkm/engine/device/nvc0.c
@@ -218,7 +218,6 @@ nvc0_identify(struct nouveau_device *device)
device->oclass[NVDEV_ENGINE_BSP ] = &nvc0_bsp_oclass;
device->oclass[NVDEV_ENGINE_PPP ] = &nvc0_ppp_oclass;
device->oclass[NVDEV_ENGINE_COPY0 ] = &nvc0_copy0_oclass;
- device->oclass[NVDEV_ENGINE_COPY1 ] = &nvc0_copy1_oclass;
device->oclass[NVDEV_ENGINE_DISP ] = nva3_disp_oclass;
device->oclass[NVDEV_ENGINE_PERFMON] = &nvc0_perfmon_oclass;
break;
--
2.0.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1417370178-2048-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH] gf116: remove copy1 engine [not found] ` <1417370178-2048-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> @ 2014-12-01 22:18 ` Anssi Hannula 2014-12-02 21:05 ` Andy Ritger 1 sibling, 0 replies; 3+ messages in thread From: Anssi Hannula @ 2014-12-01 22:18 UTC (permalink / raw) To: Ilia Mirkin; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Ben Skeggs 30.11.2014, 19:56, Ilia Mirkin kirjoitti: > Indications are that no GF116's actually have a copy engine there, but > actually have the decompression engine. This engine can be made to do > copies, but that should be done separately. > > Unclear why this didn't turn up on all GF116's, but perhaps the > non-mobile ones came with enough VRAM to not trigger ttm migrations in > test scenarios. FWIW, I experienced this on my non-mobile GF116 when keeping the system running for several days and running graphics-intensive games. I don't have the card at hand right now so don't know how much VRAM it had, though. Thanks for getting this figured out :) > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=85465 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=59168 > Cc: stable@vger.kernel.org > Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> > --- > nvkm/engine/device/nvc0.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/nvkm/engine/device/nvc0.c b/nvkm/engine/device/nvc0.c > index cd05677..72a40f9 100644 > --- a/nvkm/engine/device/nvc0.c > +++ b/nvkm/engine/device/nvc0.c > @@ -218,7 +218,6 @@ nvc0_identify(struct nouveau_device *device) > device->oclass[NVDEV_ENGINE_BSP ] = &nvc0_bsp_oclass; > device->oclass[NVDEV_ENGINE_PPP ] = &nvc0_ppp_oclass; > device->oclass[NVDEV_ENGINE_COPY0 ] = &nvc0_copy0_oclass; > - device->oclass[NVDEV_ENGINE_COPY1 ] = &nvc0_copy1_oclass; > device->oclass[NVDEV_ENGINE_DISP ] = nva3_disp_oclass; > device->oclass[NVDEV_ENGINE_PERFMON] = &nvc0_perfmon_oclass; > break; > -- Anssi Hannula _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gf116: remove copy1 engine [not found] ` <1417370178-2048-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> 2014-12-01 22:18 ` Anssi Hannula @ 2014-12-02 21:05 ` Andy Ritger 1 sibling, 0 replies; 3+ messages in thread From: Andy Ritger @ 2014-12-02 21:05 UTC (permalink / raw) To: Ilia Mirkin; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Ben Skeggs Reviewed-by: Andy Ritger <aritger@nvidia.com> On Sun, Nov 30, 2014 at 12:56:18PM -0500, Ilia Mirkin wrote: > Indications are that no GF116's actually have a copy engine there, but > actually have the decompression engine. This engine can be made to do > copies, but that should be done separately. > > Unclear why this didn't turn up on all GF116's, but perhaps the > non-mobile ones came with enough VRAM to not trigger ttm migrations in > test scenarios. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=85465 > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=59168 > Cc: stable@vger.kernel.org > Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> > --- > nvkm/engine/device/nvc0.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/nvkm/engine/device/nvc0.c b/nvkm/engine/device/nvc0.c > index cd05677..72a40f9 100644 > --- a/nvkm/engine/device/nvc0.c > +++ b/nvkm/engine/device/nvc0.c > @@ -218,7 +218,6 @@ nvc0_identify(struct nouveau_device *device) > device->oclass[NVDEV_ENGINE_BSP ] = &nvc0_bsp_oclass; > device->oclass[NVDEV_ENGINE_PPP ] = &nvc0_ppp_oclass; > device->oclass[NVDEV_ENGINE_COPY0 ] = &nvc0_copy0_oclass; > - device->oclass[NVDEV_ENGINE_COPY1 ] = &nvc0_copy1_oclass; > device->oclass[NVDEV_ENGINE_DISP ] = nva3_disp_oclass; > device->oclass[NVDEV_ENGINE_PERFMON] = &nvc0_perfmon_oclass; > break; > -- > 2.0.4 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-02 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-30 17:56 [PATCH] gf116: remove copy1 engine Ilia Mirkin
[not found] ` <1417370178-2048-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2014-12-01 22:18 ` Anssi Hannula
2014-12-02 21:05 ` Andy Ritger
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.