From: Heesub Shin <heesub.shin@samsung.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: Add dts file for odroid XU3 board
Date: Tue, 02 Dec 2014 15:17:18 +0900 [thread overview]
Message-ID: <547D596E.9000402@samsung.com> (raw)
In-Reply-To: <1417438770-28696-1-git-send-email-sjoerd.simons@collabora.co.uk>
Hello Simons,
On 12/01/2014 09:59 PM, Sjoerd Simons wrote:
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include "exynos5800.dtsi"
Looking at exynos5800.dtsi, it derives from exynos5420.dtsi and seems
having differences on clock and mfc. Is it proper to include
exynos5800.dtsi here, instead of exynos5420.dtsi? It's just my curiosity
as I am not in a position to know detailed things on the soc. Only
semiconductor guys could answer this.
> +
> +/ {
> + model = "Hardkernel Odroid XU3";
> + compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> + memory {
> + reg = <0x20000000 0x80000000>;
> + };
Start address above should be 0x40000000, not 0x20000000.
One more thing, having bootargs which specifies 'console=xxx' would be
better.
regards,
heesub
WARNING: multiple messages have this Message-ID (diff)
From: heesub.shin@samsung.com (Heesub Shin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Add dts file for odroid XU3 board
Date: Tue, 02 Dec 2014 15:17:18 +0900 [thread overview]
Message-ID: <547D596E.9000402@samsung.com> (raw)
In-Reply-To: <1417438770-28696-1-git-send-email-sjoerd.simons@collabora.co.uk>
Hello Simons,
On 12/01/2014 09:59 PM, Sjoerd Simons wrote:
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include "exynos5800.dtsi"
Looking at exynos5800.dtsi, it derives from exynos5420.dtsi and seems
having differences on clock and mfc. Is it proper to include
exynos5800.dtsi here, instead of exynos5420.dtsi? It's just my curiosity
as I am not in a position to know detailed things on the soc. Only
semiconductor guys could answer this.
> +
> +/ {
> + model = "Hardkernel Odroid XU3";
> + compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> + memory {
> + reg = <0x20000000 0x80000000>;
> + };
Start address above should be 0x40000000, not 0x20000000.
One more thing, having bootargs which specifies 'console=xxx' would be
better.
regards,
heesub
next prev parent reply other threads:[~2014-12-02 6:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 12:59 [PATCH] ARM: dts: Add dts file for odroid XU3 board Sjoerd Simons
2014-12-01 12:59 ` Sjoerd Simons
2014-12-02 6:17 ` Heesub Shin [this message]
2014-12-02 6:17 ` Heesub Shin
2014-12-02 8:32 ` Sjoerd Simons
2014-12-02 8:32 ` Sjoerd Simons
2014-12-03 19:53 ` Kevin Hilman
2014-12-03 19:53 ` Kevin Hilman
2014-12-03 20:36 ` Sjoerd Simons
2014-12-03 20:36 ` Sjoerd Simons
2014-12-04 4:40 ` Kevin Hilman
2014-12-04 4:40 ` Kevin Hilman
2014-12-03 20:24 ` Tyler Baker
2014-12-03 20:24 ` Tyler Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547D596E.9000402@samsung.com \
--to=heesub.shin@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.