All of lore.kernel.org
 help / color / mirror / Atom feed
From: cpebenito@tresys.com (Christopher J. PeBenito)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH] Add all the missing _admin interfaces to sysadm
Date: Wed, 3 Dec 2014 08:18:46 -0500	[thread overview]
Message-ID: <547F0DB6.2060501@tresys.com> (raw)
In-Reply-To: <1417609724-28437-1-git-send-email-jason@perfinion.com>

On 12/3/2014 7:28 AM, Jason Zaman wrote:
> Lots of the foo_admin() interfaces were not applied to sysadm. This
> patch adds all the ones that were missing. Interfaces are added together
> with the matching _role() interface if it was already present.
> 
> Make all && make validate passes, but anyone else that can run any test
> suites on this would be appreciated too.

I'm not opposed to this change, but I wonder about cases like these:

> +
> +optional_policy(`
> +	asterisk_admin(sysadm_t, sysadm_r)
>  	asterisk_stream_connect(sysadm_t)
>  ')

>  optional_policy(`
> +	bacula_admin(sysadm_t, sysadm_r)
>  	bacula_run_admin(sysadm_t, sysadm_r)
>  ')

Since I would assume that the admin interface would already include the
existing rule.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

  reply	other threads:[~2014-12-03 13:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 12:28 [refpolicy] [PATCH] Add all the missing _admin interfaces to sysadm Jason Zaman
2014-12-03 13:18 ` Christopher J. PeBenito [this message]
2014-12-03 13:42   ` Jason Zaman
2014-12-03 13:56     ` Christopher J. PeBenito
2014-12-03 14:27       ` Dominick Grift
2014-12-03 15:29         ` Jason Zaman
2014-12-03 15:41           ` Dominick Grift
2014-12-03 15:44           ` Christopher J. PeBenito
2014-12-03 15:50             ` Christopher J. PeBenito
2014-12-03 15:55               ` Dominick Grift
2014-12-03 16:12                 ` Christopher J. PeBenito
2014-12-03 16:19                   ` Dominick Grift
2014-12-03 15:39       ` Dominick Grift
2014-12-03 15:50         ` Dominick Grift
2014-12-03 16:07         ` Christopher J. PeBenito
2014-12-03 16:28           ` Dominick Grift
2014-12-03 16:47             ` Christopher J. PeBenito
2015-04-03 14:29               ` Miroslav Grepl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547F0DB6.2060501@tresys.com \
    --to=cpebenito@tresys.com \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.