From: Leon Alrae <leon.alrae@imgtec.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks
Date: Wed, 3 Dec 2014 17:46:41 +0000 [thread overview]
Message-ID: <547F4C81.1070301@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1411191343210.2881@tp.orcam.me.uk>
On 19/11/2014 14:20, Maciej W. Rozycki wrote:
> - env->hflags |= MIPS_HFLAG_DM | MIPS_HFLAG_64 | MIPS_HFLAG_CP0;
> + if (env->insn_flags & ISA_MIPS3)
> + env->hflags |= MIPS_HFLAG_64;
According to the CODING_STYLE braces are required even for a single
statement "if" block. This also applies in other places in this patch.
Otherwise,
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
next prev parent reply other threads:[~2014-12-03 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:20 [Qemu-devel] [PATCH] target-mips: Tighten ISA level checks Maciej W. Rozycki
2014-12-03 17:46 ` Leon Alrae [this message]
2014-12-03 18:00 ` Maciej W. Rozycki
2014-12-03 18:05 ` [Qemu-devel] [PATCH v2] " Maciej W. Rozycki
2014-12-05 18:47 ` [Qemu-devel] [PATCH v3] " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F4C81.1070301@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.