Re: [PATCH 2/2][dizzy-next] linux-imx: add clock patch for T1.0 version of i.MX6Q

[Eric Nelson <eric.nelson@boundarydevices.com>]

Hi Gary,

On 12/03/2014 10:07 AM, Gary Bisson wrote:
> A divider was still set to 4 instead of forcing it to 1 as those video
> dividers weren't working on early revisions of the SoC.
> 
> Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
> ---
>  ...6q-fix-video-divider-for-revision-1.0-of-.patch | 33 ++++++++++++++++++++++
>  recipes-kernel/linux/linux-imx_3.10.17.bb          |  2 ++
>  2 files changed, 35 insertions(+)
>  create mode 100644 recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch
> 
> diff --git a/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch b/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch
> new file mode 100644
> index 0000000..bcddb16
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-imx-3.10.17/0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch
> @@ -0,0 +1,33 @@
> +From ffcd8b98f6ba3a2b7a4aecc1e5e454de5fa5c4c3 Mon Sep 17 00:00:00 2001
> +From: Gary Bisson <bisson.gary@gmail.com>
> +Date: Tue, 2 Dec 2014 22:11:14 -0800
> +Subject: [PATCH] ARM: clk-imx6q: fix video divider for revision 1.0 of i.MX6q
> +
> +As post dividers do not work on i.MX6Q revision 1.0 they must be fixed
> +to 1. As the table index was wrong, a divider a of 4 could still be
> +requested which implied the clock not to be set properly. This is the
> +root cause of the HDMI not working at high resolution on T1.0 version of
> +the SoC, giving the following error:
> +mxc_sdc_fb fb.27: timeout when waiting for flip irq
> +
> +Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
> +---
> + arch/arm/mach-imx/clk-imx6q.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
> +index e09b1e8..1e5c410 100644
> +--- a/arch/arm/mach-imx/clk-imx6q.c
> ++++ b/arch/arm/mach-imx/clk-imx6q.c
> +@@ -279,7 +279,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
> + 		post_div_table[1].div = 1;
> + 		post_div_table[2].div = 1;
> + 		video_div_table[1].div = 1;

This was clearly a typo, since video_div_table[2] is already
initialized to 1, whereas video_div_table[3] is initialized to 4.

> +-		video_div_table[2].div = 1;
> ++		video_div_table[3].div = 1;
> + 	};
> + 
> + 	/*                   type                               name         parent_name  base     div_mask */
> +-- 
> +2.1.3
> +
> diff --git a/recipes-kernel/linux/linux-imx_3.10.17.bb b/recipes-kernel/linux/linux-imx_3.10.17.bb
> index cae1489..143eaab 100644
> --- a/recipes-kernel/linux/linux-imx_3.10.17.bb
> +++ b/recipes-kernel/linux/linux-imx_3.10.17.bb
> @@ -15,4 +15,6 @@ SRCBRANCH = "imx_3.10.17_1.0.0_ga"
>  SRCREV = "33597e348b2d60dd5c71890ef7b7d3d3fd6e4e97"
>  LOCALVERSION = "-1.0.2_ga"
>  
> +SRC_URI += "file://0001-ARM-clk-imx6q-fix-video-divider-for-revision-1.0-of-.patch"
> +
>  COMPATIBLE_MACHINE = "(mx6)"
> 

Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

And, on a SABRE Lite with TO 1.0 using linux-boundary-3.10.17_1.0.2_ga:

Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>

For use with linux-boundary, I'd like to pull this patch directly into
our tree, so it's available to folks not using YP.